[GitHub] [spark] rdblue edited a comment on issue #25104: [SPARK-28341][SQL] remove session catalog config

[GitBox <gi...@apache.org>]

rdblue edited a comment on issue #25104: [SPARK-28341][SQL] remove session catalog config
URL: https://github.com/apache/spark/pull/25104#issuecomment-510573877
 
 
   This looks okay overall, but it breaks the test for v2 providers with the session catalog. I don't think this can be committed until that is resolved. @cloud-fan, can you test whether one of the test providers will work in place of ORC v2 in this test?
   
   The second issue is that this removes the ability to override the v2 session catalog implementation. I think we want to support that so you can modify the behavior of the v2 session catalog, but continue to use the v1 catalog for v1 cases. @cloud-fan, do you have any idea about how to make this possible?
   
   I think @brkyvz is interested in overriding the v2 session catalog as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org