[jira] [Commented] (KAFKA-2912) Add error code 4 (InvalidFetchSize) to Errors.java

["jin xing (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-2912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035872#comment-15035872 ] 

jin xing commented on KAFKA-2912:
---------------------------------

I believe the validation for fetch size should be done inside of KafkaApis : handleFetchRequets(request: RequestChannel.Request) ;
The question is how to define a fetch request is invalid?
Maybe we can judge by parameters: buffer size, fetchRequest.maxWait, fetchRequest.minBytes, quotas of throughput, request.timeout.ms...;
Is this point of view right?

> Add error code 4 (InvalidFetchSize) to Errors.java
> --------------------------------------------------
>
>                 Key: KAFKA-2912
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2912
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.9.0.0
>            Reporter: Grant Henke
>
> org.apache.kafka.common.protocol.Errors.java has:
> {quote}
> // TODO: errorCode 4 for InvalidFetchSize
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)