You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/05/14 11:33:31 UTC

[GitHub] [hbase] tomscut opened a new pull request, #4431: HBASE-27036 Displays the number of decommissioned region server for status command

tomscut opened a new pull request, #4431:
URL: https://github.com/apache/hbase/pull/4431

   JIRA: HBASE-27036.
   
   Displays the number of decommissioned region server for status command.
   ![image](https://user-images.githubusercontent.com/55134131/168423857-4a1fd824-b852-4e69-bc2c-2fd6ebf4a5b2.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] tomscut commented on pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
tomscut commented on PR #4431:
URL: https://github.com/apache/hbase/pull/4431#issuecomment-1140595728

   Hi @virajjasani , please also take a look. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] Apache-HBase commented on pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4431:
URL: https://github.com/apache/hbase/pull/4431#issuecomment-1137361563

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 13s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 35s |  master passed  |
   | +1 :green_heart: |  compile  |   2m  1s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 42s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  6s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 34s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m  1s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m  1s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 41s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  5s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 39s |  hbase-protocol-shaded in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 27s |  hbase-client in the patch passed.  |
   | +1 :green_heart: |  unit  | 198m 34s |  hbase-server in the patch passed.  |
   | +1 :green_heart: |  unit  |   6m 53s |  hbase-shell in the patch passed.  |
   |  |   | 229m 41s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/4431 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux ed5262202b13 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 194f8c2c41 |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/2/testReport/ |
   | Max. process+thread count | 2785 (vs. ulimit of 30000) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: . |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/2/console |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] tomscut commented on pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
tomscut commented on PR #4431:
URL: https://github.com/apache/hbase/pull/4431#issuecomment-1133512496

   Hi @apurtell @virajjasani @pankaj72981 , please take a look. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] Apache-HBase commented on pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4431:
URL: https://github.com/apache/hbase/pull/4431#issuecomment-1126699377

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 13s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 58s |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 13s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 37s |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 11s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   6m 47s |  hbase-shell in the patch passed.  |
   |  |   |  14m 58s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/4431 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux 4edf028134b1 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 369adcdf35 |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/1/testReport/ |
   | Max. process+thread count | 1543 (vs. ulimit of 30000) |
   | modules | C: hbase-shell U: hbase-shell |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/1/console |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] Apache9 commented on a diff in pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
Apache9 commented on code in PR #4431:
URL: https://github.com/apache/hbase/pull/4431#discussion_r878784691


##########
hbase-shell/src/main/ruby/hbase/admin.rb:
##########
@@ -1043,6 +1043,7 @@ def status(format, type)
       else
         puts "1 active master, #{cluster_metrics.getBackupMasterNames.size} backup masters,
               #{cluster_metrics.getLiveServerMetrics.size} servers,
+              #{@admin.listDecommissionedRegionServers.size} decommissioned,

Review Comment:
   We do not have this information in cluster metrics?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] tomscut commented on a diff in pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
tomscut commented on code in PR #4431:
URL: https://github.com/apache/hbase/pull/4431#discussion_r878788067


##########
hbase-shell/src/main/ruby/hbase/admin.rb:
##########
@@ -1043,6 +1043,7 @@ def status(format, type)
       else
         puts "1 active master, #{cluster_metrics.getBackupMasterNames.size} backup masters,
               #{cluster_metrics.getLiveServerMetrics.size} servers,
+              #{@admin.listDecommissionedRegionServers.size} decommissioned,

Review Comment:
   Thanks for your comment. 
   
   At first, I wanted to add `drainingRegionServers` to cluster metrics, but I found that `drainingRegionServers` already exist. In most cases, `drainingRegionServers` and `decommissionedRegionServers` may represent the same list of regionservers, so I didn't add this metric.



##########
hbase-shell/src/main/ruby/hbase/admin.rb:
##########
@@ -1043,6 +1043,7 @@ def status(format, type)
       else
         puts "1 active master, #{cluster_metrics.getBackupMasterNames.size} backup masters,
               #{cluster_metrics.getLiveServerMetrics.size} servers,
+              #{@admin.listDecommissionedRegionServers.size} decommissioned,

Review Comment:
   Thanks for your comment. 
   
   At first, I wanted to add `decommissionedRegionServers` to cluster metrics, but I found that `drainingRegionServers` already exist. In most cases, `drainingRegionServers` and `decommissionedRegionServers` may represent the same list of regionservers, so I didn't add this metric.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] tomscut commented on a diff in pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
tomscut commented on code in PR #4431:
URL: https://github.com/apache/hbase/pull/4431#discussion_r879053398


##########
hbase-shell/src/main/ruby/hbase/admin.rb:
##########
@@ -1043,6 +1043,7 @@ def status(format, type)
       else
         puts "1 active master, #{cluster_metrics.getBackupMasterNames.size} backup masters,
               #{cluster_metrics.getLiveServerMetrics.size} servers,
+              #{@admin.listDecommissionedRegionServers.size} decommissioned,

Review Comment:
   > Cluster metrics approach is better than calling additional admin API (includes a separate RPC).
   > 
   > Decommissioned and draining RegionServers are same,
   > 
   > https://github.com/apache/hbase/blob/1be2c83b3dc8306050f67828c9c2e361f19481c6/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L3821
   > 
   > Add decommissioned/draining RegionServer to ClusterMetrics class, currently it is not there.
   
   Thanks @pankaj72981 for your comments. I found `drainingRegionServers` already exist, we can see HBASE-25460. Do you mean to change `drainingRegionServers` to `decommissionedRegionServers `?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] Apache-HBase commented on pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4431:
URL: https://github.com/apache/hbase/pull/4431#issuecomment-1126699674

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 36s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  5s |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 16s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 55s |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 10s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   7m 41s |  hbase-shell in the patch passed.  |
   |  |   |  16m 43s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/4431 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux 9d51e5487c7b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 369adcdf35 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/1/testReport/ |
   | Max. process+thread count | 1390 (vs. ulimit of 30000) |
   | modules | C: hbase-shell U: hbase-shell |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/1/console |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] Apache-HBase commented on pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4431:
URL: https://github.com/apache/hbase/pull/4431#issuecomment-1141863075

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 10s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +0 :ok: |  prototool  |   0m  0s |  prototool was not available.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 10s |  master passed  |
   | +1 :green_heart: |  compile  |   4m  2s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m  1s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 41s |  branch has no errors when running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   4m 30s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 12s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m  9s |  the patch passed  |
   | +1 :green_heart: |  cc  |   4m  9s |  the patch passed  |
   | -0 :warning: |  javac  |   0m 39s |  hbase-client generated 1 new + 122 unchanged - 1 fixed = 123 total (was 123)  |
   | +1 :green_heart: |  checkstyle  |   1m  0s |  the patch passed  |
   | -0 :warning: |  rubocop  |   0m  4s |  The patch generated 1 new + 402 unchanged - 1 fixed = 403 total (was 403)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  hadoopcheck  |  11m 24s |  Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.  |
   | +1 :green_heart: |  hbaseprotoc  |   1m 37s |  the patch passed  |
   | +1 :green_heart: |  spotless  |   0m 41s |  patch has no errors when running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   4m 51s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 36s |  The patch does not generate ASF License warnings.  |
   |  |   |  45m 50s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/3/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/4431 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop |
   | uname | Linux a855ee6c9ca6 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 5c116d239f |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt |
   | rubocop | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt |
   | Max. process+thread count | 64 (vs. ulimit of 30000) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: . |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/3/console |
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] Apache9 commented on a diff in pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
Apache9 commented on code in PR #4431:
URL: https://github.com/apache/hbase/pull/4431#discussion_r878786848


##########
hbase-shell/src/main/ruby/hbase/admin.rb:
##########
@@ -1043,6 +1043,7 @@ def status(format, type)
       else
         puts "1 active master, #{cluster_metrics.getBackupMasterNames.size} backup masters,
               #{cluster_metrics.getLiveServerMetrics.size} servers,
+              #{@admin.listDecommissionedRegionServers.size} decommissioned,

Review Comment:
   Then let's add it to the cluster metrics?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] pankaj72981 commented on a diff in pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
pankaj72981 commented on code in PR #4431:
URL: https://github.com/apache/hbase/pull/4431#discussion_r879030905


##########
hbase-shell/src/main/ruby/hbase/admin.rb:
##########
@@ -1043,6 +1043,7 @@ def status(format, type)
       else
         puts "1 active master, #{cluster_metrics.getBackupMasterNames.size} backup masters,
               #{cluster_metrics.getLiveServerMetrics.size} servers,
+              #{@admin.listDecommissionedRegionServers.size} decommissioned,

Review Comment:
   Cluster metrics approach is better than calling additional admin API (includes a separate RPC). 
   
   Decommissioned and draining RegionServers are same,
   https://github.com/apache/hbase/blob/1be2c83b3dc8306050f67828c9c2e361f19481c6/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L3821
   
   Add decommissioned/draining RegionServer to ClusterMetrics class, currently it is not there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] Apache-HBase commented on pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4431:
URL: https://github.com/apache/hbase/pull/4431#issuecomment-1137137037

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 10s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +0 :ok: |  prototool  |   0m  0s |  prototool was not available.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 24s |  master passed  |
   | +1 :green_heart: |  compile  |   4m  8s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m  2s |  master passed  |
   | -1 :x: |  spotless  |   0m 37s |  branch has 22 errors when running spotless:check, run spotless:apply to fix.  |
   | +1 :green_heart: |  spotbugs  |   4m 45s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 14s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m  9s |  the patch passed  |
   | +1 :green_heart: |  cc  |   4m  9s |  the patch passed  |
   | -0 :warning: |  javac  |   0m 38s |  hbase-client generated 1 new + 122 unchanged - 1 fixed = 123 total (was 123)  |
   | +1 :green_heart: |  checkstyle  |   1m  2s |  the patch passed  |
   | -0 :warning: |  rubocop  |   0m  4s |  The patch generated 1 new + 402 unchanged - 1 fixed = 403 total (was 403)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  hadoopcheck  |  11m 47s |  Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.  |
   | +1 :green_heart: |  hbaseprotoc  |   1m 38s |  the patch passed  |
   | -1 :x: |  spotless  |   0m 36s |  patch has 22 errors when running spotless:check, run spotless:apply to fix.  |
   | +1 :green_heart: |  spotbugs  |   4m 55s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 37s |  The patch does not generate ASF License warnings.  |
   |  |   |  46m 55s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/2/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/4431 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop |
   | uname | Linux 0e730345fbb3 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 194f8c2c41 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/2/artifact/yetus-general-check/output/branch-spotless.txt |
   | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt |
   | rubocop | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt |
   | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/2/artifact/yetus-general-check/output/patch-spotless.txt |
   | Max. process+thread count | 64 (vs. ulimit of 30000) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: . |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/2/console |
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] tomscut commented on a diff in pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
tomscut commented on code in PR #4431:
URL: https://github.com/apache/hbase/pull/4431#discussion_r878785441


##########
hbase-shell/src/main/ruby/hbase/admin.rb:
##########
@@ -1043,6 +1043,7 @@ def status(format, type)
       else
         puts "1 active master, #{cluster_metrics.getBackupMasterNames.size} backup masters,
               #{cluster_metrics.getLiveServerMetrics.size} servers,
+              #{@admin.listDecommissionedRegionServers.size} decommissioned,

Review Comment:
   Thanks @Apache9 for your review.
   
    Now, we do not have `decommissionedRegionServers` in cluster metrics. But we have metrics `numDrainingRegionServers`  and `drainingRegionServers`. 
   
   There is a method `listDecommissionedRegionServers` in `Admin`,  so called directly here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] tomscut commented on pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
tomscut commented on PR #4431:
URL: https://github.com/apache/hbase/pull/4431#issuecomment-1141551076

   Hi @pankaj72981 , could you please merge this? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] Apache9 merged pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
Apache9 merged PR #4431:
URL: https://github.com/apache/hbase/pull/4431


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] pankaj72981 commented on a diff in pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
pankaj72981 commented on code in PR #4431:
URL: https://github.com/apache/hbase/pull/4431#discussion_r879247358


##########
hbase-shell/src/main/ruby/hbase/admin.rb:
##########
@@ -1043,6 +1043,7 @@ def status(format, type)
       else
         puts "1 active master, #{cluster_metrics.getBackupMasterNames.size} backup masters,
               #{cluster_metrics.getLiveServerMetrics.size} servers,
+              #{@admin.listDecommissionedRegionServers.size} decommissioned,

Review Comment:
   HBASE-25460 added draininigRegionServers as a JMX metric. Can you access it via ClusterMetrics class?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] Apache-HBase commented on pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4431:
URL: https://github.com/apache/hbase/pull/4431#issuecomment-1137446720

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 42s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 49s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 58s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 43s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 15s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 46s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 17s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 17s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 45s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  6s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 39s |  hbase-protocol-shaded in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 10s |  hbase-client in the patch passed.  |
   | -1 :x: |  unit  | 243m  3s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |   8m  1s |  hbase-shell in the patch passed.  |
   |  |   | 278m 36s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/4431 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 205a266029c9 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 194f8c2c41 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
   |  Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/2/testReport/ |
   | Max. process+thread count | 2501 (vs. ulimit of 30000) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: . |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/2/console |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] Apache-HBase commented on pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4431:
URL: https://github.com/apache/hbase/pull/4431#issuecomment-1142041862

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 10s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 35s |  master passed  |
   | +1 :green_heart: |  compile  |   2m  1s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 41s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  4s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 40s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m  1s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m  1s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 41s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  4s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 39s |  hbase-protocol-shaded in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 26s |  hbase-client in the patch passed.  |
   | +1 :green_heart: |  unit  | 198m 22s |  hbase-server in the patch passed.  |
   | +1 :green_heart: |  unit  |   6m 59s |  hbase-shell in the patch passed.  |
   |  |   | 229m 36s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/4431 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 2f9f4b632f20 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 5c116d239f |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/3/testReport/ |
   | Max. process+thread count | 3011 (vs. ulimit of 30000) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: . |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/3/console |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] tomscut commented on a diff in pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
tomscut commented on code in PR #4431:
URL: https://github.com/apache/hbase/pull/4431#discussion_r879419726


##########
hbase-shell/src/main/ruby/hbase/admin.rb:
##########
@@ -1043,6 +1043,7 @@ def status(format, type)
       else
         puts "1 active master, #{cluster_metrics.getBackupMasterNames.size} backup masters,
               #{cluster_metrics.getLiveServerMetrics.size} servers,
+              #{@admin.listDecommissionedRegionServers.size} decommissioned,

Review Comment:
   > [HBASE-25460](https://issues.apache.org/jira/browse/HBASE-25460) added draininigRegionServers as a JMX metric. Can you access it via ClusterMetrics class?
   
   Thanks @pankaj72981 for your comment. 
   
   I will try to add this to ClusterMetrics. Do you think `draininigRegionServers` or `decommissionedRegionServers` is a more appropriate metric name? @Apache9 Please also take a look. Thank you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] Apache9 commented on pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
Apache9 commented on PR #4431:
URL: https://github.com/apache/hbase/pull/4431#issuecomment-1141570040

   Let me trigger another pre commit run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] tomscut commented on pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
tomscut commented on PR #4431:
URL: https://github.com/apache/hbase/pull/4431#issuecomment-1137087815

   Hi @Apache9 @pankaj72981 , I added `decommissionedRegionServers` to ClusterMetrics. I deployed a cluster with master branch, and it works. PTAL. Thanks a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] Apache-HBase commented on pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4431:
URL: https://github.com/apache/hbase/pull/4431#issuecomment-1126698345

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 40s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 40s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 39s |  branch has no errors when running spotless:check.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   1m 58s |  the patch passed  |
   | -0 :warning: |  rubocop  |   0m  5s |  The patch generated 1 new + 402 unchanged - 1 fixed = 403 total (was 403)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  spotless  |   0m 37s |  patch has no errors when running spotless:check.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m  8s |  The patch does not generate ASF License warnings.  |
   |  |   |   9m  0s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/1/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/4431 |
   | Optional Tests | dupname asflicense javac spotless rubocop |
   | uname | Linux 64d07c7023ec 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 369adcdf35 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | rubocop | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt |
   | Max. process+thread count | 54 (vs. ulimit of 30000) |
   | modules | C: hbase-shell U: hbase-shell |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/1/console |
   | versions | git=2.17.1 maven=3.6.3 rubocop=0.80.0 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] tomscut commented on a diff in pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
tomscut commented on code in PR #4431:
URL: https://github.com/apache/hbase/pull/4431#discussion_r879419726


##########
hbase-shell/src/main/ruby/hbase/admin.rb:
##########
@@ -1043,6 +1043,7 @@ def status(format, type)
       else
         puts "1 active master, #{cluster_metrics.getBackupMasterNames.size} backup masters,
               #{cluster_metrics.getLiveServerMetrics.size} servers,
+              #{@admin.listDecommissionedRegionServers.size} decommissioned,

Review Comment:
   > [HBASE-25460](https://issues.apache.org/jira/browse/HBASE-25460) added draininigRegionServers as a JMX metric. Can you access it via ClusterMetrics class?
   
   Thanks @pankaj72981 for your comment. 
   
   I will try to add this to ClusterMetrics. Do you think `draininigRegionServers` or `decommissionedRegionServers` more appropriate? @Apache9 Please also take a look. Thank you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] Apache-HBase commented on pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4431:
URL: https://github.com/apache/hbase/pull/4431#issuecomment-1142047701

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   2m 36s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 20s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 43s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 41s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  2s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 10s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 43s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 43s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 40s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 59s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 30s |  hbase-protocol-shaded in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m  1s |  hbase-client in the patch passed.  |
   | +1 :green_heart: |  unit  | 204m 41s |  hbase-server in the patch passed.  |
   | +1 :green_heart: |  unit  |   7m 13s |  hbase-shell in the patch passed.  |
   |  |   | 235m 36s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/4431 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 6725351a404c 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 5c116d239f |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/3/testReport/ |
   | Max. process+thread count | 3233 (vs. ulimit of 30000) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: . |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4431/3/console |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] tomscut commented on pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
tomscut commented on PR #4431:
URL: https://github.com/apache/hbase/pull/4431#issuecomment-1138133312

   Thanks @pankaj72981 for your review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hbase] tomscut commented on pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

Posted by GitBox <gi...@apache.org>.
tomscut commented on PR #4431:
URL: https://github.com/apache/hbase/pull/4431#issuecomment-1138011845

   Thanks @Apache9 for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org