You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/12/13 02:39:23 UTC

[james-project] 07/27: [Refactoring] Solve intellij warnings in FetchProcessor

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit d9ca246955926eaa25f1c003c1d814bec769d21e
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Tue Dec 10 10:49:28 2019 +0700

    [Refactoring] Solve intellij warnings in FetchProcessor
---
 .../apache/james/imap/processor/fetch/FetchProcessor.java   | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/protocols/imap/src/main/java/org/apache/james/imap/processor/fetch/FetchProcessor.java b/protocols/imap/src/main/java/org/apache/james/imap/processor/fetch/FetchProcessor.java
index ef8c007..20517d3 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/processor/fetch/FetchProcessor.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/processor/fetch/FetchProcessor.java
@@ -64,7 +64,7 @@ public class FetchProcessor extends AbstractMailboxProcessor<FetchRequest> {
         final FetchData fetch = request.getFetch();
         
         try {
-            final Long changedSince = fetch.getChangedSince();
+            final long changedSince = fetch.getChangedSince();
 
             final MessageManager mailbox = getSelectedMailbox(session);
 
@@ -132,17 +132,8 @@ public class FetchProcessor extends AbstractMailboxProcessor<FetchRequest> {
     /**
      * Process the given message ranges by fetch them and pass them to the
      * {@link org.apache.james.imap.api.process.ImapProcessor.Responder}
-     * 
-     * @param session
-     * @param mailbox
-     * @param ranges
-     * @param fetch
-     * @param useUids
-     * @param mailboxSession
-     * @param responder
-     * @throws MailboxException
      */
-    protected void processMessageRanges(ImapSession session, MessageManager mailbox, List<MessageRange> ranges, FetchData fetch, boolean useUids, MailboxSession mailboxSession, Responder responder) throws MailboxException {
+    private void processMessageRanges(ImapSession session, MessageManager mailbox, List<MessageRange> ranges, FetchData fetch, boolean useUids, MailboxSession mailboxSession, Responder responder) throws MailboxException {
         final FetchResponseBuilder builder = new FetchResponseBuilder(new EnvelopeBuilder());
         FetchGroup resultToFetch = FetchDataConverter.getFetchGroup(fetch);
 


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org