You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airflow.apache.org by Kaxil Naik <ka...@gmail.com> on 2019/12/20 01:51:32 UTC
[VOTE] Add Probot Integrations to Airflow Github Repo
Hello all,
I would like to propose that we add the following ProBot integrations to
Airflow repo:
- https://github.com/apps/ci-reporter - Works with your project's CI
tool to report failed builds into the relevant PR.
- https://github.com/apps/mergeable - Prevents merging of Pull Requests
based on configurations. Make your Pull Requests mergeable only when:
- https://github.com/apps/wip/ - Prevent merging of WIP PRs
- https://github.com/apps/stale/ - Closes abandoned issues after a
period of inactivity.
We can add more integrations later but for now, I propose we add the above
4. If we have a positive consensus I will raise a JIRA issue with the
Apache INFRA team.
Regards,
Kaxil
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by hotmail <zh...@hotmail.com>.
It really quick! Thanks Jarek!
Best Wish
— Jiajie
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Jarek Potiuk <Ja...@polidea.com>.
It was quick :). Unfortunately mergable does not support commit checking,
but I quickly implemented it in Kaxil's Awesome Boring Cyborg :).
@Kaxil Naik <ka...@astronomer.io> -> Note that it requires new permission
(Commit Status : read & write). From what I saw adding permissions is a bit
misleading - after you update the app, you have to add it in App Settings
and then you can see that the permission was requested and you need to
confirm it before it is effective (but it could be only for development
version).
- PR to Kaxil's boring-cyborg:
https://github.com/kaxil/boring-cyborg/pull/2
- PR in our repo with proper configuration:
https://github.com/apache/airflow/pull/7149 (to be merged after the
Cyborg is updated).
J.
On Mon, Jan 13, 2020 at 6:27 AM Jarek Potiuk <Ja...@polidea.com>
wrote:
> Working on it :)
>
> On Mon, Jan 13, 2020 at 3:50 AM hotmail <zh...@hotmail.com>
> wrote:
>
>> I just found out some of our PR title have specific `AIRFLOW-XXXX` or
>> `AIRFLOW-\d{4}`, but git commit message don’t, such as
>> https://github.com/apache/airflow/pull/7144 <
>> https://github.com/apache/airflow/pull/7144>, Could we add some bot to
>> check git commit message?
>>
>>
>> Best Wish
>> — Jiajie
>>
>>
>
> --
>
> Jarek Potiuk
> Polidea <https://www.polidea.com/> | Principal Software Engineer
>
> M: +48 660 796 129 <+48660796129>
> [image: Polidea] <https://www.polidea.com/>
>
>
--
Jarek Potiuk
Polidea <https://www.polidea.com/> | Principal Software Engineer
M: +48 660 796 129 <+48660796129>
[image: Polidea] <https://www.polidea.com/>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Jarek Potiuk <Ja...@polidea.com>.
Working on it :)
On Mon, Jan 13, 2020 at 3:50 AM hotmail <zh...@hotmail.com> wrote:
> I just found out some of our PR title have specific `AIRFLOW-XXXX` or
> `AIRFLOW-\d{4}`, but git commit message don’t, such as
> https://github.com/apache/airflow/pull/7144 <
> https://github.com/apache/airflow/pull/7144>, Could we add some bot to
> check git commit message?
>
>
> Best Wish
> — Jiajie
>
>
--
Jarek Potiuk
Polidea <https://www.polidea.com/> | Principal Software Engineer
M: +48 660 796 129 <+48660796129>
[image: Polidea] <https://www.polidea.com/>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by hotmail <zh...@hotmail.com>.
I just found out some of our PR title have specific `AIRFLOW-XXXX` or `AIRFLOW-\d{4}`, but git commit message don’t, such as https://github.com/apache/airflow/pull/7144 <https://github.com/apache/airflow/pull/7144>, Could we add some bot to check git commit message?
Best Wish
— Jiajie
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by "Driesprong, Fokko" <fo...@driesprong.frl>.
The reason why we stopped using mention-bot was that it was a hosted
instance that wasn't maintained anymore. I really liked the mention-bot :-)
Cheers, Fokko
Op zo 5 jan. 2020 om 09:56 schreef Jarek Potiuk <Ja...@polidea.com>:
> 👍💟
>
> On Sun, Jan 5, 2020 at 4:38 AM Kaxil Naik <ka...@gmail.com> wrote:
>
> > I have created a Github app using Probot:
> > https://github.com/kaxil/boring-cyborg.
> >
> > This is integrated with Airflow and we now have auto-labeling enabled
> based
> > on filepaths of the changes files in the PR.
> >
> > We can add more integrations iteratively in the "boring-cyborg" and
> > automate other boring chores in Airflow.
> >
> > @Max - Do you want me to raise a PR with superset to integrate this
> Github
> > App or just copy/paste the code to the Superset bot?
> >
> > Regards,
> > Kaxil
> >
> > Regards,
> > Kaxil
> >
> > On Sat, Jan 4, 2020 at 10:53 AM Jarek Potiuk <Ja...@polidea.com>
> > wrote:
> >
> > > Those both are cool. Love them :).
> > >
> > > Why not use the periodic labeler workaround? It seems to do the trick
> and
> > > uses the same configuration and does not seem to have any negative side
> > > effects.
> > >
> > > I think auto-labelling our PRs would be a great step (together with
> > working
> > > stale bot) towards making more organised process about
> triaging/handling
> > > PRs.
> > >
> > > J.
> > >
> > >
> > > On Sat, Jan 4, 2020 at 3:28 AM Kaxil Naik <ka...@gmail.com> wrote:
> > >
> > > > On digging further I found out that it is an open BUG on both the
> > Github
> > > > actions:
> > > >
> > > > Bug: https://github.com/actions/labeler/issues/12 or
> > > > https://github.com/actions/first-interaction/issues/10
> > > >
> > > >
> > > > *Details*:
> > > >
> > > > Quoting the Author:
> > > > ----
> > > > Workflows are run in the context "of the repository". But when any
> > > workflow
> > > > is run because a pull request triggered it, then the token is
> > downgraded
> > > to
> > > > a read-only token.
> > > > It's not "the fork's token", it's still the repository's token, it's
> > just
> > > > read-only.
> > > > This is intentional. It's so that somebody can't open a pull request
> > that
> > > > gives them a token that they could use to write to your repository.
> > > > ----
> > > >
> > > > They are working towards fixing this but I am removing the
> integrations
> > > > meanwhile. There is a workaround -
> > > > https://github.com/actions/labeler/issues/12#issuecomment-555746868
> > but
> > > I
> > > > don't want to use it until it is resolved in the original repo.
> > > >
> > > >
> > > > Regards,
> > > > Kaxil
> > > >
> > > >
> > > >
> > > >
> > > > On Sat, Jan 4, 2020 at 1:07 AM Kaxil Naik <ka...@gmail.com>
> wrote:
> > > >
> > > > > I think I was wrong. We still need permission from INFRA to enable
> > the
> > > > > GITHUB_TOKEN, I have raised an ISSUE with INFRA team:
> > > > > https://issues.apache.org/jira/browse/INFRA-19657
> > > > >
> > > > > Apache Spark recently added a Github Action for Stable
> > > > > <https://github.com/apache/spark/pull/26877>, hence I thought we
> > won't
> > > > > require any perms from INFRA team. Although it didn't threw them
> > error
> > > as
> > > > > the stale bot didn't actually need to take any action yet.
> Similarly
> > > the
> > > > 2
> > > > > Github actions seems to pass all time in Airflow repo except when
> > they
> > > > need
> > > > > to actually add labels.
> > > > >
> > > > > Hopefully, the INFRA team will enable this soon as we just read
> > > > permission
> > > > > and write-on labels.
> > > > >
> > > > > Regards,
> > > > > Kaxil
> > > > >
> > > > > On Fri, Jan 3, 2020 at 11:07 PM Kaxil Naik <ka...@gmail.com>
> > > wrote:
> > > > >
> > > > >> I tried some Github actions today and fell in love. We don't even
> > need
> > > > to
> > > > >> ask for approval from INFRA team.
> > > > >>
> > > > >> I have raised 2 PRs:
> > > > >>
> > > > >> - https://github.com/apache/airflow/pull/7032 - Add Labels on
> > PRs
> > > > >> based on file/dir
> > > > >> - https://github.com/apache/airflow/pull/7031 - Welcome First
> > time
> > > > >> contributors
> > > > >>
> > > > >> to integrate this in Airflow too. I have tested them on my other
> > repo
> > > > and
> > > > >> works like a charm.
> > > > >>
> > > > >> Regards,
> > > > >> Kaxil
> > > > >>
> > > > >> On Fri, Jan 3, 2020 at 2:38 PM Kaxil Naik <ka...@gmail.com>
> > > wrote:
> > > > >>
> > > > >>> Yeah the mention-bot was archived and is no longer maintained.
> > > > >>>
> > > > >>> On Fri, Jan 3, 2020 at 2:33 PM Tomasz Urbaszek <
> > > > >>> tomasz.urbaszek@polidea.com> wrote:
> > > > >>>
> > > > >>>> Hi all,
> > > > >>>>
> > > > >>>> I just discovered that some time ago we already used
> "mention-bot"
> > > > that
> > > > >>>> suggests
> > > > >>>> potential reviewers based on history of changed files:
> > > > >>>>
> > https://github.com/apache/airflow/pull/2558#issuecomment-326686092
> > > > >>>>
> > > > >>>> T.
> > > > >>>>
> > > > >>>>
> > > > >>>> On Thu, Jan 2, 2020 at 2:33 AM Jarek Potiuk <
> > > Jarek.Potiuk@polidea.com
> > > > >
> > > > >>>> wrote:
> > > > >>>>
> > > > >>>> > On Wed, Jan 1, 2020 at 11:47 PM Jarek Potiuk <
> > > > >>>> Jarek.Potiuk@polidea.com>
> > > > >>>> > wrote:
> > > > >>>> >
> > > > >>>> > > One thing I realized after using the 4 Probot Integrations
> is
> > > that
> > > > >>>> some
> > > > >>>> > of
> > > > >>>> > >> the Probot apps are not actively maintained and might even
> be
> > > > >>>> broken.
> > > > >>>> > >>
> > > > >>>> > >
> > > > >>>> > Yeah. Even if limited my search to only the "featured ones"
> > seems
> > > > >>>> like not
> > > > >>>> > all of them are good.
> > > > >>>> > Luckily it's easy to enable/disable them when needed.
> > > > >>>> >
> > > > >>>> > However I think maybe the right approach is "try before buy".
> > > > >>>> > I will try some of them on our internal fork where we work and
> > > then
> > > > >>>> once I
> > > > >>>> > get
> > > > >>>> > some hands-on we can decide if it makes sense to use them or
> > not.
> > > > >>>> It's a
> > > > >>>> > bit of a hassle that
> > > > >>>> > we have to open an issue to infra to get those added/removed
> so
> > > It's
> > > > >>>> easier
> > > > >>>> > to try them on our repo.
> > > > >>>> > I already added the "pull" one to synchronize our fork (pretty
> > > > useful
> > > > >>>> but
> > > > >>>> > spammy).
> > > > >>>> >
> > > > >>>> >
> > > > >>>> > - https://probot.github.io/apps/welcome/ : This one has this
> > > > >>>> > >> <https://github.com/behaviorbot/welcome/issues/12>
> > particular
> > > > >>>> issue
> > > > >>>> > open
> > > > >>>> > >> that might not make the experience pleasant for
> contributors.
> > > > >>>> > >>
> > > > >>>> > > OK. That's no go :).
> > > > >>>> >
> > > > >>>> >
> > > > >>>> > > - https://github.com/mithro/autolabeler: Need to test if it
> > is
> > > > >>>> working
> > > > >>>> > as
> > > > >>>> > >> it looks a bit outdated (and not actively maintained - no
> > > replies
> > > > >>>> on
> > > > >>>> > >> issues
> > > > >>>> > >
> > > > >>>> > >
> > > > >>>> > I will try. But I'd love to get those features in Max's probot
> > > > >>>> instead in
> > > > >>>> > this case (I know it was on his list).
> > > > >>>> >
> > > > >>>> >
> > > > >>>> > > - https://probot.github.io/apps/pr-triage/ : Might be good
> to
> > > > have
> > > > >>>> but
> > > > >>>> > >> this
> > > > >>>> > >> issue <https://github.com/pr-triage/app/issues/181> might
> > bite
> > > > us
> > > > >>>> too.
> > > > >>>> > >> Not
> > > > >>>> > >> a major problem but just something to note.
> > > > >>>> > >>
> > > > >>>> > >
> > > > >>>> > Right. I think we might soon get down to a manageable number
> of
> > > > >>>> issues as
> > > > >>>> > the stalebot does it's job finally.
> > > > >>>> > So maybe we won't need that one.
> > > > >>>> >
> > > > >>>> >
> > > > >>>> > > - https://probot.github.io/apps/tests-checker/ : I liked
> this
> > > one
> > > > >>>> > >>
> > > > >>>> > >
> > > > >>>> > I like it too but I will try it :). I am afraid it might be a
> > bit
> > > > >>>> offensive
> > > > >>>> > at times though.
> > > > >>>> >
> > > > >>>> >
> > > > >>>> > > - https://probot.github.io/apps/reminders/ : Again might be
> > > > >>>> outdated but
> > > > >>>> > >> would need some testing to see if it actually works.
> > > > >>>> > >
> > > > >>>> > >
> > > > >>>> > It's just a nuance - not high priority at all.
> > > > >>>> >
> > > > >>>> >
> > > > >>>> > > - https://github.com/z0al/dep : I liked this one too but it
> > > > >>>> currently
> > > > >>>> > only
> > > > >>>> > >> matches on "#PR_NUMBER". Open Issue <
> > > > >>>> > >> https://github.com/z0al/dep/issues/18> so
> > > > >>>> > >> would want to hear opinions from others.
> > > > >>>> > >
> > > > >>>> > >
> > > > >>>> > I really love that one. It very well reflects the pattern we
> > have
> > > > for
> > > > >>>> some
> > > > >>>> > complex changes. which require multiple commits.
> > > > >>>> > And it's very good for it to depend on #PR number. It's super
> > easy
> > > > >>>> when you
> > > > >>>> > type "Depends on #<START_TYPING_HERE>" -
> > > > >>>> > you can start typing JIRA_ID or part of description and it
> will
> > > > >>>> auto-show
> > > > >>>> > the list of matching PRs. We do not have multiple repos
> > > > >>>> > so the issue https://github.com/z0al/dep/issues/18 is not
> > really
> > > > >>>> relevant
> > > > >>>> > in our case.
> > > > >>>> >
> > > > >>>> > And if we have it working we will not need to add this funny
> > > > "Depends
> > > > >>>> on
> > > > >>>> > [AIRFLOW-NNNN]". We will see immediately when PR is not
> > mergeable
> > > > >>>> > because it depends on other PRs without these extra
> > descriptions.
> > > > >>>> >
> > > > >>>> >
> > > > >>>> > >> @Max - I like your idea and maybe long term it might make
> > more
> > > > >>>> sense.
> > > > >>>> > >> Happy
> > > > >>>> > >> to help in the effort so that we can make it more
> *general*.
> > > > >>>> > >>
> > > > >>>> > >
> > > > >>>> > Max - happy to contribute to the SuperSet probot as well. It
> > would
> > > > be
> > > > >>>> great
> > > > >>>> > to do cross-project work on it :). Synergies.
> > > > >>>> >
> > > > >>>>
> > > > >>>>
> > > > >>>> --
> > > > >>>>
> > > > >>>> Tomasz Urbaszek
> > > > >>>> Polidea <https://www.polidea.com/> | Software Engineer
> > > > >>>>
> > > > >>>> M: +48 505 628 493 <+48505628493>
> > > > >>>> E: tomasz.urbaszek@polidea.com <to...@polidea.com>
> > > > >>>>
> > > > >>>> Unique Tech
> > > > >>>> Check out our projects! <https://www.polidea.com/our-work>
> > > > >>>>
> > > > >>>
> > > >
> > >
> > >
> > > --
> > >
> > > Jarek Potiuk
> > > Polidea <https://www.polidea.com/> | Principal Software Engineer
> > >
> > > M: +48 660 796 129 <+48660796129>
> > > [image: Polidea] <https://www.polidea.com/>
> > >
> >
>
>
> --
>
> Jarek Potiuk
> Polidea <https://www.polidea.com/> | Principal Software Engineer
>
> M: +48 660 796 129 <+48660796129>
> [image: Polidea] <https://www.polidea.com/>
>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Jarek Potiuk <Ja...@polidea.com>.
👍💟
On Sun, Jan 5, 2020 at 4:38 AM Kaxil Naik <ka...@gmail.com> wrote:
> I have created a Github app using Probot:
> https://github.com/kaxil/boring-cyborg.
>
> This is integrated with Airflow and we now have auto-labeling enabled based
> on filepaths of the changes files in the PR.
>
> We can add more integrations iteratively in the "boring-cyborg" and
> automate other boring chores in Airflow.
>
> @Max - Do you want me to raise a PR with superset to integrate this Github
> App or just copy/paste the code to the Superset bot?
>
> Regards,
> Kaxil
>
> Regards,
> Kaxil
>
> On Sat, Jan 4, 2020 at 10:53 AM Jarek Potiuk <Ja...@polidea.com>
> wrote:
>
> > Those both are cool. Love them :).
> >
> > Why not use the periodic labeler workaround? It seems to do the trick and
> > uses the same configuration and does not seem to have any negative side
> > effects.
> >
> > I think auto-labelling our PRs would be a great step (together with
> working
> > stale bot) towards making more organised process about triaging/handling
> > PRs.
> >
> > J.
> >
> >
> > On Sat, Jan 4, 2020 at 3:28 AM Kaxil Naik <ka...@gmail.com> wrote:
> >
> > > On digging further I found out that it is an open BUG on both the
> Github
> > > actions:
> > >
> > > Bug: https://github.com/actions/labeler/issues/12 or
> > > https://github.com/actions/first-interaction/issues/10
> > >
> > >
> > > *Details*:
> > >
> > > Quoting the Author:
> > > ----
> > > Workflows are run in the context "of the repository". But when any
> > workflow
> > > is run because a pull request triggered it, then the token is
> downgraded
> > to
> > > a read-only token.
> > > It's not "the fork's token", it's still the repository's token, it's
> just
> > > read-only.
> > > This is intentional. It's so that somebody can't open a pull request
> that
> > > gives them a token that they could use to write to your repository.
> > > ----
> > >
> > > They are working towards fixing this but I am removing the integrations
> > > meanwhile. There is a workaround -
> > > https://github.com/actions/labeler/issues/12#issuecomment-555746868
> but
> > I
> > > don't want to use it until it is resolved in the original repo.
> > >
> > >
> > > Regards,
> > > Kaxil
> > >
> > >
> > >
> > >
> > > On Sat, Jan 4, 2020 at 1:07 AM Kaxil Naik <ka...@gmail.com> wrote:
> > >
> > > > I think I was wrong. We still need permission from INFRA to enable
> the
> > > > GITHUB_TOKEN, I have raised an ISSUE with INFRA team:
> > > > https://issues.apache.org/jira/browse/INFRA-19657
> > > >
> > > > Apache Spark recently added a Github Action for Stable
> > > > <https://github.com/apache/spark/pull/26877>, hence I thought we
> won't
> > > > require any perms from INFRA team. Although it didn't threw them
> error
> > as
> > > > the stale bot didn't actually need to take any action yet. Similarly
> > the
> > > 2
> > > > Github actions seems to pass all time in Airflow repo except when
> they
> > > need
> > > > to actually add labels.
> > > >
> > > > Hopefully, the INFRA team will enable this soon as we just read
> > > permission
> > > > and write-on labels.
> > > >
> > > > Regards,
> > > > Kaxil
> > > >
> > > > On Fri, Jan 3, 2020 at 11:07 PM Kaxil Naik <ka...@gmail.com>
> > wrote:
> > > >
> > > >> I tried some Github actions today and fell in love. We don't even
> need
> > > to
> > > >> ask for approval from INFRA team.
> > > >>
> > > >> I have raised 2 PRs:
> > > >>
> > > >> - https://github.com/apache/airflow/pull/7032 - Add Labels on
> PRs
> > > >> based on file/dir
> > > >> - https://github.com/apache/airflow/pull/7031 - Welcome First
> time
> > > >> contributors
> > > >>
> > > >> to integrate this in Airflow too. I have tested them on my other
> repo
> > > and
> > > >> works like a charm.
> > > >>
> > > >> Regards,
> > > >> Kaxil
> > > >>
> > > >> On Fri, Jan 3, 2020 at 2:38 PM Kaxil Naik <ka...@gmail.com>
> > wrote:
> > > >>
> > > >>> Yeah the mention-bot was archived and is no longer maintained.
> > > >>>
> > > >>> On Fri, Jan 3, 2020 at 2:33 PM Tomasz Urbaszek <
> > > >>> tomasz.urbaszek@polidea.com> wrote:
> > > >>>
> > > >>>> Hi all,
> > > >>>>
> > > >>>> I just discovered that some time ago we already used "mention-bot"
> > > that
> > > >>>> suggests
> > > >>>> potential reviewers based on history of changed files:
> > > >>>>
> https://github.com/apache/airflow/pull/2558#issuecomment-326686092
> > > >>>>
> > > >>>> T.
> > > >>>>
> > > >>>>
> > > >>>> On Thu, Jan 2, 2020 at 2:33 AM Jarek Potiuk <
> > Jarek.Potiuk@polidea.com
> > > >
> > > >>>> wrote:
> > > >>>>
> > > >>>> > On Wed, Jan 1, 2020 at 11:47 PM Jarek Potiuk <
> > > >>>> Jarek.Potiuk@polidea.com>
> > > >>>> > wrote:
> > > >>>> >
> > > >>>> > > One thing I realized after using the 4 Probot Integrations is
> > that
> > > >>>> some
> > > >>>> > of
> > > >>>> > >> the Probot apps are not actively maintained and might even be
> > > >>>> broken.
> > > >>>> > >>
> > > >>>> > >
> > > >>>> > Yeah. Even if limited my search to only the "featured ones"
> seems
> > > >>>> like not
> > > >>>> > all of them are good.
> > > >>>> > Luckily it's easy to enable/disable them when needed.
> > > >>>> >
> > > >>>> > However I think maybe the right approach is "try before buy".
> > > >>>> > I will try some of them on our internal fork where we work and
> > then
> > > >>>> once I
> > > >>>> > get
> > > >>>> > some hands-on we can decide if it makes sense to use them or
> not.
> > > >>>> It's a
> > > >>>> > bit of a hassle that
> > > >>>> > we have to open an issue to infra to get those added/removed so
> > It's
> > > >>>> easier
> > > >>>> > to try them on our repo.
> > > >>>> > I already added the "pull" one to synchronize our fork (pretty
> > > useful
> > > >>>> but
> > > >>>> > spammy).
> > > >>>> >
> > > >>>> >
> > > >>>> > - https://probot.github.io/apps/welcome/ : This one has this
> > > >>>> > >> <https://github.com/behaviorbot/welcome/issues/12>
> particular
> > > >>>> issue
> > > >>>> > open
> > > >>>> > >> that might not make the experience pleasant for contributors.
> > > >>>> > >>
> > > >>>> > > OK. That's no go :).
> > > >>>> >
> > > >>>> >
> > > >>>> > > - https://github.com/mithro/autolabeler: Need to test if it
> is
> > > >>>> working
> > > >>>> > as
> > > >>>> > >> it looks a bit outdated (and not actively maintained - no
> > replies
> > > >>>> on
> > > >>>> > >> issues
> > > >>>> > >
> > > >>>> > >
> > > >>>> > I will try. But I'd love to get those features in Max's probot
> > > >>>> instead in
> > > >>>> > this case (I know it was on his list).
> > > >>>> >
> > > >>>> >
> > > >>>> > > - https://probot.github.io/apps/pr-triage/ : Might be good to
> > > have
> > > >>>> but
> > > >>>> > >> this
> > > >>>> > >> issue <https://github.com/pr-triage/app/issues/181> might
> bite
> > > us
> > > >>>> too.
> > > >>>> > >> Not
> > > >>>> > >> a major problem but just something to note.
> > > >>>> > >>
> > > >>>> > >
> > > >>>> > Right. I think we might soon get down to a manageable number of
> > > >>>> issues as
> > > >>>> > the stalebot does it's job finally.
> > > >>>> > So maybe we won't need that one.
> > > >>>> >
> > > >>>> >
> > > >>>> > > - https://probot.github.io/apps/tests-checker/ : I liked this
> > one
> > > >>>> > >>
> > > >>>> > >
> > > >>>> > I like it too but I will try it :). I am afraid it might be a
> bit
> > > >>>> offensive
> > > >>>> > at times though.
> > > >>>> >
> > > >>>> >
> > > >>>> > > - https://probot.github.io/apps/reminders/ : Again might be
> > > >>>> outdated but
> > > >>>> > >> would need some testing to see if it actually works.
> > > >>>> > >
> > > >>>> > >
> > > >>>> > It's just a nuance - not high priority at all.
> > > >>>> >
> > > >>>> >
> > > >>>> > > - https://github.com/z0al/dep : I liked this one too but it
> > > >>>> currently
> > > >>>> > only
> > > >>>> > >> matches on "#PR_NUMBER". Open Issue <
> > > >>>> > >> https://github.com/z0al/dep/issues/18> so
> > > >>>> > >> would want to hear opinions from others.
> > > >>>> > >
> > > >>>> > >
> > > >>>> > I really love that one. It very well reflects the pattern we
> have
> > > for
> > > >>>> some
> > > >>>> > complex changes. which require multiple commits.
> > > >>>> > And it's very good for it to depend on #PR number. It's super
> easy
> > > >>>> when you
> > > >>>> > type "Depends on #<START_TYPING_HERE>" -
> > > >>>> > you can start typing JIRA_ID or part of description and it will
> > > >>>> auto-show
> > > >>>> > the list of matching PRs. We do not have multiple repos
> > > >>>> > so the issue https://github.com/z0al/dep/issues/18 is not
> really
> > > >>>> relevant
> > > >>>> > in our case.
> > > >>>> >
> > > >>>> > And if we have it working we will not need to add this funny
> > > "Depends
> > > >>>> on
> > > >>>> > [AIRFLOW-NNNN]". We will see immediately when PR is not
> mergeable
> > > >>>> > because it depends on other PRs without these extra
> descriptions.
> > > >>>> >
> > > >>>> >
> > > >>>> > >> @Max - I like your idea and maybe long term it might make
> more
> > > >>>> sense.
> > > >>>> > >> Happy
> > > >>>> > >> to help in the effort so that we can make it more *general*.
> > > >>>> > >>
> > > >>>> > >
> > > >>>> > Max - happy to contribute to the SuperSet probot as well. It
> would
> > > be
> > > >>>> great
> > > >>>> > to do cross-project work on it :). Synergies.
> > > >>>> >
> > > >>>>
> > > >>>>
> > > >>>> --
> > > >>>>
> > > >>>> Tomasz Urbaszek
> > > >>>> Polidea <https://www.polidea.com/> | Software Engineer
> > > >>>>
> > > >>>> M: +48 505 628 493 <+48505628493>
> > > >>>> E: tomasz.urbaszek@polidea.com <to...@polidea.com>
> > > >>>>
> > > >>>> Unique Tech
> > > >>>> Check out our projects! <https://www.polidea.com/our-work>
> > > >>>>
> > > >>>
> > >
> >
> >
> > --
> >
> > Jarek Potiuk
> > Polidea <https://www.polidea.com/> | Principal Software Engineer
> >
> > M: +48 660 796 129 <+48660796129>
> > [image: Polidea] <https://www.polidea.com/>
> >
>
--
Jarek Potiuk
Polidea <https://www.polidea.com/> | Principal Software Engineer
M: +48 660 796 129 <+48660796129>
[image: Polidea] <https://www.polidea.com/>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Kaxil Naik <ka...@gmail.com>.
I have created a Github app using Probot:
https://github.com/kaxil/boring-cyborg.
This is integrated with Airflow and we now have auto-labeling enabled based
on filepaths of the changes files in the PR.
We can add more integrations iteratively in the "boring-cyborg" and
automate other boring chores in Airflow.
@Max - Do you want me to raise a PR with superset to integrate this Github
App or just copy/paste the code to the Superset bot?
Regards,
Kaxil
Regards,
Kaxil
On Sat, Jan 4, 2020 at 10:53 AM Jarek Potiuk <Ja...@polidea.com>
wrote:
> Those both are cool. Love them :).
>
> Why not use the periodic labeler workaround? It seems to do the trick and
> uses the same configuration and does not seem to have any negative side
> effects.
>
> I think auto-labelling our PRs would be a great step (together with working
> stale bot) towards making more organised process about triaging/handling
> PRs.
>
> J.
>
>
> On Sat, Jan 4, 2020 at 3:28 AM Kaxil Naik <ka...@gmail.com> wrote:
>
> > On digging further I found out that it is an open BUG on both the Github
> > actions:
> >
> > Bug: https://github.com/actions/labeler/issues/12 or
> > https://github.com/actions/first-interaction/issues/10
> >
> >
> > *Details*:
> >
> > Quoting the Author:
> > ----
> > Workflows are run in the context "of the repository". But when any
> workflow
> > is run because a pull request triggered it, then the token is downgraded
> to
> > a read-only token.
> > It's not "the fork's token", it's still the repository's token, it's just
> > read-only.
> > This is intentional. It's so that somebody can't open a pull request that
> > gives them a token that they could use to write to your repository.
> > ----
> >
> > They are working towards fixing this but I am removing the integrations
> > meanwhile. There is a workaround -
> > https://github.com/actions/labeler/issues/12#issuecomment-555746868 but
> I
> > don't want to use it until it is resolved in the original repo.
> >
> >
> > Regards,
> > Kaxil
> >
> >
> >
> >
> > On Sat, Jan 4, 2020 at 1:07 AM Kaxil Naik <ka...@gmail.com> wrote:
> >
> > > I think I was wrong. We still need permission from INFRA to enable the
> > > GITHUB_TOKEN, I have raised an ISSUE with INFRA team:
> > > https://issues.apache.org/jira/browse/INFRA-19657
> > >
> > > Apache Spark recently added a Github Action for Stable
> > > <https://github.com/apache/spark/pull/26877>, hence I thought we won't
> > > require any perms from INFRA team. Although it didn't threw them error
> as
> > > the stale bot didn't actually need to take any action yet. Similarly
> the
> > 2
> > > Github actions seems to pass all time in Airflow repo except when they
> > need
> > > to actually add labels.
> > >
> > > Hopefully, the INFRA team will enable this soon as we just read
> > permission
> > > and write-on labels.
> > >
> > > Regards,
> > > Kaxil
> > >
> > > On Fri, Jan 3, 2020 at 11:07 PM Kaxil Naik <ka...@gmail.com>
> wrote:
> > >
> > >> I tried some Github actions today and fell in love. We don't even need
> > to
> > >> ask for approval from INFRA team.
> > >>
> > >> I have raised 2 PRs:
> > >>
> > >> - https://github.com/apache/airflow/pull/7032 - Add Labels on PRs
> > >> based on file/dir
> > >> - https://github.com/apache/airflow/pull/7031 - Welcome First time
> > >> contributors
> > >>
> > >> to integrate this in Airflow too. I have tested them on my other repo
> > and
> > >> works like a charm.
> > >>
> > >> Regards,
> > >> Kaxil
> > >>
> > >> On Fri, Jan 3, 2020 at 2:38 PM Kaxil Naik <ka...@gmail.com>
> wrote:
> > >>
> > >>> Yeah the mention-bot was archived and is no longer maintained.
> > >>>
> > >>> On Fri, Jan 3, 2020 at 2:33 PM Tomasz Urbaszek <
> > >>> tomasz.urbaszek@polidea.com> wrote:
> > >>>
> > >>>> Hi all,
> > >>>>
> > >>>> I just discovered that some time ago we already used "mention-bot"
> > that
> > >>>> suggests
> > >>>> potential reviewers based on history of changed files:
> > >>>> https://github.com/apache/airflow/pull/2558#issuecomment-326686092
> > >>>>
> > >>>> T.
> > >>>>
> > >>>>
> > >>>> On Thu, Jan 2, 2020 at 2:33 AM Jarek Potiuk <
> Jarek.Potiuk@polidea.com
> > >
> > >>>> wrote:
> > >>>>
> > >>>> > On Wed, Jan 1, 2020 at 11:47 PM Jarek Potiuk <
> > >>>> Jarek.Potiuk@polidea.com>
> > >>>> > wrote:
> > >>>> >
> > >>>> > > One thing I realized after using the 4 Probot Integrations is
> that
> > >>>> some
> > >>>> > of
> > >>>> > >> the Probot apps are not actively maintained and might even be
> > >>>> broken.
> > >>>> > >>
> > >>>> > >
> > >>>> > Yeah. Even if limited my search to only the "featured ones" seems
> > >>>> like not
> > >>>> > all of them are good.
> > >>>> > Luckily it's easy to enable/disable them when needed.
> > >>>> >
> > >>>> > However I think maybe the right approach is "try before buy".
> > >>>> > I will try some of them on our internal fork where we work and
> then
> > >>>> once I
> > >>>> > get
> > >>>> > some hands-on we can decide if it makes sense to use them or not.
> > >>>> It's a
> > >>>> > bit of a hassle that
> > >>>> > we have to open an issue to infra to get those added/removed so
> It's
> > >>>> easier
> > >>>> > to try them on our repo.
> > >>>> > I already added the "pull" one to synchronize our fork (pretty
> > useful
> > >>>> but
> > >>>> > spammy).
> > >>>> >
> > >>>> >
> > >>>> > - https://probot.github.io/apps/welcome/ : This one has this
> > >>>> > >> <https://github.com/behaviorbot/welcome/issues/12> particular
> > >>>> issue
> > >>>> > open
> > >>>> > >> that might not make the experience pleasant for contributors.
> > >>>> > >>
> > >>>> > > OK. That's no go :).
> > >>>> >
> > >>>> >
> > >>>> > > - https://github.com/mithro/autolabeler: Need to test if it is
> > >>>> working
> > >>>> > as
> > >>>> > >> it looks a bit outdated (and not actively maintained - no
> replies
> > >>>> on
> > >>>> > >> issues
> > >>>> > >
> > >>>> > >
> > >>>> > I will try. But I'd love to get those features in Max's probot
> > >>>> instead in
> > >>>> > this case (I know it was on his list).
> > >>>> >
> > >>>> >
> > >>>> > > - https://probot.github.io/apps/pr-triage/ : Might be good to
> > have
> > >>>> but
> > >>>> > >> this
> > >>>> > >> issue <https://github.com/pr-triage/app/issues/181> might bite
> > us
> > >>>> too.
> > >>>> > >> Not
> > >>>> > >> a major problem but just something to note.
> > >>>> > >>
> > >>>> > >
> > >>>> > Right. I think we might soon get down to a manageable number of
> > >>>> issues as
> > >>>> > the stalebot does it's job finally.
> > >>>> > So maybe we won't need that one.
> > >>>> >
> > >>>> >
> > >>>> > > - https://probot.github.io/apps/tests-checker/ : I liked this
> one
> > >>>> > >>
> > >>>> > >
> > >>>> > I like it too but I will try it :). I am afraid it might be a bit
> > >>>> offensive
> > >>>> > at times though.
> > >>>> >
> > >>>> >
> > >>>> > > - https://probot.github.io/apps/reminders/ : Again might be
> > >>>> outdated but
> > >>>> > >> would need some testing to see if it actually works.
> > >>>> > >
> > >>>> > >
> > >>>> > It's just a nuance - not high priority at all.
> > >>>> >
> > >>>> >
> > >>>> > > - https://github.com/z0al/dep : I liked this one too but it
> > >>>> currently
> > >>>> > only
> > >>>> > >> matches on "#PR_NUMBER". Open Issue <
> > >>>> > >> https://github.com/z0al/dep/issues/18> so
> > >>>> > >> would want to hear opinions from others.
> > >>>> > >
> > >>>> > >
> > >>>> > I really love that one. It very well reflects the pattern we have
> > for
> > >>>> some
> > >>>> > complex changes. which require multiple commits.
> > >>>> > And it's very good for it to depend on #PR number. It's super easy
> > >>>> when you
> > >>>> > type "Depends on #<START_TYPING_HERE>" -
> > >>>> > you can start typing JIRA_ID or part of description and it will
> > >>>> auto-show
> > >>>> > the list of matching PRs. We do not have multiple repos
> > >>>> > so the issue https://github.com/z0al/dep/issues/18 is not really
> > >>>> relevant
> > >>>> > in our case.
> > >>>> >
> > >>>> > And if we have it working we will not need to add this funny
> > "Depends
> > >>>> on
> > >>>> > [AIRFLOW-NNNN]". We will see immediately when PR is not mergeable
> > >>>> > because it depends on other PRs without these extra descriptions.
> > >>>> >
> > >>>> >
> > >>>> > >> @Max - I like your idea and maybe long term it might make more
> > >>>> sense.
> > >>>> > >> Happy
> > >>>> > >> to help in the effort so that we can make it more *general*.
> > >>>> > >>
> > >>>> > >
> > >>>> > Max - happy to contribute to the SuperSet probot as well. It would
> > be
> > >>>> great
> > >>>> > to do cross-project work on it :). Synergies.
> > >>>> >
> > >>>>
> > >>>>
> > >>>> --
> > >>>>
> > >>>> Tomasz Urbaszek
> > >>>> Polidea <https://www.polidea.com/> | Software Engineer
> > >>>>
> > >>>> M: +48 505 628 493 <+48505628493>
> > >>>> E: tomasz.urbaszek@polidea.com <to...@polidea.com>
> > >>>>
> > >>>> Unique Tech
> > >>>> Check out our projects! <https://www.polidea.com/our-work>
> > >>>>
> > >>>
> >
>
>
> --
>
> Jarek Potiuk
> Polidea <https://www.polidea.com/> | Principal Software Engineer
>
> M: +48 660 796 129 <+48660796129>
> [image: Polidea] <https://www.polidea.com/>
>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Jarek Potiuk <Ja...@polidea.com>.
Those both are cool. Love them :).
Why not use the periodic labeler workaround? It seems to do the trick and
uses the same configuration and does not seem to have any negative side
effects.
I think auto-labelling our PRs would be a great step (together with working
stale bot) towards making more organised process about triaging/handling
PRs.
J.
On Sat, Jan 4, 2020 at 3:28 AM Kaxil Naik <ka...@gmail.com> wrote:
> On digging further I found out that it is an open BUG on both the Github
> actions:
>
> Bug: https://github.com/actions/labeler/issues/12 or
> https://github.com/actions/first-interaction/issues/10
>
>
> *Details*:
>
> Quoting the Author:
> ----
> Workflows are run in the context "of the repository". But when any workflow
> is run because a pull request triggered it, then the token is downgraded to
> a read-only token.
> It's not "the fork's token", it's still the repository's token, it's just
> read-only.
> This is intentional. It's so that somebody can't open a pull request that
> gives them a token that they could use to write to your repository.
> ----
>
> They are working towards fixing this but I am removing the integrations
> meanwhile. There is a workaround -
> https://github.com/actions/labeler/issues/12#issuecomment-555746868 but I
> don't want to use it until it is resolved in the original repo.
>
>
> Regards,
> Kaxil
>
>
>
>
> On Sat, Jan 4, 2020 at 1:07 AM Kaxil Naik <ka...@gmail.com> wrote:
>
> > I think I was wrong. We still need permission from INFRA to enable the
> > GITHUB_TOKEN, I have raised an ISSUE with INFRA team:
> > https://issues.apache.org/jira/browse/INFRA-19657
> >
> > Apache Spark recently added a Github Action for Stable
> > <https://github.com/apache/spark/pull/26877>, hence I thought we won't
> > require any perms from INFRA team. Although it didn't threw them error as
> > the stale bot didn't actually need to take any action yet. Similarly the
> 2
> > Github actions seems to pass all time in Airflow repo except when they
> need
> > to actually add labels.
> >
> > Hopefully, the INFRA team will enable this soon as we just read
> permission
> > and write-on labels.
> >
> > Regards,
> > Kaxil
> >
> > On Fri, Jan 3, 2020 at 11:07 PM Kaxil Naik <ka...@gmail.com> wrote:
> >
> >> I tried some Github actions today and fell in love. We don't even need
> to
> >> ask for approval from INFRA team.
> >>
> >> I have raised 2 PRs:
> >>
> >> - https://github.com/apache/airflow/pull/7032 - Add Labels on PRs
> >> based on file/dir
> >> - https://github.com/apache/airflow/pull/7031 - Welcome First time
> >> contributors
> >>
> >> to integrate this in Airflow too. I have tested them on my other repo
> and
> >> works like a charm.
> >>
> >> Regards,
> >> Kaxil
> >>
> >> On Fri, Jan 3, 2020 at 2:38 PM Kaxil Naik <ka...@gmail.com> wrote:
> >>
> >>> Yeah the mention-bot was archived and is no longer maintained.
> >>>
> >>> On Fri, Jan 3, 2020 at 2:33 PM Tomasz Urbaszek <
> >>> tomasz.urbaszek@polidea.com> wrote:
> >>>
> >>>> Hi all,
> >>>>
> >>>> I just discovered that some time ago we already used "mention-bot"
> that
> >>>> suggests
> >>>> potential reviewers based on history of changed files:
> >>>> https://github.com/apache/airflow/pull/2558#issuecomment-326686092
> >>>>
> >>>> T.
> >>>>
> >>>>
> >>>> On Thu, Jan 2, 2020 at 2:33 AM Jarek Potiuk <Jarek.Potiuk@polidea.com
> >
> >>>> wrote:
> >>>>
> >>>> > On Wed, Jan 1, 2020 at 11:47 PM Jarek Potiuk <
> >>>> Jarek.Potiuk@polidea.com>
> >>>> > wrote:
> >>>> >
> >>>> > > One thing I realized after using the 4 Probot Integrations is that
> >>>> some
> >>>> > of
> >>>> > >> the Probot apps are not actively maintained and might even be
> >>>> broken.
> >>>> > >>
> >>>> > >
> >>>> > Yeah. Even if limited my search to only the "featured ones" seems
> >>>> like not
> >>>> > all of them are good.
> >>>> > Luckily it's easy to enable/disable them when needed.
> >>>> >
> >>>> > However I think maybe the right approach is "try before buy".
> >>>> > I will try some of them on our internal fork where we work and then
> >>>> once I
> >>>> > get
> >>>> > some hands-on we can decide if it makes sense to use them or not.
> >>>> It's a
> >>>> > bit of a hassle that
> >>>> > we have to open an issue to infra to get those added/removed so It's
> >>>> easier
> >>>> > to try them on our repo.
> >>>> > I already added the "pull" one to synchronize our fork (pretty
> useful
> >>>> but
> >>>> > spammy).
> >>>> >
> >>>> >
> >>>> > - https://probot.github.io/apps/welcome/ : This one has this
> >>>> > >> <https://github.com/behaviorbot/welcome/issues/12> particular
> >>>> issue
> >>>> > open
> >>>> > >> that might not make the experience pleasant for contributors.
> >>>> > >>
> >>>> > > OK. That's no go :).
> >>>> >
> >>>> >
> >>>> > > - https://github.com/mithro/autolabeler: Need to test if it is
> >>>> working
> >>>> > as
> >>>> > >> it looks a bit outdated (and not actively maintained - no replies
> >>>> on
> >>>> > >> issues
> >>>> > >
> >>>> > >
> >>>> > I will try. But I'd love to get those features in Max's probot
> >>>> instead in
> >>>> > this case (I know it was on his list).
> >>>> >
> >>>> >
> >>>> > > - https://probot.github.io/apps/pr-triage/ : Might be good to
> have
> >>>> but
> >>>> > >> this
> >>>> > >> issue <https://github.com/pr-triage/app/issues/181> might bite
> us
> >>>> too.
> >>>> > >> Not
> >>>> > >> a major problem but just something to note.
> >>>> > >>
> >>>> > >
> >>>> > Right. I think we might soon get down to a manageable number of
> >>>> issues as
> >>>> > the stalebot does it's job finally.
> >>>> > So maybe we won't need that one.
> >>>> >
> >>>> >
> >>>> > > - https://probot.github.io/apps/tests-checker/ : I liked this one
> >>>> > >>
> >>>> > >
> >>>> > I like it too but I will try it :). I am afraid it might be a bit
> >>>> offensive
> >>>> > at times though.
> >>>> >
> >>>> >
> >>>> > > - https://probot.github.io/apps/reminders/ : Again might be
> >>>> outdated but
> >>>> > >> would need some testing to see if it actually works.
> >>>> > >
> >>>> > >
> >>>> > It's just a nuance - not high priority at all.
> >>>> >
> >>>> >
> >>>> > > - https://github.com/z0al/dep : I liked this one too but it
> >>>> currently
> >>>> > only
> >>>> > >> matches on "#PR_NUMBER". Open Issue <
> >>>> > >> https://github.com/z0al/dep/issues/18> so
> >>>> > >> would want to hear opinions from others.
> >>>> > >
> >>>> > >
> >>>> > I really love that one. It very well reflects the pattern we have
> for
> >>>> some
> >>>> > complex changes. which require multiple commits.
> >>>> > And it's very good for it to depend on #PR number. It's super easy
> >>>> when you
> >>>> > type "Depends on #<START_TYPING_HERE>" -
> >>>> > you can start typing JIRA_ID or part of description and it will
> >>>> auto-show
> >>>> > the list of matching PRs. We do not have multiple repos
> >>>> > so the issue https://github.com/z0al/dep/issues/18 is not really
> >>>> relevant
> >>>> > in our case.
> >>>> >
> >>>> > And if we have it working we will not need to add this funny
> "Depends
> >>>> on
> >>>> > [AIRFLOW-NNNN]". We will see immediately when PR is not mergeable
> >>>> > because it depends on other PRs without these extra descriptions.
> >>>> >
> >>>> >
> >>>> > >> @Max - I like your idea and maybe long term it might make more
> >>>> sense.
> >>>> > >> Happy
> >>>> > >> to help in the effort so that we can make it more *general*.
> >>>> > >>
> >>>> > >
> >>>> > Max - happy to contribute to the SuperSet probot as well. It would
> be
> >>>> great
> >>>> > to do cross-project work on it :). Synergies.
> >>>> >
> >>>>
> >>>>
> >>>> --
> >>>>
> >>>> Tomasz Urbaszek
> >>>> Polidea <https://www.polidea.com/> | Software Engineer
> >>>>
> >>>> M: +48 505 628 493 <+48505628493>
> >>>> E: tomasz.urbaszek@polidea.com <to...@polidea.com>
> >>>>
> >>>> Unique Tech
> >>>> Check out our projects! <https://www.polidea.com/our-work>
> >>>>
> >>>
>
--
Jarek Potiuk
Polidea <https://www.polidea.com/> | Principal Software Engineer
M: +48 660 796 129 <+48660796129>
[image: Polidea] <https://www.polidea.com/>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Kaxil Naik <ka...@gmail.com>.
On digging further I found out that it is an open BUG on both the Github
actions:
Bug: https://github.com/actions/labeler/issues/12 or
https://github.com/actions/first-interaction/issues/10
*Details*:
Quoting the Author:
----
Workflows are run in the context "of the repository". But when any workflow
is run because a pull request triggered it, then the token is downgraded to
a read-only token.
It's not "the fork's token", it's still the repository's token, it's just
read-only.
This is intentional. It's so that somebody can't open a pull request that
gives them a token that they could use to write to your repository.
----
They are working towards fixing this but I am removing the integrations
meanwhile. There is a workaround -
https://github.com/actions/labeler/issues/12#issuecomment-555746868 but I
don't want to use it until it is resolved in the original repo.
Regards,
Kaxil
On Sat, Jan 4, 2020 at 1:07 AM Kaxil Naik <ka...@gmail.com> wrote:
> I think I was wrong. We still need permission from INFRA to enable the
> GITHUB_TOKEN, I have raised an ISSUE with INFRA team:
> https://issues.apache.org/jira/browse/INFRA-19657
>
> Apache Spark recently added a Github Action for Stable
> <https://github.com/apache/spark/pull/26877>, hence I thought we won't
> require any perms from INFRA team. Although it didn't threw them error as
> the stale bot didn't actually need to take any action yet. Similarly the 2
> Github actions seems to pass all time in Airflow repo except when they need
> to actually add labels.
>
> Hopefully, the INFRA team will enable this soon as we just read permission
> and write-on labels.
>
> Regards,
> Kaxil
>
> On Fri, Jan 3, 2020 at 11:07 PM Kaxil Naik <ka...@gmail.com> wrote:
>
>> I tried some Github actions today and fell in love. We don't even need to
>> ask for approval from INFRA team.
>>
>> I have raised 2 PRs:
>>
>> - https://github.com/apache/airflow/pull/7032 - Add Labels on PRs
>> based on file/dir
>> - https://github.com/apache/airflow/pull/7031 - Welcome First time
>> contributors
>>
>> to integrate this in Airflow too. I have tested them on my other repo and
>> works like a charm.
>>
>> Regards,
>> Kaxil
>>
>> On Fri, Jan 3, 2020 at 2:38 PM Kaxil Naik <ka...@gmail.com> wrote:
>>
>>> Yeah the mention-bot was archived and is no longer maintained.
>>>
>>> On Fri, Jan 3, 2020 at 2:33 PM Tomasz Urbaszek <
>>> tomasz.urbaszek@polidea.com> wrote:
>>>
>>>> Hi all,
>>>>
>>>> I just discovered that some time ago we already used "mention-bot" that
>>>> suggests
>>>> potential reviewers based on history of changed files:
>>>> https://github.com/apache/airflow/pull/2558#issuecomment-326686092
>>>>
>>>> T.
>>>>
>>>>
>>>> On Thu, Jan 2, 2020 at 2:33 AM Jarek Potiuk <Ja...@polidea.com>
>>>> wrote:
>>>>
>>>> > On Wed, Jan 1, 2020 at 11:47 PM Jarek Potiuk <
>>>> Jarek.Potiuk@polidea.com>
>>>> > wrote:
>>>> >
>>>> > > One thing I realized after using the 4 Probot Integrations is that
>>>> some
>>>> > of
>>>> > >> the Probot apps are not actively maintained and might even be
>>>> broken.
>>>> > >>
>>>> > >
>>>> > Yeah. Even if limited my search to only the "featured ones" seems
>>>> like not
>>>> > all of them are good.
>>>> > Luckily it's easy to enable/disable them when needed.
>>>> >
>>>> > However I think maybe the right approach is "try before buy".
>>>> > I will try some of them on our internal fork where we work and then
>>>> once I
>>>> > get
>>>> > some hands-on we can decide if it makes sense to use them or not.
>>>> It's a
>>>> > bit of a hassle that
>>>> > we have to open an issue to infra to get those added/removed so It's
>>>> easier
>>>> > to try them on our repo.
>>>> > I already added the "pull" one to synchronize our fork (pretty useful
>>>> but
>>>> > spammy).
>>>> >
>>>> >
>>>> > - https://probot.github.io/apps/welcome/ : This one has this
>>>> > >> <https://github.com/behaviorbot/welcome/issues/12> particular
>>>> issue
>>>> > open
>>>> > >> that might not make the experience pleasant for contributors.
>>>> > >>
>>>> > > OK. That's no go :).
>>>> >
>>>> >
>>>> > > - https://github.com/mithro/autolabeler: Need to test if it is
>>>> working
>>>> > as
>>>> > >> it looks a bit outdated (and not actively maintained - no replies
>>>> on
>>>> > >> issues
>>>> > >
>>>> > >
>>>> > I will try. But I'd love to get those features in Max's probot
>>>> instead in
>>>> > this case (I know it was on his list).
>>>> >
>>>> >
>>>> > > - https://probot.github.io/apps/pr-triage/ : Might be good to have
>>>> but
>>>> > >> this
>>>> > >> issue <https://github.com/pr-triage/app/issues/181> might bite us
>>>> too.
>>>> > >> Not
>>>> > >> a major problem but just something to note.
>>>> > >>
>>>> > >
>>>> > Right. I think we might soon get down to a manageable number of
>>>> issues as
>>>> > the stalebot does it's job finally.
>>>> > So maybe we won't need that one.
>>>> >
>>>> >
>>>> > > - https://probot.github.io/apps/tests-checker/ : I liked this one
>>>> > >>
>>>> > >
>>>> > I like it too but I will try it :). I am afraid it might be a bit
>>>> offensive
>>>> > at times though.
>>>> >
>>>> >
>>>> > > - https://probot.github.io/apps/reminders/ : Again might be
>>>> outdated but
>>>> > >> would need some testing to see if it actually works.
>>>> > >
>>>> > >
>>>> > It's just a nuance - not high priority at all.
>>>> >
>>>> >
>>>> > > - https://github.com/z0al/dep : I liked this one too but it
>>>> currently
>>>> > only
>>>> > >> matches on "#PR_NUMBER". Open Issue <
>>>> > >> https://github.com/z0al/dep/issues/18> so
>>>> > >> would want to hear opinions from others.
>>>> > >
>>>> > >
>>>> > I really love that one. It very well reflects the pattern we have for
>>>> some
>>>> > complex changes. which require multiple commits.
>>>> > And it's very good for it to depend on #PR number. It's super easy
>>>> when you
>>>> > type "Depends on #<START_TYPING_HERE>" -
>>>> > you can start typing JIRA_ID or part of description and it will
>>>> auto-show
>>>> > the list of matching PRs. We do not have multiple repos
>>>> > so the issue https://github.com/z0al/dep/issues/18 is not really
>>>> relevant
>>>> > in our case.
>>>> >
>>>> > And if we have it working we will not need to add this funny "Depends
>>>> on
>>>> > [AIRFLOW-NNNN]". We will see immediately when PR is not mergeable
>>>> > because it depends on other PRs without these extra descriptions.
>>>> >
>>>> >
>>>> > >> @Max - I like your idea and maybe long term it might make more
>>>> sense.
>>>> > >> Happy
>>>> > >> to help in the effort so that we can make it more *general*.
>>>> > >>
>>>> > >
>>>> > Max - happy to contribute to the SuperSet probot as well. It would be
>>>> great
>>>> > to do cross-project work on it :). Synergies.
>>>> >
>>>>
>>>>
>>>> --
>>>>
>>>> Tomasz Urbaszek
>>>> Polidea <https://www.polidea.com/> | Software Engineer
>>>>
>>>> M: +48 505 628 493 <+48505628493>
>>>> E: tomasz.urbaszek@polidea.com <to...@polidea.com>
>>>>
>>>> Unique Tech
>>>> Check out our projects! <https://www.polidea.com/our-work>
>>>>
>>>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Kaxil Naik <ka...@gmail.com>.
I think I was wrong. We still need permission from INFRA to enable the
GITHUB_TOKEN, I have raised an ISSUE with INFRA team:
https://issues.apache.org/jira/browse/INFRA-19657
Apache Spark recently added a Github Action for Stable
<https://github.com/apache/spark/pull/26877>, hence I thought we won't
require any perms from INFRA team. Although it didn't threw them error as
the stale bot didn't actually need to take any action yet. Similarly the 2
Github actions seems to pass all time in Airflow repo except when they need
to actually add labels.
Hopefully, the INFRA team will enable this soon as we just read permission
and write-on labels.
Regards,
Kaxil
On Fri, Jan 3, 2020 at 11:07 PM Kaxil Naik <ka...@gmail.com> wrote:
> I tried some Github actions today and fell in love. We don't even need to
> ask for approval from INFRA team.
>
> I have raised 2 PRs:
>
> - https://github.com/apache/airflow/pull/7032 - Add Labels on PRs
> based on file/dir
> - https://github.com/apache/airflow/pull/7031 - Welcome First time
> contributors
>
> to integrate this in Airflow too. I have tested them on my other repo and
> works like a charm.
>
> Regards,
> Kaxil
>
> On Fri, Jan 3, 2020 at 2:38 PM Kaxil Naik <ka...@gmail.com> wrote:
>
>> Yeah the mention-bot was archived and is no longer maintained.
>>
>> On Fri, Jan 3, 2020 at 2:33 PM Tomasz Urbaszek <
>> tomasz.urbaszek@polidea.com> wrote:
>>
>>> Hi all,
>>>
>>> I just discovered that some time ago we already used "mention-bot" that
>>> suggests
>>> potential reviewers based on history of changed files:
>>> https://github.com/apache/airflow/pull/2558#issuecomment-326686092
>>>
>>> T.
>>>
>>>
>>> On Thu, Jan 2, 2020 at 2:33 AM Jarek Potiuk <Ja...@polidea.com>
>>> wrote:
>>>
>>> > On Wed, Jan 1, 2020 at 11:47 PM Jarek Potiuk <Jarek.Potiuk@polidea.com
>>> >
>>> > wrote:
>>> >
>>> > > One thing I realized after using the 4 Probot Integrations is that
>>> some
>>> > of
>>> > >> the Probot apps are not actively maintained and might even be
>>> broken.
>>> > >>
>>> > >
>>> > Yeah. Even if limited my search to only the "featured ones" seems like
>>> not
>>> > all of them are good.
>>> > Luckily it's easy to enable/disable them when needed.
>>> >
>>> > However I think maybe the right approach is "try before buy".
>>> > I will try some of them on our internal fork where we work and then
>>> once I
>>> > get
>>> > some hands-on we can decide if it makes sense to use them or not. It's
>>> a
>>> > bit of a hassle that
>>> > we have to open an issue to infra to get those added/removed so It's
>>> easier
>>> > to try them on our repo.
>>> > I already added the "pull" one to synchronize our fork (pretty useful
>>> but
>>> > spammy).
>>> >
>>> >
>>> > - https://probot.github.io/apps/welcome/ : This one has this
>>> > >> <https://github.com/behaviorbot/welcome/issues/12> particular issue
>>> > open
>>> > >> that might not make the experience pleasant for contributors.
>>> > >>
>>> > > OK. That's no go :).
>>> >
>>> >
>>> > > - https://github.com/mithro/autolabeler: Need to test if it is
>>> working
>>> > as
>>> > >> it looks a bit outdated (and not actively maintained - no replies on
>>> > >> issues
>>> > >
>>> > >
>>> > I will try. But I'd love to get those features in Max's probot instead
>>> in
>>> > this case (I know it was on his list).
>>> >
>>> >
>>> > > - https://probot.github.io/apps/pr-triage/ : Might be good to have
>>> but
>>> > >> this
>>> > >> issue <https://github.com/pr-triage/app/issues/181> might bite us
>>> too.
>>> > >> Not
>>> > >> a major problem but just something to note.
>>> > >>
>>> > >
>>> > Right. I think we might soon get down to a manageable number of issues
>>> as
>>> > the stalebot does it's job finally.
>>> > So maybe we won't need that one.
>>> >
>>> >
>>> > > - https://probot.github.io/apps/tests-checker/ : I liked this one
>>> > >>
>>> > >
>>> > I like it too but I will try it :). I am afraid it might be a bit
>>> offensive
>>> > at times though.
>>> >
>>> >
>>> > > - https://probot.github.io/apps/reminders/ : Again might be
>>> outdated but
>>> > >> would need some testing to see if it actually works.
>>> > >
>>> > >
>>> > It's just a nuance - not high priority at all.
>>> >
>>> >
>>> > > - https://github.com/z0al/dep : I liked this one too but it
>>> currently
>>> > only
>>> > >> matches on "#PR_NUMBER". Open Issue <
>>> > >> https://github.com/z0al/dep/issues/18> so
>>> > >> would want to hear opinions from others.
>>> > >
>>> > >
>>> > I really love that one. It very well reflects the pattern we have for
>>> some
>>> > complex changes. which require multiple commits.
>>> > And it's very good for it to depend on #PR number. It's super easy
>>> when you
>>> > type "Depends on #<START_TYPING_HERE>" -
>>> > you can start typing JIRA_ID or part of description and it will
>>> auto-show
>>> > the list of matching PRs. We do not have multiple repos
>>> > so the issue https://github.com/z0al/dep/issues/18 is not really
>>> relevant
>>> > in our case.
>>> >
>>> > And if we have it working we will not need to add this funny "Depends
>>> on
>>> > [AIRFLOW-NNNN]". We will see immediately when PR is not mergeable
>>> > because it depends on other PRs without these extra descriptions.
>>> >
>>> >
>>> > >> @Max - I like your idea and maybe long term it might make more
>>> sense.
>>> > >> Happy
>>> > >> to help in the effort so that we can make it more *general*.
>>> > >>
>>> > >
>>> > Max - happy to contribute to the SuperSet probot as well. It would be
>>> great
>>> > to do cross-project work on it :). Synergies.
>>> >
>>>
>>>
>>> --
>>>
>>> Tomasz Urbaszek
>>> Polidea <https://www.polidea.com/> | Software Engineer
>>>
>>> M: +48 505 628 493 <+48505628493>
>>> E: tomasz.urbaszek@polidea.com <to...@polidea.com>
>>>
>>> Unique Tech
>>> Check out our projects! <https://www.polidea.com/our-work>
>>>
>>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Kaxil Naik <ka...@gmail.com>.
I tried some Github actions today and fell in love. We don't even need to
ask for approval from INFRA team.
I have raised 2 PRs:
- https://github.com/apache/airflow/pull/7032 - Add Labels on PRs based
on file/dir
- https://github.com/apache/airflow/pull/7031 - Welcome First time
contributors
to integrate this in Airflow too. I have tested them on my other repo and
works like a charm.
Regards,
Kaxil
On Fri, Jan 3, 2020 at 2:38 PM Kaxil Naik <ka...@gmail.com> wrote:
> Yeah the mention-bot was archived and is no longer maintained.
>
> On Fri, Jan 3, 2020 at 2:33 PM Tomasz Urbaszek <
> tomasz.urbaszek@polidea.com> wrote:
>
>> Hi all,
>>
>> I just discovered that some time ago we already used "mention-bot" that
>> suggests
>> potential reviewers based on history of changed files:
>> https://github.com/apache/airflow/pull/2558#issuecomment-326686092
>>
>> T.
>>
>>
>> On Thu, Jan 2, 2020 at 2:33 AM Jarek Potiuk <Ja...@polidea.com>
>> wrote:
>>
>> > On Wed, Jan 1, 2020 at 11:47 PM Jarek Potiuk <Ja...@polidea.com>
>> > wrote:
>> >
>> > > One thing I realized after using the 4 Probot Integrations is that
>> some
>> > of
>> > >> the Probot apps are not actively maintained and might even be broken.
>> > >>
>> > >
>> > Yeah. Even if limited my search to only the "featured ones" seems like
>> not
>> > all of them are good.
>> > Luckily it's easy to enable/disable them when needed.
>> >
>> > However I think maybe the right approach is "try before buy".
>> > I will try some of them on our internal fork where we work and then
>> once I
>> > get
>> > some hands-on we can decide if it makes sense to use them or not. It's a
>> > bit of a hassle that
>> > we have to open an issue to infra to get those added/removed so It's
>> easier
>> > to try them on our repo.
>> > I already added the "pull" one to synchronize our fork (pretty useful
>> but
>> > spammy).
>> >
>> >
>> > - https://probot.github.io/apps/welcome/ : This one has this
>> > >> <https://github.com/behaviorbot/welcome/issues/12> particular issue
>> > open
>> > >> that might not make the experience pleasant for contributors.
>> > >>
>> > > OK. That's no go :).
>> >
>> >
>> > > - https://github.com/mithro/autolabeler: Need to test if it is
>> working
>> > as
>> > >> it looks a bit outdated (and not actively maintained - no replies on
>> > >> issues
>> > >
>> > >
>> > I will try. But I'd love to get those features in Max's probot instead
>> in
>> > this case (I know it was on his list).
>> >
>> >
>> > > - https://probot.github.io/apps/pr-triage/ : Might be good to have
>> but
>> > >> this
>> > >> issue <https://github.com/pr-triage/app/issues/181> might bite us
>> too.
>> > >> Not
>> > >> a major problem but just something to note.
>> > >>
>> > >
>> > Right. I think we might soon get down to a manageable number of issues
>> as
>> > the stalebot does it's job finally.
>> > So maybe we won't need that one.
>> >
>> >
>> > > - https://probot.github.io/apps/tests-checker/ : I liked this one
>> > >>
>> > >
>> > I like it too but I will try it :). I am afraid it might be a bit
>> offensive
>> > at times though.
>> >
>> >
>> > > - https://probot.github.io/apps/reminders/ : Again might be outdated
>> but
>> > >> would need some testing to see if it actually works.
>> > >
>> > >
>> > It's just a nuance - not high priority at all.
>> >
>> >
>> > > - https://github.com/z0al/dep : I liked this one too but it currently
>> > only
>> > >> matches on "#PR_NUMBER". Open Issue <
>> > >> https://github.com/z0al/dep/issues/18> so
>> > >> would want to hear opinions from others.
>> > >
>> > >
>> > I really love that one. It very well reflects the pattern we have for
>> some
>> > complex changes. which require multiple commits.
>> > And it's very good for it to depend on #PR number. It's super easy when
>> you
>> > type "Depends on #<START_TYPING_HERE>" -
>> > you can start typing JIRA_ID or part of description and it will
>> auto-show
>> > the list of matching PRs. We do not have multiple repos
>> > so the issue https://github.com/z0al/dep/issues/18 is not really
>> relevant
>> > in our case.
>> >
>> > And if we have it working we will not need to add this funny "Depends on
>> > [AIRFLOW-NNNN]". We will see immediately when PR is not mergeable
>> > because it depends on other PRs without these extra descriptions.
>> >
>> >
>> > >> @Max - I like your idea and maybe long term it might make more sense.
>> > >> Happy
>> > >> to help in the effort so that we can make it more *general*.
>> > >>
>> > >
>> > Max - happy to contribute to the SuperSet probot as well. It would be
>> great
>> > to do cross-project work on it :). Synergies.
>> >
>>
>>
>> --
>>
>> Tomasz Urbaszek
>> Polidea <https://www.polidea.com/> | Software Engineer
>>
>> M: +48 505 628 493 <+48505628493>
>> E: tomasz.urbaszek@polidea.com <to...@polidea.com>
>>
>> Unique Tech
>> Check out our projects! <https://www.polidea.com/our-work>
>>
>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Kaxil Naik <ka...@gmail.com>.
Yeah the mention-bot was archived and is no longer maintained.
On Fri, Jan 3, 2020 at 2:33 PM Tomasz Urbaszek <to...@polidea.com>
wrote:
> Hi all,
>
> I just discovered that some time ago we already used "mention-bot" that
> suggests
> potential reviewers based on history of changed files:
> https://github.com/apache/airflow/pull/2558#issuecomment-326686092
>
> T.
>
>
> On Thu, Jan 2, 2020 at 2:33 AM Jarek Potiuk <Ja...@polidea.com>
> wrote:
>
> > On Wed, Jan 1, 2020 at 11:47 PM Jarek Potiuk <Ja...@polidea.com>
> > wrote:
> >
> > > One thing I realized after using the 4 Probot Integrations is that some
> > of
> > >> the Probot apps are not actively maintained and might even be broken.
> > >>
> > >
> > Yeah. Even if limited my search to only the "featured ones" seems like
> not
> > all of them are good.
> > Luckily it's easy to enable/disable them when needed.
> >
> > However I think maybe the right approach is "try before buy".
> > I will try some of them on our internal fork where we work and then once
> I
> > get
> > some hands-on we can decide if it makes sense to use them or not. It's a
> > bit of a hassle that
> > we have to open an issue to infra to get those added/removed so It's
> easier
> > to try them on our repo.
> > I already added the "pull" one to synchronize our fork (pretty useful but
> > spammy).
> >
> >
> > - https://probot.github.io/apps/welcome/ : This one has this
> > >> <https://github.com/behaviorbot/welcome/issues/12> particular issue
> > open
> > >> that might not make the experience pleasant for contributors.
> > >>
> > > OK. That's no go :).
> >
> >
> > > - https://github.com/mithro/autolabeler: Need to test if it is working
> > as
> > >> it looks a bit outdated (and not actively maintained - no replies on
> > >> issues
> > >
> > >
> > I will try. But I'd love to get those features in Max's probot instead in
> > this case (I know it was on his list).
> >
> >
> > > - https://probot.github.io/apps/pr-triage/ : Might be good to have but
> > >> this
> > >> issue <https://github.com/pr-triage/app/issues/181> might bite us
> too.
> > >> Not
> > >> a major problem but just something to note.
> > >>
> > >
> > Right. I think we might soon get down to a manageable number of issues as
> > the stalebot does it's job finally.
> > So maybe we won't need that one.
> >
> >
> > > - https://probot.github.io/apps/tests-checker/ : I liked this one
> > >>
> > >
> > I like it too but I will try it :). I am afraid it might be a bit
> offensive
> > at times though.
> >
> >
> > > - https://probot.github.io/apps/reminders/ : Again might be outdated
> but
> > >> would need some testing to see if it actually works.
> > >
> > >
> > It's just a nuance - not high priority at all.
> >
> >
> > > - https://github.com/z0al/dep : I liked this one too but it currently
> > only
> > >> matches on "#PR_NUMBER". Open Issue <
> > >> https://github.com/z0al/dep/issues/18> so
> > >> would want to hear opinions from others.
> > >
> > >
> > I really love that one. It very well reflects the pattern we have for
> some
> > complex changes. which require multiple commits.
> > And it's very good for it to depend on #PR number. It's super easy when
> you
> > type "Depends on #<START_TYPING_HERE>" -
> > you can start typing JIRA_ID or part of description and it will auto-show
> > the list of matching PRs. We do not have multiple repos
> > so the issue https://github.com/z0al/dep/issues/18 is not really
> relevant
> > in our case.
> >
> > And if we have it working we will not need to add this funny "Depends on
> > [AIRFLOW-NNNN]". We will see immediately when PR is not mergeable
> > because it depends on other PRs without these extra descriptions.
> >
> >
> > >> @Max - I like your idea and maybe long term it might make more sense.
> > >> Happy
> > >> to help in the effort so that we can make it more *general*.
> > >>
> > >
> > Max - happy to contribute to the SuperSet probot as well. It would be
> great
> > to do cross-project work on it :). Synergies.
> >
>
>
> --
>
> Tomasz Urbaszek
> Polidea <https://www.polidea.com/> | Software Engineer
>
> M: +48 505 628 493 <+48505628493>
> E: tomasz.urbaszek@polidea.com <to...@polidea.com>
>
> Unique Tech
> Check out our projects! <https://www.polidea.com/our-work>
>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Tomasz Urbaszek <to...@polidea.com>.
Hi all,
I just discovered that some time ago we already used "mention-bot" that
suggests
potential reviewers based on history of changed files:
https://github.com/apache/airflow/pull/2558#issuecomment-326686092
T.
On Thu, Jan 2, 2020 at 2:33 AM Jarek Potiuk <Ja...@polidea.com>
wrote:
> On Wed, Jan 1, 2020 at 11:47 PM Jarek Potiuk <Ja...@polidea.com>
> wrote:
>
> > One thing I realized after using the 4 Probot Integrations is that some
> of
> >> the Probot apps are not actively maintained and might even be broken.
> >>
> >
> Yeah. Even if limited my search to only the "featured ones" seems like not
> all of them are good.
> Luckily it's easy to enable/disable them when needed.
>
> However I think maybe the right approach is "try before buy".
> I will try some of them on our internal fork where we work and then once I
> get
> some hands-on we can decide if it makes sense to use them or not. It's a
> bit of a hassle that
> we have to open an issue to infra to get those added/removed so It's easier
> to try them on our repo.
> I already added the "pull" one to synchronize our fork (pretty useful but
> spammy).
>
>
> - https://probot.github.io/apps/welcome/ : This one has this
> >> <https://github.com/behaviorbot/welcome/issues/12> particular issue
> open
> >> that might not make the experience pleasant for contributors.
> >>
> > OK. That's no go :).
>
>
> > - https://github.com/mithro/autolabeler: Need to test if it is working
> as
> >> it looks a bit outdated (and not actively maintained - no replies on
> >> issues
> >
> >
> I will try. But I'd love to get those features in Max's probot instead in
> this case (I know it was on his list).
>
>
> > - https://probot.github.io/apps/pr-triage/ : Might be good to have but
> >> this
> >> issue <https://github.com/pr-triage/app/issues/181> might bite us too.
> >> Not
> >> a major problem but just something to note.
> >>
> >
> Right. I think we might soon get down to a manageable number of issues as
> the stalebot does it's job finally.
> So maybe we won't need that one.
>
>
> > - https://probot.github.io/apps/tests-checker/ : I liked this one
> >>
> >
> I like it too but I will try it :). I am afraid it might be a bit offensive
> at times though.
>
>
> > - https://probot.github.io/apps/reminders/ : Again might be outdated but
> >> would need some testing to see if it actually works.
> >
> >
> It's just a nuance - not high priority at all.
>
>
> > - https://github.com/z0al/dep : I liked this one too but it currently
> only
> >> matches on "#PR_NUMBER". Open Issue <
> >> https://github.com/z0al/dep/issues/18> so
> >> would want to hear opinions from others.
> >
> >
> I really love that one. It very well reflects the pattern we have for some
> complex changes. which require multiple commits.
> And it's very good for it to depend on #PR number. It's super easy when you
> type "Depends on #<START_TYPING_HERE>" -
> you can start typing JIRA_ID or part of description and it will auto-show
> the list of matching PRs. We do not have multiple repos
> so the issue https://github.com/z0al/dep/issues/18 is not really relevant
> in our case.
>
> And if we have it working we will not need to add this funny "Depends on
> [AIRFLOW-NNNN]". We will see immediately when PR is not mergeable
> because it depends on other PRs without these extra descriptions.
>
>
> >> @Max - I like your idea and maybe long term it might make more sense.
> >> Happy
> >> to help in the effort so that we can make it more *general*.
> >>
> >
> Max - happy to contribute to the SuperSet probot as well. It would be great
> to do cross-project work on it :). Synergies.
>
--
Tomasz Urbaszek
Polidea <https://www.polidea.com/> | Software Engineer
M: +48 505 628 493 <+48505628493>
E: tomasz.urbaszek@polidea.com <to...@polidea.com>
Unique Tech
Check out our projects! <https://www.polidea.com/our-work>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Jarek Potiuk <Ja...@polidea.com>.
On Wed, Jan 1, 2020 at 11:47 PM Jarek Potiuk <Ja...@polidea.com>
wrote:
> One thing I realized after using the 4 Probot Integrations is that some of
>> the Probot apps are not actively maintained and might even be broken.
>>
>
Yeah. Even if limited my search to only the "featured ones" seems like not
all of them are good.
Luckily it's easy to enable/disable them when needed.
However I think maybe the right approach is "try before buy".
I will try some of them on our internal fork where we work and then once I
get
some hands-on we can decide if it makes sense to use them or not. It's a
bit of a hassle that
we have to open an issue to infra to get those added/removed so It's easier
to try them on our repo.
I already added the "pull" one to synchronize our fork (pretty useful but
spammy).
- https://probot.github.io/apps/welcome/ : This one has this
>> <https://github.com/behaviorbot/welcome/issues/12> particular issue open
>> that might not make the experience pleasant for contributors.
>>
> OK. That's no go :).
> - https://github.com/mithro/autolabeler: Need to test if it is working as
>> it looks a bit outdated (and not actively maintained - no replies on
>> issues
>
>
I will try. But I'd love to get those features in Max's probot instead in
this case (I know it was on his list).
> - https://probot.github.io/apps/pr-triage/ : Might be good to have but
>> this
>> issue <https://github.com/pr-triage/app/issues/181> might bite us too.
>> Not
>> a major problem but just something to note.
>>
>
Right. I think we might soon get down to a manageable number of issues as
the stalebot does it's job finally.
So maybe we won't need that one.
> - https://probot.github.io/apps/tests-checker/ : I liked this one
>>
>
I like it too but I will try it :). I am afraid it might be a bit offensive
at times though.
> - https://probot.github.io/apps/reminders/ : Again might be outdated but
>> would need some testing to see if it actually works.
>
>
It's just a nuance - not high priority at all.
> - https://github.com/z0al/dep : I liked this one too but it currently only
>> matches on "#PR_NUMBER". Open Issue <
>> https://github.com/z0al/dep/issues/18> so
>> would want to hear opinions from others.
>
>
I really love that one. It very well reflects the pattern we have for some
complex changes. which require multiple commits.
And it's very good for it to depend on #PR number. It's super easy when you
type "Depends on #<START_TYPING_HERE>" -
you can start typing JIRA_ID or part of description and it will auto-show
the list of matching PRs. We do not have multiple repos
so the issue https://github.com/z0al/dep/issues/18 is not really relevant
in our case.
And if we have it working we will not need to add this funny "Depends on
[AIRFLOW-NNNN]". We will see immediately when PR is not mergeable
because it depends on other PRs without these extra descriptions.
>> @Max - I like your idea and maybe long term it might make more sense.
>> Happy
>> to help in the effort so that we can make it more *general*.
>>
>
Max - happy to contribute to the SuperSet probot as well. It would be great
to do cross-project work on it :). Synergies.
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Jarek Potiuk <Ja...@polidea.com>.
Oh yeah. I forgot about the probot from Max -> Happy to contribute to it to
add some of the functionality we might need :).
On Wed, Jan 1, 2020 at 11:42 PM Kaxil Naik <ka...@gmail.com> wrote:
> I loved *mergeable*.
> One thing I realized after using the 4 Probot Integrations is that some of
> the Probot apps are not actively maintained and might even be broken.
> For example, *ci-reporter *didn't work for us and there are other users
> facing
> similar issues <https://github.com/JasonEtco/ci-reporter/issues/40>.
>
> I looked into other Probot apps including the one's suggested by Jarek and
> the one Max created.
>
> - https://probot.github.io/apps/welcome/ : This one has this
> <https://github.com/behaviorbot/welcome/issues/12> particular issue open
> that might not make the experience pleasant for contributors.
> - https://github.com/mithro/autolabeler: Need to test if it is working as
> it looks a bit outdated (and not actively maintained - no replies on issues
> <https://github.com/mithro/autolabeler/issues>), however it might still
> work.
> - https://probot.github.io/apps/pr-triage/ : Might be good to have but
> this
> issue <https://github.com/pr-triage/app/issues/181> might bite us too. Not
> a major problem but just something to note.
> - https://probot.github.io/apps/tests-checker/ : I liked this one
> - https://probot.github.io/apps/reminders/ : Again might be outdated but
> would need some testing to see if it actually works.
> - https://github.com/z0al/dep : I liked this one too but it currently only
> matches on "#PR_NUMBER". Open Issue <https://github.com/z0al/dep/issues/18>
> so
> would want to hear opinions from others.
>
>
> @Max - I like your idea and maybe long term it might make more sense. Happy
> to help in the effort so that we can make it more *general*.
> But there are many advantages to building something that would also help us
> avoid asking extra permissions from INFRA as well as make some general
> features.
>
> I have also seen people shifting towards Github actions to do some of the
> automation related to labels, comments, etc.
> Does anyone have some opinion or experience with it vs Probot apps?
>
> Regards,
> Kaxil
>
> On Tue, Dec 31, 2019 at 1:23 PM Jarek Potiuk <Ja...@polidea.com>
> wrote:
>
> > Yeah. we can remove commitlint from that list. I think Mergable is much
> > better than commitlint looking at your recent configuration :)
> >
> > On Tue, Dec 31, 2019 at 2:14 PM Kaxil Naik <ka...@gmail.com> wrote:
> >
> > > Once we have got all the configs for the current integrations, I will
> > > review the ones you have provided in the link above and see if it is
> > > achievable with the current ones or not.
> > >
> > >
> > >
> > > On Tue, Dec 31, 2019 at 1:06 PM Jarek Potiuk <Jarek.Potiuk@polidea.com
> >
> > > wrote:
> > >
> > > > How about adding a few more apps ? I reviewed some probot apps and
> > maybe
> > > we
> > > > should consider those:
> > > >
> > > > - https://probot.github.io/apps/welcome/ - Welcomes new users
> > > > submitting
> > > > their PRs for the first time
> > > > - https://probot.github.io/apps/reminders/ - Allows to set
> > reminders
> > > > for
> > > > certain issues by making a "/remind" comment
> > > > - https://probot.github.io/apps/pr-triage/ - Assigns labels ("PR:
> > > > unreviewed", "PR: reviewed-changes-requested", "PR:
> > review-approved")
> > > > - https://probot.github.io/apps/tests-checker/ - Reminds to
> > > add/modify
> > > > tests in "tests" dir when you submit code changes
> > > > - https://github.com/mithro/autolabeler - Assigns labels
> > > automatically
> > > > based on paths matchers (for example providers/amazon/aws/* ->
> "aws"
> > > > label)
> > > > - https://probot.github.io/apps/commitlint/ - Verifies if commit
> > > > message
> > > > is well formatted (including AIRFLOW-XXXX prefix]
> > > >
> > > > I am happy to open an issue and add configuration for those.
> > > >
> > > > Maybe later (After some discussion):
> > > >
> > > > - https://probot.github.io/apps/semantic-pull-requests/ -> that
> > > > would require to introduce much more discipline in commit messages
> > so
> > > I
> > > > am
> > > > not sure it's a good idea now
> > > >
> > > >
> > > > On Tue, Dec 31, 2019 at 1:29 PM Kaxil Naik <ka...@gmail.com>
> > wrote:
> > > >
> > > > > Yup. I am adding some configs. PRs coming in.
> > > > >
> > > > > On Tue, Dec 31, 2019 at 12:24 PM Jarek Potiuk <
> > > Jarek.Potiuk@polidea.com>
> > > > > wrote:
> > > > >
> > > > > > Seems like we have a new friendly bot :)
> > > > > >
> > > > > > On Mon, Dec 30, 2019 at 8:41 AM Jarek Potiuk <
> > > Jarek.Potiuk@polidea.com
> > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > I opened a few tickets for INFRA and I am also waiting for
> > answer.
> > > I
> > > > > > guess
> > > > > > > Xmas period got in the way.
> > > > > > >
> > > > > > > J.
> > > > > > >
> > > > > > > On Mon, Dec 30, 2019 at 5:15 AM Kevin Yang <yr...@gmail.com>
> > > > wrote:
> > > > > > >
> > > > > > >> +1!
> > > > > > >>
> > > > > > >> Kaxil Naik <ka...@gmail.com>于2019年12月29日 周日下午6:21写道：
> > > > > > >>
> > > > > > >> > Thanks Max,
> > > > > > >> >
> > > > > > >> > I will raise a JIRA with the INFRA to add that too.
> > > > > > >> >
> > > > > > >> > Btw I had raised a request for the 4 integrations
> > > > > > >> > https://issues.apache.org/jira/browse/INFRA-19607 but looks
> > > like
> > > > it
> > > > > > >> hasn't
> > > > > > >> > gained any traction from them yet.
> > > > > > >> >
> > > > > > >> >
> > > > > > >> >
> > > > > > >> > On Fri, Dec 20, 2019 at 8:29 PM Maxime Beauchemin <
> > > > > > >> > maximebeauchemin@gmail.com> wrote:
> > > > > > >> >
> > > > > > >> > > +1!
> > > > > > >> > >
> > > > > > >> > > I forgot whether I shared this before, but I wrote a
> probot
> > > for
> > > > > > Apache
> > > > > > >> > > Superset that does a few nice things, and we can grow over
> > > time
> > > > to
> > > > > > do
> > > > > > >> > more
> > > > > > >> > > things without having to beg Apache Infra for anything
> > > > (currently
> > > > > > only
> > > > > > >> > them
> > > > > > >> > > have admin rights and can register apps on our repos)
> > > > > > >> > > https://github.com/apache-superset/superset-github-bot
> > > > > > >> > >
> > > > > > >> > > This bot, for now [as documented on the README]:
> > > > > > >> > > - enables non-committer to label/unlabel PRs and Issues
> > using
> > > > > > comments
> > > > > > >> > > (allowing PMs and other non-committer to label things)
> > > > > > >> > > - auto-labels all PRs and issues with a [whitelisted]
> > > > organization
> > > > > > >> (adds
> > > > > > >> > an
> > > > > > >> > > "airbnb" or "lyft" label to the PR)
> > > > > > >> > > - enables forwarding events to other webhooks
> > > > > > >> > >
> > > > > > >> > > Eventually I'd like for it to also auto-label based on
> > > > > files/folder
> > > > > > >> that
> > > > > > >> > > are touched in a PR: for instance "db-migration" or
> > > "scheduler"
> > > > or
> > > > > > >> > > "webserver" would be nice.
> > > > > > >> > >
> > > > > > >> > > We could rename the bot to be an "Apache Github Bot" and
> > keep
> > > it
> > > > > > >> > > generalized (it reads a yaml config file from the
> project's
> > > > repo,
> > > > > so
> > > > > > >> each
> > > > > > >> > > feature of the bot can be configured on a per-project
> > basis).
> > > We
> > > > > > could
> > > > > > >> > > build a collection of things that other Apache projects
> are
> > > > likely
> > > > > > to
> > > > > > >> > want.
> > > > > > >> > > We may even be able to automate some Apache email-driven
> > > > processes
> > > > > > >> using
> > > > > > >> > > Github issues instead, for instance a committer vote
> process
> > > or
> > > > > > >> release
> > > > > > >> > > process vote could be automated by the bot: it would send
> > > > emails,
> > > > > > ask
> > > > > > >> > > people to use reactions (thumbs up/down) and close the
> vote
> > /
> > > > send
> > > > > > the
> > > > > > >> > > RESULTS email templates to the list. It could also look
> for
> > > ASF
> > > > > > >> headers
> > > > > > >> > in
> > > > > > >> > > files (replacing the Apache-RAT).
> > > > > > >> > >
> > > > > > >> > > It could make for a great ApacheCon talk eventually as we
> > add
> > > > > > >> > > functionality.
> > > > > > >> > >
> > > > > > >> > > This is a pet project of mine for now, but I'd love to
> make
> > > room
> > > > > for
> > > > > > >> > people
> > > > > > >> > > to jump in and contribute to it.
> > > > > > >> > >
> > > > > > >> > > Max
> > > > > > >> > >
> > > > > > >> > > On Fri, Dec 20, 2019 at 10:04 AM Huang Xinbin <
> > > > > > bin.huangxb@gmail.com>
> > > > > > >> > > wrote:
> > > > > > >> > >
> > > > > > >> > > > +1 +1 (if I can vote XD)
> > > > > > >> > > >
> > > > > > >> > > > Best
> > > > > > >> > > > Bin
> > > > > > >> > > >
> > > > > > >> > > > On 2019/12/20 13:43:11, Felix Uellendall
> > > > <feluelle@pm.me.INVALID
> > > > > >
> > > > > > >> > wrote:
> > > > > > >> > > > > +1
> > > > > > >> > > > >
> > > > > > >> > > > > Sent from ProtonMail Mobile
> > > > > > >> > > > >
> > > > > > >> > > > > On Fri, Dec 20, 2019 at 14:17, Tomasz Urbaszek <
> > > > > > >> > > > tomasz.urbaszek@polidea.com> wrote:
> > > > > > >> > > > >
> > > > > > >> > > > > > +1 for all four.
> > > > > > >> > > > > > T.
> > > > > > >> > > > > >
> > > > > > >> > > > > > On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła <
> > > > > > >> > > > kamil.bregula@polidea.com>
> > > > > > >> > > > > > wrote:
> > > > > > >> > > > > >
> > > > > > >> > > > > >> +1
> > > > > > >> > > > > >>
> > > > > > >> > > > > >> On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk <
> > > > > > >> > > > Jarek.Potiuk@polidea.com>
> > > > > > >> > > > > >> wrote:
> > > > > > >> > > > > >>
> > > > > > >> > > > > >> > +100
> > > > > > >> > > > > >> >
> > > > > > >> > > > > >> > On Fri, Dec 20, 2019 at 7:02 AM hotmail <
> > > > > > >> > > zhongjiajie955@hotmail.com
> > > > > > >> > > > >
> > > > > > >> > > > > >> > wrote:
> > > > > > >> > > > > >> >
> > > > > > >> > > > > >> > > I think the ci-reporter is great, because ours
> CI
> > > log
> > > > > is
> > > > > > >> > > tooooooo
> > > > > > >> > > > long
> > > > > > >> > > > > >> to
> > > > > > >> > > > > >> > > read, and I just want to know what unittest
> > failed
> > > in
> > > > > my
> > > > > > PR
> > > > > > >> > > > > >> > >
> > > > > > >> > > > > >> > > Best Wish
> > > > > > >> > > > > >> > > — Jiajie
> > > > > > >> > > > > >> > >
> > > > > > >> > > > > >> > >
> > > > > > >> > > > > >> >
> > > > > > >> > > > > >> > --
> > > > > > >> > > > > >> >
> > > > > > >> > > > > >> > Jarek Potiuk
> > > > > > >> > > > > >> > Polidea <https://www.polidea.com/> | Principal
> > > > Software
> > > > > > >> > Engineer
> > > > > > >> > > > > >> >
> > > > > > >> > > > > >> > M: +48 660 796 129 <+48660796129>
> > > > > > >> > > > > >> > [image: Polidea] <https://www.polidea.com/>
> > > > > > >> > > > > >> >
> > > > > > >> > > > > >>
> > > > > > >> > > > > >
> > > > > > >> > > > > > --
> > > > > > >> > > > > >
> > > > > > >> > > > > > Tomasz Urbaszek
> > > > > > >> > > > > > Polidea <https://www.polidea.com/> | Junior
> Software
> > > > > Engineer
> > > > > > >> > > > > >
> > > > > > >> > > > > > M: +48 505 628 493 <+48505628493>
> > > > > > >> > > > > > E: tomasz.urbaszek@polidea.com <
> > > > > tomasz.urbaszeki@polidea.com>
> > > > > > >> > > > > >
> > > > > > >> > > > > > Unique Tech
> > > > > > >> > > > > > Check out our projects! <
> > > https://www.polidea.com/our-work
> > > > >
> > > > > > >> > > >
> > > > > > >> > >
> > > > > > >> >
> > > > > > >>
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > >
> > > > > > > Jarek Potiuk
> > > > > > > Polidea <https://www.polidea.com/> | Principal Software
> Engineer
> > > > > > >
> > > > > > > M: +48 660 796 129 <+48660796129>
> > > > > > > [image: Polidea] <https://www.polidea.com/>
> > > > > > >
> > > > > > >
> > > > > >
> > > > > > --
> > > > > >
> > > > > > Jarek Potiuk
> > > > > > Polidea <https://www.polidea.com/> | Principal Software Engineer
> > > > > >
> > > > > > M: +48 660 796 129 <+48660796129>
> > > > > > [image: Polidea] <https://www.polidea.com/>
> > > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > >
> > > > Jarek Potiuk
> > > > Polidea <https://www.polidea.com/> | Principal Software Engineer
> > > >
> > > > M: +48 660 796 129 <+48660796129>
> > > > [image: Polidea] <https://www.polidea.com/>
> > > >
> > >
> >
> >
> > --
> >
> > Jarek Potiuk
> > Polidea <https://www.polidea.com/> | Principal Software Engineer
> >
> > M: +48 660 796 129 <+48660796129>
> > [image: Polidea] <https://www.polidea.com/>
> >
>
--
Jarek Potiuk
Polidea <https://www.polidea.com/> | Principal Software Engineer
M: +48 660 796 129 <+48660796129>
[image: Polidea] <https://www.polidea.com/>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Kaxil Naik <ka...@gmail.com>.
I loved *mergeable*.
One thing I realized after using the 4 Probot Integrations is that some of
the Probot apps are not actively maintained and might even be broken.
For example, *ci-reporter *didn't work for us and there are other users facing
similar issues <https://github.com/JasonEtco/ci-reporter/issues/40>.
I looked into other Probot apps including the one's suggested by Jarek and
the one Max created.
- https://probot.github.io/apps/welcome/ : This one has this
<https://github.com/behaviorbot/welcome/issues/12> particular issue open
that might not make the experience pleasant for contributors.
- https://github.com/mithro/autolabeler: Need to test if it is working as
it looks a bit outdated (and not actively maintained - no replies on issues
<https://github.com/mithro/autolabeler/issues>), however it might still
work.
- https://probot.github.io/apps/pr-triage/ : Might be good to have but this
issue <https://github.com/pr-triage/app/issues/181> might bite us too. Not
a major problem but just something to note.
- https://probot.github.io/apps/tests-checker/ : I liked this one
- https://probot.github.io/apps/reminders/ : Again might be outdated but
would need some testing to see if it actually works.
- https://github.com/z0al/dep : I liked this one too but it currently only
matches on "#PR_NUMBER". Open Issue <https://github.com/z0al/dep/issues/18> so
would want to hear opinions from others.
@Max - I like your idea and maybe long term it might make more sense. Happy
to help in the effort so that we can make it more *general*.
But there are many advantages to building something that would also help us
avoid asking extra permissions from INFRA as well as make some general
features.
I have also seen people shifting towards Github actions to do some of the
automation related to labels, comments, etc.
Does anyone have some opinion or experience with it vs Probot apps?
Regards,
Kaxil
On Tue, Dec 31, 2019 at 1:23 PM Jarek Potiuk <Ja...@polidea.com>
wrote:
> Yeah. we can remove commitlint from that list. I think Mergable is much
> better than commitlint looking at your recent configuration :)
>
> On Tue, Dec 31, 2019 at 2:14 PM Kaxil Naik <ka...@gmail.com> wrote:
>
> > Once we have got all the configs for the current integrations, I will
> > review the ones you have provided in the link above and see if it is
> > achievable with the current ones or not.
> >
> >
> >
> > On Tue, Dec 31, 2019 at 1:06 PM Jarek Potiuk <Ja...@polidea.com>
> > wrote:
> >
> > > How about adding a few more apps ? I reviewed some probot apps and
> maybe
> > we
> > > should consider those:
> > >
> > > - https://probot.github.io/apps/welcome/ - Welcomes new users
> > > submitting
> > > their PRs for the first time
> > > - https://probot.github.io/apps/reminders/ - Allows to set
> reminders
> > > for
> > > certain issues by making a "/remind" comment
> > > - https://probot.github.io/apps/pr-triage/ - Assigns labels ("PR:
> > > unreviewed", "PR: reviewed-changes-requested", "PR:
> review-approved")
> > > - https://probot.github.io/apps/tests-checker/ - Reminds to
> > add/modify
> > > tests in "tests" dir when you submit code changes
> > > - https://github.com/mithro/autolabeler - Assigns labels
> > automatically
> > > based on paths matchers (for example providers/amazon/aws/* -> "aws"
> > > label)
> > > - https://probot.github.io/apps/commitlint/ - Verifies if commit
> > > message
> > > is well formatted (including AIRFLOW-XXXX prefix]
> > >
> > > I am happy to open an issue and add configuration for those.
> > >
> > > Maybe later (After some discussion):
> > >
> > > - https://probot.github.io/apps/semantic-pull-requests/ -> that
> > > would require to introduce much more discipline in commit messages
> so
> > I
> > > am
> > > not sure it's a good idea now
> > >
> > >
> > > On Tue, Dec 31, 2019 at 1:29 PM Kaxil Naik <ka...@gmail.com>
> wrote:
> > >
> > > > Yup. I am adding some configs. PRs coming in.
> > > >
> > > > On Tue, Dec 31, 2019 at 12:24 PM Jarek Potiuk <
> > Jarek.Potiuk@polidea.com>
> > > > wrote:
> > > >
> > > > > Seems like we have a new friendly bot :)
> > > > >
> > > > > On Mon, Dec 30, 2019 at 8:41 AM Jarek Potiuk <
> > Jarek.Potiuk@polidea.com
> > > >
> > > > > wrote:
> > > > >
> > > > > > I opened a few tickets for INFRA and I am also waiting for
> answer.
> > I
> > > > > guess
> > > > > > Xmas period got in the way.
> > > > > >
> > > > > > J.
> > > > > >
> > > > > > On Mon, Dec 30, 2019 at 5:15 AM Kevin Yang <yr...@gmail.com>
> > > wrote:
> > > > > >
> > > > > >> +1!
> > > > > >>
> > > > > >> Kaxil Naik <ka...@gmail.com>于2019年12月29日 周日下午6:21写道：
> > > > > >>
> > > > > >> > Thanks Max,
> > > > > >> >
> > > > > >> > I will raise a JIRA with the INFRA to add that too.
> > > > > >> >
> > > > > >> > Btw I had raised a request for the 4 integrations
> > > > > >> > https://issues.apache.org/jira/browse/INFRA-19607 but looks
> > like
> > > it
> > > > > >> hasn't
> > > > > >> > gained any traction from them yet.
> > > > > >> >
> > > > > >> >
> > > > > >> >
> > > > > >> > On Fri, Dec 20, 2019 at 8:29 PM Maxime Beauchemin <
> > > > > >> > maximebeauchemin@gmail.com> wrote:
> > > > > >> >
> > > > > >> > > +1!
> > > > > >> > >
> > > > > >> > > I forgot whether I shared this before, but I wrote a probot
> > for
> > > > > Apache
> > > > > >> > > Superset that does a few nice things, and we can grow over
> > time
> > > to
> > > > > do
> > > > > >> > more
> > > > > >> > > things without having to beg Apache Infra for anything
> > > (currently
> > > > > only
> > > > > >> > them
> > > > > >> > > have admin rights and can register apps on our repos)
> > > > > >> > > https://github.com/apache-superset/superset-github-bot
> > > > > >> > >
> > > > > >> > > This bot, for now [as documented on the README]:
> > > > > >> > > - enables non-committer to label/unlabel PRs and Issues
> using
> > > > > comments
> > > > > >> > > (allowing PMs and other non-committer to label things)
> > > > > >> > > - auto-labels all PRs and issues with a [whitelisted]
> > > organization
> > > > > >> (adds
> > > > > >> > an
> > > > > >> > > "airbnb" or "lyft" label to the PR)
> > > > > >> > > - enables forwarding events to other webhooks
> > > > > >> > >
> > > > > >> > > Eventually I'd like for it to also auto-label based on
> > > > files/folder
> > > > > >> that
> > > > > >> > > are touched in a PR: for instance "db-migration" or
> > "scheduler"
> > > or
> > > > > >> > > "webserver" would be nice.
> > > > > >> > >
> > > > > >> > > We could rename the bot to be an "Apache Github Bot" and
> keep
> > it
> > > > > >> > > generalized (it reads a yaml config file from the project's
> > > repo,
> > > > so
> > > > > >> each
> > > > > >> > > feature of the bot can be configured on a per-project
> basis).
> > We
> > > > > could
> > > > > >> > > build a collection of things that other Apache projects are
> > > likely
> > > > > to
> > > > > >> > want.
> > > > > >> > > We may even be able to automate some Apache email-driven
> > > processes
> > > > > >> using
> > > > > >> > > Github issues instead, for instance a committer vote process
> > or
> > > > > >> release
> > > > > >> > > process vote could be automated by the bot: it would send
> > > emails,
> > > > > ask
> > > > > >> > > people to use reactions (thumbs up/down) and close the vote
> /
> > > send
> > > > > the
> > > > > >> > > RESULTS email templates to the list. It could also look for
> > ASF
> > > > > >> headers
> > > > > >> > in
> > > > > >> > > files (replacing the Apache-RAT).
> > > > > >> > >
> > > > > >> > > It could make for a great ApacheCon talk eventually as we
> add
> > > > > >> > > functionality.
> > > > > >> > >
> > > > > >> > > This is a pet project of mine for now, but I'd love to make
> > room
> > > > for
> > > > > >> > people
> > > > > >> > > to jump in and contribute to it.
> > > > > >> > >
> > > > > >> > > Max
> > > > > >> > >
> > > > > >> > > On Fri, Dec 20, 2019 at 10:04 AM Huang Xinbin <
> > > > > bin.huangxb@gmail.com>
> > > > > >> > > wrote:
> > > > > >> > >
> > > > > >> > > > +1 +1 (if I can vote XD)
> > > > > >> > > >
> > > > > >> > > > Best
> > > > > >> > > > Bin
> > > > > >> > > >
> > > > > >> > > > On 2019/12/20 13:43:11, Felix Uellendall
> > > <feluelle@pm.me.INVALID
> > > > >
> > > > > >> > wrote:
> > > > > >> > > > > +1
> > > > > >> > > > >
> > > > > >> > > > > Sent from ProtonMail Mobile
> > > > > >> > > > >
> > > > > >> > > > > On Fri, Dec 20, 2019 at 14:17, Tomasz Urbaszek <
> > > > > >> > > > tomasz.urbaszek@polidea.com> wrote:
> > > > > >> > > > >
> > > > > >> > > > > > +1 for all four.
> > > > > >> > > > > > T.
> > > > > >> > > > > >
> > > > > >> > > > > > On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła <
> > > > > >> > > > kamil.bregula@polidea.com>
> > > > > >> > > > > > wrote:
> > > > > >> > > > > >
> > > > > >> > > > > >> +1
> > > > > >> > > > > >>
> > > > > >> > > > > >> On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk <
> > > > > >> > > > Jarek.Potiuk@polidea.com>
> > > > > >> > > > > >> wrote:
> > > > > >> > > > > >>
> > > > > >> > > > > >> > +100
> > > > > >> > > > > >> >
> > > > > >> > > > > >> > On Fri, Dec 20, 2019 at 7:02 AM hotmail <
> > > > > >> > > zhongjiajie955@hotmail.com
> > > > > >> > > > >
> > > > > >> > > > > >> > wrote:
> > > > > >> > > > > >> >
> > > > > >> > > > > >> > > I think the ci-reporter is great, because ours CI
> > log
> > > > is
> > > > > >> > > tooooooo
> > > > > >> > > > long
> > > > > >> > > > > >> to
> > > > > >> > > > > >> > > read, and I just want to know what unittest
> failed
> > in
> > > > my
> > > > > PR
> > > > > >> > > > > >> > >
> > > > > >> > > > > >> > > Best Wish
> > > > > >> > > > > >> > > — Jiajie
> > > > > >> > > > > >> > >
> > > > > >> > > > > >> > >
> > > > > >> > > > > >> >
> > > > > >> > > > > >> > --
> > > > > >> > > > > >> >
> > > > > >> > > > > >> > Jarek Potiuk
> > > > > >> > > > > >> > Polidea <https://www.polidea.com/> | Principal
> > > Software
> > > > > >> > Engineer
> > > > > >> > > > > >> >
> > > > > >> > > > > >> > M: +48 660 796 129 <+48660796129>
> > > > > >> > > > > >> > [image: Polidea] <https://www.polidea.com/>
> > > > > >> > > > > >> >
> > > > > >> > > > > >>
> > > > > >> > > > > >
> > > > > >> > > > > > --
> > > > > >> > > > > >
> > > > > >> > > > > > Tomasz Urbaszek
> > > > > >> > > > > > Polidea <https://www.polidea.com/> | Junior Software
> > > > Engineer
> > > > > >> > > > > >
> > > > > >> > > > > > M: +48 505 628 493 <+48505628493>
> > > > > >> > > > > > E: tomasz.urbaszek@polidea.com <
> > > > tomasz.urbaszeki@polidea.com>
> > > > > >> > > > > >
> > > > > >> > > > > > Unique Tech
> > > > > >> > > > > > Check out our projects! <
> > https://www.polidea.com/our-work
> > > >
> > > > > >> > > >
> > > > > >> > >
> > > > > >> >
> > > > > >>
> > > > > >
> > > > > >
> > > > > > --
> > > > > >
> > > > > > Jarek Potiuk
> > > > > > Polidea <https://www.polidea.com/> | Principal Software Engineer
> > > > > >
> > > > > > M: +48 660 796 129 <+48660796129>
> > > > > > [image: Polidea] <https://www.polidea.com/>
> > > > > >
> > > > > >
> > > > >
> > > > > --
> > > > >
> > > > > Jarek Potiuk
> > > > > Polidea <https://www.polidea.com/> | Principal Software Engineer
> > > > >
> > > > > M: +48 660 796 129 <+48660796129>
> > > > > [image: Polidea] <https://www.polidea.com/>
> > > > >
> > > >
> > >
> > >
> > > --
> > >
> > > Jarek Potiuk
> > > Polidea <https://www.polidea.com/> | Principal Software Engineer
> > >
> > > M: +48 660 796 129 <+48660796129>
> > > [image: Polidea] <https://www.polidea.com/>
> > >
> >
>
>
> --
>
> Jarek Potiuk
> Polidea <https://www.polidea.com/> | Principal Software Engineer
>
> M: +48 660 796 129 <+48660796129>
> [image: Polidea] <https://www.polidea.com/>
>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Jarek Potiuk <Ja...@polidea.com>.
Yeah. we can remove commitlint from that list. I think Mergable is much
better than commitlint looking at your recent configuration :)
On Tue, Dec 31, 2019 at 2:14 PM Kaxil Naik <ka...@gmail.com> wrote:
> Once we have got all the configs for the current integrations, I will
> review the ones you have provided in the link above and see if it is
> achievable with the current ones or not.
>
>
>
> On Tue, Dec 31, 2019 at 1:06 PM Jarek Potiuk <Ja...@polidea.com>
> wrote:
>
> > How about adding a few more apps ? I reviewed some probot apps and maybe
> we
> > should consider those:
> >
> > - https://probot.github.io/apps/welcome/ - Welcomes new users
> > submitting
> > their PRs for the first time
> > - https://probot.github.io/apps/reminders/ - Allows to set reminders
> > for
> > certain issues by making a "/remind" comment
> > - https://probot.github.io/apps/pr-triage/ - Assigns labels ("PR:
> > unreviewed", "PR: reviewed-changes-requested", "PR: review-approved")
> > - https://probot.github.io/apps/tests-checker/ - Reminds to
> add/modify
> > tests in "tests" dir when you submit code changes
> > - https://github.com/mithro/autolabeler - Assigns labels
> automatically
> > based on paths matchers (for example providers/amazon/aws/* -> "aws"
> > label)
> > - https://probot.github.io/apps/commitlint/ - Verifies if commit
> > message
> > is well formatted (including AIRFLOW-XXXX prefix]
> >
> > I am happy to open an issue and add configuration for those.
> >
> > Maybe later (After some discussion):
> >
> > - https://probot.github.io/apps/semantic-pull-requests/ -> that
> > would require to introduce much more discipline in commit messages so
> I
> > am
> > not sure it's a good idea now
> >
> >
> > On Tue, Dec 31, 2019 at 1:29 PM Kaxil Naik <ka...@gmail.com> wrote:
> >
> > > Yup. I am adding some configs. PRs coming in.
> > >
> > > On Tue, Dec 31, 2019 at 12:24 PM Jarek Potiuk <
> Jarek.Potiuk@polidea.com>
> > > wrote:
> > >
> > > > Seems like we have a new friendly bot :)
> > > >
> > > > On Mon, Dec 30, 2019 at 8:41 AM Jarek Potiuk <
> Jarek.Potiuk@polidea.com
> > >
> > > > wrote:
> > > >
> > > > > I opened a few tickets for INFRA and I am also waiting for answer.
> I
> > > > guess
> > > > > Xmas period got in the way.
> > > > >
> > > > > J.
> > > > >
> > > > > On Mon, Dec 30, 2019 at 5:15 AM Kevin Yang <yr...@gmail.com>
> > wrote:
> > > > >
> > > > >> +1!
> > > > >>
> > > > >> Kaxil Naik <ka...@gmail.com>于2019年12月29日 周日下午6:21写道：
> > > > >>
> > > > >> > Thanks Max,
> > > > >> >
> > > > >> > I will raise a JIRA with the INFRA to add that too.
> > > > >> >
> > > > >> > Btw I had raised a request for the 4 integrations
> > > > >> > https://issues.apache.org/jira/browse/INFRA-19607 but looks
> like
> > it
> > > > >> hasn't
> > > > >> > gained any traction from them yet.
> > > > >> >
> > > > >> >
> > > > >> >
> > > > >> > On Fri, Dec 20, 2019 at 8:29 PM Maxime Beauchemin <
> > > > >> > maximebeauchemin@gmail.com> wrote:
> > > > >> >
> > > > >> > > +1!
> > > > >> > >
> > > > >> > > I forgot whether I shared this before, but I wrote a probot
> for
> > > > Apache
> > > > >> > > Superset that does a few nice things, and we can grow over
> time
> > to
> > > > do
> > > > >> > more
> > > > >> > > things without having to beg Apache Infra for anything
> > (currently
> > > > only
> > > > >> > them
> > > > >> > > have admin rights and can register apps on our repos)
> > > > >> > > https://github.com/apache-superset/superset-github-bot
> > > > >> > >
> > > > >> > > This bot, for now [as documented on the README]:
> > > > >> > > - enables non-committer to label/unlabel PRs and Issues using
> > > > comments
> > > > >> > > (allowing PMs and other non-committer to label things)
> > > > >> > > - auto-labels all PRs and issues with a [whitelisted]
> > organization
> > > > >> (adds
> > > > >> > an
> > > > >> > > "airbnb" or "lyft" label to the PR)
> > > > >> > > - enables forwarding events to other webhooks
> > > > >> > >
> > > > >> > > Eventually I'd like for it to also auto-label based on
> > > files/folder
> > > > >> that
> > > > >> > > are touched in a PR: for instance "db-migration" or
> "scheduler"
> > or
> > > > >> > > "webserver" would be nice.
> > > > >> > >
> > > > >> > > We could rename the bot to be an "Apache Github Bot" and keep
> it
> > > > >> > > generalized (it reads a yaml config file from the project's
> > repo,
> > > so
> > > > >> each
> > > > >> > > feature of the bot can be configured on a per-project basis).
> We
> > > > could
> > > > >> > > build a collection of things that other Apache projects are
> > likely
> > > > to
> > > > >> > want.
> > > > >> > > We may even be able to automate some Apache email-driven
> > processes
> > > > >> using
> > > > >> > > Github issues instead, for instance a committer vote process
> or
> > > > >> release
> > > > >> > > process vote could be automated by the bot: it would send
> > emails,
> > > > ask
> > > > >> > > people to use reactions (thumbs up/down) and close the vote /
> > send
> > > > the
> > > > >> > > RESULTS email templates to the list. It could also look for
> ASF
> > > > >> headers
> > > > >> > in
> > > > >> > > files (replacing the Apache-RAT).
> > > > >> > >
> > > > >> > > It could make for a great ApacheCon talk eventually as we add
> > > > >> > > functionality.
> > > > >> > >
> > > > >> > > This is a pet project of mine for now, but I'd love to make
> room
> > > for
> > > > >> > people
> > > > >> > > to jump in and contribute to it.
> > > > >> > >
> > > > >> > > Max
> > > > >> > >
> > > > >> > > On Fri, Dec 20, 2019 at 10:04 AM Huang Xinbin <
> > > > bin.huangxb@gmail.com>
> > > > >> > > wrote:
> > > > >> > >
> > > > >> > > > +1 +1 (if I can vote XD)
> > > > >> > > >
> > > > >> > > > Best
> > > > >> > > > Bin
> > > > >> > > >
> > > > >> > > > On 2019/12/20 13:43:11, Felix Uellendall
> > <feluelle@pm.me.INVALID
> > > >
> > > > >> > wrote:
> > > > >> > > > > +1
> > > > >> > > > >
> > > > >> > > > > Sent from ProtonMail Mobile
> > > > >> > > > >
> > > > >> > > > > On Fri, Dec 20, 2019 at 14:17, Tomasz Urbaszek <
> > > > >> > > > tomasz.urbaszek@polidea.com> wrote:
> > > > >> > > > >
> > > > >> > > > > > +1 for all four.
> > > > >> > > > > > T.
> > > > >> > > > > >
> > > > >> > > > > > On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła <
> > > > >> > > > kamil.bregula@polidea.com>
> > > > >> > > > > > wrote:
> > > > >> > > > > >
> > > > >> > > > > >> +1
> > > > >> > > > > >>
> > > > >> > > > > >> On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk <
> > > > >> > > > Jarek.Potiuk@polidea.com>
> > > > >> > > > > >> wrote:
> > > > >> > > > > >>
> > > > >> > > > > >> > +100
> > > > >> > > > > >> >
> > > > >> > > > > >> > On Fri, Dec 20, 2019 at 7:02 AM hotmail <
> > > > >> > > zhongjiajie955@hotmail.com
> > > > >> > > > >
> > > > >> > > > > >> > wrote:
> > > > >> > > > > >> >
> > > > >> > > > > >> > > I think the ci-reporter is great, because ours CI
> log
> > > is
> > > > >> > > tooooooo
> > > > >> > > > long
> > > > >> > > > > >> to
> > > > >> > > > > >> > > read, and I just want to know what unittest failed
> in
> > > my
> > > > PR
> > > > >> > > > > >> > >
> > > > >> > > > > >> > > Best Wish
> > > > >> > > > > >> > > — Jiajie
> > > > >> > > > > >> > >
> > > > >> > > > > >> > >
> > > > >> > > > > >> >
> > > > >> > > > > >> > --
> > > > >> > > > > >> >
> > > > >> > > > > >> > Jarek Potiuk
> > > > >> > > > > >> > Polidea <https://www.polidea.com/> | Principal
> > Software
> > > > >> > Engineer
> > > > >> > > > > >> >
> > > > >> > > > > >> > M: +48 660 796 129 <+48660796129>
> > > > >> > > > > >> > [image: Polidea] <https://www.polidea.com/>
> > > > >> > > > > >> >
> > > > >> > > > > >>
> > > > >> > > > > >
> > > > >> > > > > > --
> > > > >> > > > > >
> > > > >> > > > > > Tomasz Urbaszek
> > > > >> > > > > > Polidea <https://www.polidea.com/> | Junior Software
> > > Engineer
> > > > >> > > > > >
> > > > >> > > > > > M: +48 505 628 493 <+48505628493>
> > > > >> > > > > > E: tomasz.urbaszek@polidea.com <
> > > tomasz.urbaszeki@polidea.com>
> > > > >> > > > > >
> > > > >> > > > > > Unique Tech
> > > > >> > > > > > Check out our projects! <
> https://www.polidea.com/our-work
> > >
> > > > >> > > >
> > > > >> > >
> > > > >> >
> > > > >>
> > > > >
> > > > >
> > > > > --
> > > > >
> > > > > Jarek Potiuk
> > > > > Polidea <https://www.polidea.com/> | Principal Software Engineer
> > > > >
> > > > > M: +48 660 796 129 <+48660796129>
> > > > > [image: Polidea] <https://www.polidea.com/>
> > > > >
> > > > >
> > > >
> > > > --
> > > >
> > > > Jarek Potiuk
> > > > Polidea <https://www.polidea.com/> | Principal Software Engineer
> > > >
> > > > M: +48 660 796 129 <+48660796129>
> > > > [image: Polidea] <https://www.polidea.com/>
> > > >
> > >
> >
> >
> > --
> >
> > Jarek Potiuk
> > Polidea <https://www.polidea.com/> | Principal Software Engineer
> >
> > M: +48 660 796 129 <+48660796129>
> > [image: Polidea] <https://www.polidea.com/>
> >
>
--
Jarek Potiuk
Polidea <https://www.polidea.com/> | Principal Software Engineer
M: +48 660 796 129 <+48660796129>
[image: Polidea] <https://www.polidea.com/>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Kaxil Naik <ka...@gmail.com>.
Once we have got all the configs for the current integrations, I will
review the ones you have provided in the link above and see if it is
achievable with the current ones or not.
On Tue, Dec 31, 2019 at 1:06 PM Jarek Potiuk <Ja...@polidea.com>
wrote:
> How about adding a few more apps ? I reviewed some probot apps and maybe we
> should consider those:
>
> - https://probot.github.io/apps/welcome/ - Welcomes new users
> submitting
> their PRs for the first time
> - https://probot.github.io/apps/reminders/ - Allows to set reminders
> for
> certain issues by making a "/remind" comment
> - https://probot.github.io/apps/pr-triage/ - Assigns labels ("PR:
> unreviewed", "PR: reviewed-changes-requested", "PR: review-approved")
> - https://probot.github.io/apps/tests-checker/ - Reminds to add/modify
> tests in "tests" dir when you submit code changes
> - https://github.com/mithro/autolabeler - Assigns labels automatically
> based on paths matchers (for example providers/amazon/aws/* -> "aws"
> label)
> - https://probot.github.io/apps/commitlint/ - Verifies if commit
> message
> is well formatted (including AIRFLOW-XXXX prefix]
>
> I am happy to open an issue and add configuration for those.
>
> Maybe later (After some discussion):
>
> - https://probot.github.io/apps/semantic-pull-requests/ -> that
> would require to introduce much more discipline in commit messages so I
> am
> not sure it's a good idea now
>
>
> On Tue, Dec 31, 2019 at 1:29 PM Kaxil Naik <ka...@gmail.com> wrote:
>
> > Yup. I am adding some configs. PRs coming in.
> >
> > On Tue, Dec 31, 2019 at 12:24 PM Jarek Potiuk <Ja...@polidea.com>
> > wrote:
> >
> > > Seems like we have a new friendly bot :)
> > >
> > > On Mon, Dec 30, 2019 at 8:41 AM Jarek Potiuk <Jarek.Potiuk@polidea.com
> >
> > > wrote:
> > >
> > > > I opened a few tickets for INFRA and I am also waiting for answer. I
> > > guess
> > > > Xmas period got in the way.
> > > >
> > > > J.
> > > >
> > > > On Mon, Dec 30, 2019 at 5:15 AM Kevin Yang <yr...@gmail.com>
> wrote:
> > > >
> > > >> +1!
> > > >>
> > > >> Kaxil Naik <ka...@gmail.com>于2019年12月29日 周日下午6:21写道：
> > > >>
> > > >> > Thanks Max,
> > > >> >
> > > >> > I will raise a JIRA with the INFRA to add that too.
> > > >> >
> > > >> > Btw I had raised a request for the 4 integrations
> > > >> > https://issues.apache.org/jira/browse/INFRA-19607 but looks like
> it
> > > >> hasn't
> > > >> > gained any traction from them yet.
> > > >> >
> > > >> >
> > > >> >
> > > >> > On Fri, Dec 20, 2019 at 8:29 PM Maxime Beauchemin <
> > > >> > maximebeauchemin@gmail.com> wrote:
> > > >> >
> > > >> > > +1!
> > > >> > >
> > > >> > > I forgot whether I shared this before, but I wrote a probot for
> > > Apache
> > > >> > > Superset that does a few nice things, and we can grow over time
> to
> > > do
> > > >> > more
> > > >> > > things without having to beg Apache Infra for anything
> (currently
> > > only
> > > >> > them
> > > >> > > have admin rights and can register apps on our repos)
> > > >> > > https://github.com/apache-superset/superset-github-bot
> > > >> > >
> > > >> > > This bot, for now [as documented on the README]:
> > > >> > > - enables non-committer to label/unlabel PRs and Issues using
> > > comments
> > > >> > > (allowing PMs and other non-committer to label things)
> > > >> > > - auto-labels all PRs and issues with a [whitelisted]
> organization
> > > >> (adds
> > > >> > an
> > > >> > > "airbnb" or "lyft" label to the PR)
> > > >> > > - enables forwarding events to other webhooks
> > > >> > >
> > > >> > > Eventually I'd like for it to also auto-label based on
> > files/folder
> > > >> that
> > > >> > > are touched in a PR: for instance "db-migration" or "scheduler"
> or
> > > >> > > "webserver" would be nice.
> > > >> > >
> > > >> > > We could rename the bot to be an "Apache Github Bot" and keep it
> > > >> > > generalized (it reads a yaml config file from the project's
> repo,
> > so
> > > >> each
> > > >> > > feature of the bot can be configured on a per-project basis). We
> > > could
> > > >> > > build a collection of things that other Apache projects are
> likely
> > > to
> > > >> > want.
> > > >> > > We may even be able to automate some Apache email-driven
> processes
> > > >> using
> > > >> > > Github issues instead, for instance a committer vote process or
> > > >> release
> > > >> > > process vote could be automated by the bot: it would send
> emails,
> > > ask
> > > >> > > people to use reactions (thumbs up/down) and close the vote /
> send
> > > the
> > > >> > > RESULTS email templates to the list. It could also look for ASF
> > > >> headers
> > > >> > in
> > > >> > > files (replacing the Apache-RAT).
> > > >> > >
> > > >> > > It could make for a great ApacheCon talk eventually as we add
> > > >> > > functionality.
> > > >> > >
> > > >> > > This is a pet project of mine for now, but I'd love to make room
> > for
> > > >> > people
> > > >> > > to jump in and contribute to it.
> > > >> > >
> > > >> > > Max
> > > >> > >
> > > >> > > On Fri, Dec 20, 2019 at 10:04 AM Huang Xinbin <
> > > bin.huangxb@gmail.com>
> > > >> > > wrote:
> > > >> > >
> > > >> > > > +1 +1 (if I can vote XD)
> > > >> > > >
> > > >> > > > Best
> > > >> > > > Bin
> > > >> > > >
> > > >> > > > On 2019/12/20 13:43:11, Felix Uellendall
> <feluelle@pm.me.INVALID
> > >
> > > >> > wrote:
> > > >> > > > > +1
> > > >> > > > >
> > > >> > > > > Sent from ProtonMail Mobile
> > > >> > > > >
> > > >> > > > > On Fri, Dec 20, 2019 at 14:17, Tomasz Urbaszek <
> > > >> > > > tomasz.urbaszek@polidea.com> wrote:
> > > >> > > > >
> > > >> > > > > > +1 for all four.
> > > >> > > > > > T.
> > > >> > > > > >
> > > >> > > > > > On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła <
> > > >> > > > kamil.bregula@polidea.com>
> > > >> > > > > > wrote:
> > > >> > > > > >
> > > >> > > > > >> +1
> > > >> > > > > >>
> > > >> > > > > >> On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk <
> > > >> > > > Jarek.Potiuk@polidea.com>
> > > >> > > > > >> wrote:
> > > >> > > > > >>
> > > >> > > > > >> > +100
> > > >> > > > > >> >
> > > >> > > > > >> > On Fri, Dec 20, 2019 at 7:02 AM hotmail <
> > > >> > > zhongjiajie955@hotmail.com
> > > >> > > > >
> > > >> > > > > >> > wrote:
> > > >> > > > > >> >
> > > >> > > > > >> > > I think the ci-reporter is great, because ours CI log
> > is
> > > >> > > tooooooo
> > > >> > > > long
> > > >> > > > > >> to
> > > >> > > > > >> > > read, and I just want to know what unittest failed in
> > my
> > > PR
> > > >> > > > > >> > >
> > > >> > > > > >> > > Best Wish
> > > >> > > > > >> > > — Jiajie
> > > >> > > > > >> > >
> > > >> > > > > >> > >
> > > >> > > > > >> >
> > > >> > > > > >> > --
> > > >> > > > > >> >
> > > >> > > > > >> > Jarek Potiuk
> > > >> > > > > >> > Polidea <https://www.polidea.com/> | Principal
> Software
> > > >> > Engineer
> > > >> > > > > >> >
> > > >> > > > > >> > M: +48 660 796 129 <+48660796129>
> > > >> > > > > >> > [image: Polidea] <https://www.polidea.com/>
> > > >> > > > > >> >
> > > >> > > > > >>
> > > >> > > > > >
> > > >> > > > > > --
> > > >> > > > > >
> > > >> > > > > > Tomasz Urbaszek
> > > >> > > > > > Polidea <https://www.polidea.com/> | Junior Software
> > Engineer
> > > >> > > > > >
> > > >> > > > > > M: +48 505 628 493 <+48505628493>
> > > >> > > > > > E: tomasz.urbaszek@polidea.com <
> > tomasz.urbaszeki@polidea.com>
> > > >> > > > > >
> > > >> > > > > > Unique Tech
> > > >> > > > > > Check out our projects! <https://www.polidea.com/our-work
> >
> > > >> > > >
> > > >> > >
> > > >> >
> > > >>
> > > >
> > > >
> > > > --
> > > >
> > > > Jarek Potiuk
> > > > Polidea <https://www.polidea.com/> | Principal Software Engineer
> > > >
> > > > M: +48 660 796 129 <+48660796129>
> > > > [image: Polidea] <https://www.polidea.com/>
> > > >
> > > >
> > >
> > > --
> > >
> > > Jarek Potiuk
> > > Polidea <https://www.polidea.com/> | Principal Software Engineer
> > >
> > > M: +48 660 796 129 <+48660796129>
> > > [image: Polidea] <https://www.polidea.com/>
> > >
> >
>
>
> --
>
> Jarek Potiuk
> Polidea <https://www.polidea.com/> | Principal Software Engineer
>
> M: +48 660 796 129 <+48660796129>
> [image: Polidea] <https://www.polidea.com/>
>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Jarek Potiuk <Ja...@polidea.com>.
How about adding a few more apps ? I reviewed some probot apps and maybe we
should consider those:
- https://probot.github.io/apps/welcome/ - Welcomes new users submitting
their PRs for the first time
- https://probot.github.io/apps/reminders/ - Allows to set reminders for
certain issues by making a "/remind" comment
- https://probot.github.io/apps/pr-triage/ - Assigns labels ("PR:
unreviewed", "PR: reviewed-changes-requested", "PR: review-approved")
- https://probot.github.io/apps/tests-checker/ - Reminds to add/modify
tests in "tests" dir when you submit code changes
- https://github.com/mithro/autolabeler - Assigns labels automatically
based on paths matchers (for example providers/amazon/aws/* -> "aws" label)
- https://probot.github.io/apps/commitlint/ - Verifies if commit message
is well formatted (including AIRFLOW-XXXX prefix]
I am happy to open an issue and add configuration for those.
Maybe later (After some discussion):
- https://probot.github.io/apps/semantic-pull-requests/ -> that
would require to introduce much more discipline in commit messages so I am
not sure it's a good idea now
On Tue, Dec 31, 2019 at 1:29 PM Kaxil Naik <ka...@gmail.com> wrote:
> Yup. I am adding some configs. PRs coming in.
>
> On Tue, Dec 31, 2019 at 12:24 PM Jarek Potiuk <Ja...@polidea.com>
> wrote:
>
> > Seems like we have a new friendly bot :)
> >
> > On Mon, Dec 30, 2019 at 8:41 AM Jarek Potiuk <Ja...@polidea.com>
> > wrote:
> >
> > > I opened a few tickets for INFRA and I am also waiting for answer. I
> > guess
> > > Xmas period got in the way.
> > >
> > > J.
> > >
> > > On Mon, Dec 30, 2019 at 5:15 AM Kevin Yang <yr...@gmail.com> wrote:
> > >
> > >> +1!
> > >>
> > >> Kaxil Naik <ka...@gmail.com>于2019年12月29日 周日下午6:21写道：
> > >>
> > >> > Thanks Max,
> > >> >
> > >> > I will raise a JIRA with the INFRA to add that too.
> > >> >
> > >> > Btw I had raised a request for the 4 integrations
> > >> > https://issues.apache.org/jira/browse/INFRA-19607 but looks like it
> > >> hasn't
> > >> > gained any traction from them yet.
> > >> >
> > >> >
> > >> >
> > >> > On Fri, Dec 20, 2019 at 8:29 PM Maxime Beauchemin <
> > >> > maximebeauchemin@gmail.com> wrote:
> > >> >
> > >> > > +1!
> > >> > >
> > >> > > I forgot whether I shared this before, but I wrote a probot for
> > Apache
> > >> > > Superset that does a few nice things, and we can grow over time to
> > do
> > >> > more
> > >> > > things without having to beg Apache Infra for anything (currently
> > only
> > >> > them
> > >> > > have admin rights and can register apps on our repos)
> > >> > > https://github.com/apache-superset/superset-github-bot
> > >> > >
> > >> > > This bot, for now [as documented on the README]:
> > >> > > - enables non-committer to label/unlabel PRs and Issues using
> > comments
> > >> > > (allowing PMs and other non-committer to label things)
> > >> > > - auto-labels all PRs and issues with a [whitelisted] organization
> > >> (adds
> > >> > an
> > >> > > "airbnb" or "lyft" label to the PR)
> > >> > > - enables forwarding events to other webhooks
> > >> > >
> > >> > > Eventually I'd like for it to also auto-label based on
> files/folder
> > >> that
> > >> > > are touched in a PR: for instance "db-migration" or "scheduler" or
> > >> > > "webserver" would be nice.
> > >> > >
> > >> > > We could rename the bot to be an "Apache Github Bot" and keep it
> > >> > > generalized (it reads a yaml config file from the project's repo,
> so
> > >> each
> > >> > > feature of the bot can be configured on a per-project basis). We
> > could
> > >> > > build a collection of things that other Apache projects are likely
> > to
> > >> > want.
> > >> > > We may even be able to automate some Apache email-driven processes
> > >> using
> > >> > > Github issues instead, for instance a committer vote process or
> > >> release
> > >> > > process vote could be automated by the bot: it would send emails,
> > ask
> > >> > > people to use reactions (thumbs up/down) and close the vote / send
> > the
> > >> > > RESULTS email templates to the list. It could also look for ASF
> > >> headers
> > >> > in
> > >> > > files (replacing the Apache-RAT).
> > >> > >
> > >> > > It could make for a great ApacheCon talk eventually as we add
> > >> > > functionality.
> > >> > >
> > >> > > This is a pet project of mine for now, but I'd love to make room
> for
> > >> > people
> > >> > > to jump in and contribute to it.
> > >> > >
> > >> > > Max
> > >> > >
> > >> > > On Fri, Dec 20, 2019 at 10:04 AM Huang Xinbin <
> > bin.huangxb@gmail.com>
> > >> > > wrote:
> > >> > >
> > >> > > > +1 +1 (if I can vote XD)
> > >> > > >
> > >> > > > Best
> > >> > > > Bin
> > >> > > >
> > >> > > > On 2019/12/20 13:43:11, Felix Uellendall <feluelle@pm.me.INVALID
> >
> > >> > wrote:
> > >> > > > > +1
> > >> > > > >
> > >> > > > > Sent from ProtonMail Mobile
> > >> > > > >
> > >> > > > > On Fri, Dec 20, 2019 at 14:17, Tomasz Urbaszek <
> > >> > > > tomasz.urbaszek@polidea.com> wrote:
> > >> > > > >
> > >> > > > > > +1 for all four.
> > >> > > > > > T.
> > >> > > > > >
> > >> > > > > > On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła <
> > >> > > > kamil.bregula@polidea.com>
> > >> > > > > > wrote:
> > >> > > > > >
> > >> > > > > >> +1
> > >> > > > > >>
> > >> > > > > >> On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk <
> > >> > > > Jarek.Potiuk@polidea.com>
> > >> > > > > >> wrote:
> > >> > > > > >>
> > >> > > > > >> > +100
> > >> > > > > >> >
> > >> > > > > >> > On Fri, Dec 20, 2019 at 7:02 AM hotmail <
> > >> > > zhongjiajie955@hotmail.com
> > >> > > > >
> > >> > > > > >> > wrote:
> > >> > > > > >> >
> > >> > > > > >> > > I think the ci-reporter is great, because ours CI log
> is
> > >> > > tooooooo
> > >> > > > long
> > >> > > > > >> to
> > >> > > > > >> > > read, and I just want to know what unittest failed in
> my
> > PR
> > >> > > > > >> > >
> > >> > > > > >> > > Best Wish
> > >> > > > > >> > > — Jiajie
> > >> > > > > >> > >
> > >> > > > > >> > >
> > >> > > > > >> >
> > >> > > > > >> > --
> > >> > > > > >> >
> > >> > > > > >> > Jarek Potiuk
> > >> > > > > >> > Polidea <https://www.polidea.com/> | Principal Software
> > >> > Engineer
> > >> > > > > >> >
> > >> > > > > >> > M: +48 660 796 129 <+48660796129>
> > >> > > > > >> > [image: Polidea] <https://www.polidea.com/>
> > >> > > > > >> >
> > >> > > > > >>
> > >> > > > > >
> > >> > > > > > --
> > >> > > > > >
> > >> > > > > > Tomasz Urbaszek
> > >> > > > > > Polidea <https://www.polidea.com/> | Junior Software
> Engineer
> > >> > > > > >
> > >> > > > > > M: +48 505 628 493 <+48505628493>
> > >> > > > > > E: tomasz.urbaszek@polidea.com <
> tomasz.urbaszeki@polidea.com>
> > >> > > > > >
> > >> > > > > > Unique Tech
> > >> > > > > > Check out our projects! <https://www.polidea.com/our-work>
> > >> > > >
> > >> > >
> > >> >
> > >>
> > >
> > >
> > > --
> > >
> > > Jarek Potiuk
> > > Polidea <https://www.polidea.com/> | Principal Software Engineer
> > >
> > > M: +48 660 796 129 <+48660796129>
> > > [image: Polidea] <https://www.polidea.com/>
> > >
> > >
> >
> > --
> >
> > Jarek Potiuk
> > Polidea <https://www.polidea.com/> | Principal Software Engineer
> >
> > M: +48 660 796 129 <+48660796129>
> > [image: Polidea] <https://www.polidea.com/>
> >
>
--
Jarek Potiuk
Polidea <https://www.polidea.com/> | Principal Software Engineer
M: +48 660 796 129 <+48660796129>
[image: Polidea] <https://www.polidea.com/>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Kaxil Naik <ka...@gmail.com>.
Yup. I am adding some configs. PRs coming in.
On Tue, Dec 31, 2019 at 12:24 PM Jarek Potiuk <Ja...@polidea.com>
wrote:
> Seems like we have a new friendly bot :)
>
> On Mon, Dec 30, 2019 at 8:41 AM Jarek Potiuk <Ja...@polidea.com>
> wrote:
>
> > I opened a few tickets for INFRA and I am also waiting for answer. I
> guess
> > Xmas period got in the way.
> >
> > J.
> >
> > On Mon, Dec 30, 2019 at 5:15 AM Kevin Yang <yr...@gmail.com> wrote:
> >
> >> +1!
> >>
> >> Kaxil Naik <ka...@gmail.com>于2019年12月29日 周日下午6:21写道：
> >>
> >> > Thanks Max,
> >> >
> >> > I will raise a JIRA with the INFRA to add that too.
> >> >
> >> > Btw I had raised a request for the 4 integrations
> >> > https://issues.apache.org/jira/browse/INFRA-19607 but looks like it
> >> hasn't
> >> > gained any traction from them yet.
> >> >
> >> >
> >> >
> >> > On Fri, Dec 20, 2019 at 8:29 PM Maxime Beauchemin <
> >> > maximebeauchemin@gmail.com> wrote:
> >> >
> >> > > +1!
> >> > >
> >> > > I forgot whether I shared this before, but I wrote a probot for
> Apache
> >> > > Superset that does a few nice things, and we can grow over time to
> do
> >> > more
> >> > > things without having to beg Apache Infra for anything (currently
> only
> >> > them
> >> > > have admin rights and can register apps on our repos)
> >> > > https://github.com/apache-superset/superset-github-bot
> >> > >
> >> > > This bot, for now [as documented on the README]:
> >> > > - enables non-committer to label/unlabel PRs and Issues using
> comments
> >> > > (allowing PMs and other non-committer to label things)
> >> > > - auto-labels all PRs and issues with a [whitelisted] organization
> >> (adds
> >> > an
> >> > > "airbnb" or "lyft" label to the PR)
> >> > > - enables forwarding events to other webhooks
> >> > >
> >> > > Eventually I'd like for it to also auto-label based on files/folder
> >> that
> >> > > are touched in a PR: for instance "db-migration" or "scheduler" or
> >> > > "webserver" would be nice.
> >> > >
> >> > > We could rename the bot to be an "Apache Github Bot" and keep it
> >> > > generalized (it reads a yaml config file from the project's repo, so
> >> each
> >> > > feature of the bot can be configured on a per-project basis). We
> could
> >> > > build a collection of things that other Apache projects are likely
> to
> >> > want.
> >> > > We may even be able to automate some Apache email-driven processes
> >> using
> >> > > Github issues instead, for instance a committer vote process or
> >> release
> >> > > process vote could be automated by the bot: it would send emails,
> ask
> >> > > people to use reactions (thumbs up/down) and close the vote / send
> the
> >> > > RESULTS email templates to the list. It could also look for ASF
> >> headers
> >> > in
> >> > > files (replacing the Apache-RAT).
> >> > >
> >> > > It could make for a great ApacheCon talk eventually as we add
> >> > > functionality.
> >> > >
> >> > > This is a pet project of mine for now, but I'd love to make room for
> >> > people
> >> > > to jump in and contribute to it.
> >> > >
> >> > > Max
> >> > >
> >> > > On Fri, Dec 20, 2019 at 10:04 AM Huang Xinbin <
> bin.huangxb@gmail.com>
> >> > > wrote:
> >> > >
> >> > > > +1 +1 (if I can vote XD)
> >> > > >
> >> > > > Best
> >> > > > Bin
> >> > > >
> >> > > > On 2019/12/20 13:43:11, Felix Uellendall <fe...@pm.me.INVALID>
> >> > wrote:
> >> > > > > +1
> >> > > > >
> >> > > > > Sent from ProtonMail Mobile
> >> > > > >
> >> > > > > On Fri, Dec 20, 2019 at 14:17, Tomasz Urbaszek <
> >> > > > tomasz.urbaszek@polidea.com> wrote:
> >> > > > >
> >> > > > > > +1 for all four.
> >> > > > > > T.
> >> > > > > >
> >> > > > > > On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła <
> >> > > > kamil.bregula@polidea.com>
> >> > > > > > wrote:
> >> > > > > >
> >> > > > > >> +1
> >> > > > > >>
> >> > > > > >> On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk <
> >> > > > Jarek.Potiuk@polidea.com>
> >> > > > > >> wrote:
> >> > > > > >>
> >> > > > > >> > +100
> >> > > > > >> >
> >> > > > > >> > On Fri, Dec 20, 2019 at 7:02 AM hotmail <
> >> > > zhongjiajie955@hotmail.com
> >> > > > >
> >> > > > > >> > wrote:
> >> > > > > >> >
> >> > > > > >> > > I think the ci-reporter is great, because ours CI log is
> >> > > tooooooo
> >> > > > long
> >> > > > > >> to
> >> > > > > >> > > read, and I just want to know what unittest failed in my
> PR
> >> > > > > >> > >
> >> > > > > >> > > Best Wish
> >> > > > > >> > > — Jiajie
> >> > > > > >> > >
> >> > > > > >> > >
> >> > > > > >> >
> >> > > > > >> > --
> >> > > > > >> >
> >> > > > > >> > Jarek Potiuk
> >> > > > > >> > Polidea <https://www.polidea.com/> | Principal Software
> >> > Engineer
> >> > > > > >> >
> >> > > > > >> > M: +48 660 796 129 <+48660796129>
> >> > > > > >> > [image: Polidea] <https://www.polidea.com/>
> >> > > > > >> >
> >> > > > > >>
> >> > > > > >
> >> > > > > > --
> >> > > > > >
> >> > > > > > Tomasz Urbaszek
> >> > > > > > Polidea <https://www.polidea.com/> | Junior Software Engineer
> >> > > > > >
> >> > > > > > M: +48 505 628 493 <+48505628493>
> >> > > > > > E: tomasz.urbaszek@polidea.com <to...@polidea.com>
> >> > > > > >
> >> > > > > > Unique Tech
> >> > > > > > Check out our projects! <https://www.polidea.com/our-work>
> >> > > >
> >> > >
> >> >
> >>
> >
> >
> > --
> >
> > Jarek Potiuk
> > Polidea <https://www.polidea.com/> | Principal Software Engineer
> >
> > M: +48 660 796 129 <+48660796129>
> > [image: Polidea] <https://www.polidea.com/>
> >
> >
>
> --
>
> Jarek Potiuk
> Polidea <https://www.polidea.com/> | Principal Software Engineer
>
> M: +48 660 796 129 <+48660796129>
> [image: Polidea] <https://www.polidea.com/>
>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Jarek Potiuk <Ja...@polidea.com>.
Seems like we have a new friendly bot :)
On Mon, Dec 30, 2019 at 8:41 AM Jarek Potiuk <Ja...@polidea.com>
wrote:
> I opened a few tickets for INFRA and I am also waiting for answer. I guess
> Xmas period got in the way.
>
> J.
>
> On Mon, Dec 30, 2019 at 5:15 AM Kevin Yang <yr...@gmail.com> wrote:
>
>> +1!
>>
>> Kaxil Naik <ka...@gmail.com>于2019年12月29日 周日下午6:21写道：
>>
>> > Thanks Max,
>> >
>> > I will raise a JIRA with the INFRA to add that too.
>> >
>> > Btw I had raised a request for the 4 integrations
>> > https://issues.apache.org/jira/browse/INFRA-19607 but looks like it
>> hasn't
>> > gained any traction from them yet.
>> >
>> >
>> >
>> > On Fri, Dec 20, 2019 at 8:29 PM Maxime Beauchemin <
>> > maximebeauchemin@gmail.com> wrote:
>> >
>> > > +1!
>> > >
>> > > I forgot whether I shared this before, but I wrote a probot for Apache
>> > > Superset that does a few nice things, and we can grow over time to do
>> > more
>> > > things without having to beg Apache Infra for anything (currently only
>> > them
>> > > have admin rights and can register apps on our repos)
>> > > https://github.com/apache-superset/superset-github-bot
>> > >
>> > > This bot, for now [as documented on the README]:
>> > > - enables non-committer to label/unlabel PRs and Issues using comments
>> > > (allowing PMs and other non-committer to label things)
>> > > - auto-labels all PRs and issues with a [whitelisted] organization
>> (adds
>> > an
>> > > "airbnb" or "lyft" label to the PR)
>> > > - enables forwarding events to other webhooks
>> > >
>> > > Eventually I'd like for it to also auto-label based on files/folder
>> that
>> > > are touched in a PR: for instance "db-migration" or "scheduler" or
>> > > "webserver" would be nice.
>> > >
>> > > We could rename the bot to be an "Apache Github Bot" and keep it
>> > > generalized (it reads a yaml config file from the project's repo, so
>> each
>> > > feature of the bot can be configured on a per-project basis). We could
>> > > build a collection of things that other Apache projects are likely to
>> > want.
>> > > We may even be able to automate some Apache email-driven processes
>> using
>> > > Github issues instead, for instance a committer vote process or
>> release
>> > > process vote could be automated by the bot: it would send emails, ask
>> > > people to use reactions (thumbs up/down) and close the vote / send the
>> > > RESULTS email templates to the list. It could also look for ASF
>> headers
>> > in
>> > > files (replacing the Apache-RAT).
>> > >
>> > > It could make for a great ApacheCon talk eventually as we add
>> > > functionality.
>> > >
>> > > This is a pet project of mine for now, but I'd love to make room for
>> > people
>> > > to jump in and contribute to it.
>> > >
>> > > Max
>> > >
>> > > On Fri, Dec 20, 2019 at 10:04 AM Huang Xinbin <bi...@gmail.com>
>> > > wrote:
>> > >
>> > > > +1 +1 (if I can vote XD)
>> > > >
>> > > > Best
>> > > > Bin
>> > > >
>> > > > On 2019/12/20 13:43:11, Felix Uellendall <fe...@pm.me.INVALID>
>> > wrote:
>> > > > > +1
>> > > > >
>> > > > > Sent from ProtonMail Mobile
>> > > > >
>> > > > > On Fri, Dec 20, 2019 at 14:17, Tomasz Urbaszek <
>> > > > tomasz.urbaszek@polidea.com> wrote:
>> > > > >
>> > > > > > +1 for all four.
>> > > > > > T.
>> > > > > >
>> > > > > > On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła <
>> > > > kamil.bregula@polidea.com>
>> > > > > > wrote:
>> > > > > >
>> > > > > >> +1
>> > > > > >>
>> > > > > >> On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk <
>> > > > Jarek.Potiuk@polidea.com>
>> > > > > >> wrote:
>> > > > > >>
>> > > > > >> > +100
>> > > > > >> >
>> > > > > >> > On Fri, Dec 20, 2019 at 7:02 AM hotmail <
>> > > zhongjiajie955@hotmail.com
>> > > > >
>> > > > > >> > wrote:
>> > > > > >> >
>> > > > > >> > > I think the ci-reporter is great, because ours CI log is
>> > > tooooooo
>> > > > long
>> > > > > >> to
>> > > > > >> > > read, and I just want to know what unittest failed in my PR
>> > > > > >> > >
>> > > > > >> > > Best Wish
>> > > > > >> > > — Jiajie
>> > > > > >> > >
>> > > > > >> > >
>> > > > > >> >
>> > > > > >> > --
>> > > > > >> >
>> > > > > >> > Jarek Potiuk
>> > > > > >> > Polidea <https://www.polidea.com/> | Principal Software
>> > Engineer
>> > > > > >> >
>> > > > > >> > M: +48 660 796 129 <+48660796129>
>> > > > > >> > [image: Polidea] <https://www.polidea.com/>
>> > > > > >> >
>> > > > > >>
>> > > > > >
>> > > > > > --
>> > > > > >
>> > > > > > Tomasz Urbaszek
>> > > > > > Polidea <https://www.polidea.com/> | Junior Software Engineer
>> > > > > >
>> > > > > > M: +48 505 628 493 <+48505628493>
>> > > > > > E: tomasz.urbaszek@polidea.com <to...@polidea.com>
>> > > > > >
>> > > > > > Unique Tech
>> > > > > > Check out our projects! <https://www.polidea.com/our-work>
>> > > >
>> > >
>> >
>>
>
>
> --
>
> Jarek Potiuk
> Polidea <https://www.polidea.com/> | Principal Software Engineer
>
> M: +48 660 796 129 <+48660796129>
> [image: Polidea] <https://www.polidea.com/>
>
>
--
Jarek Potiuk
Polidea <https://www.polidea.com/> | Principal Software Engineer
M: +48 660 796 129 <+48660796129>
[image: Polidea] <https://www.polidea.com/>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Jarek Potiuk <Ja...@polidea.com>.
I opened a few tickets for INFRA and I am also waiting for answer. I guess
Xmas period got in the way.
J.
On Mon, Dec 30, 2019 at 5:15 AM Kevin Yang <yr...@gmail.com> wrote:
> +1!
>
> Kaxil Naik <ka...@gmail.com>于2019年12月29日 周日下午6:21写道：
>
> > Thanks Max,
> >
> > I will raise a JIRA with the INFRA to add that too.
> >
> > Btw I had raised a request for the 4 integrations
> > https://issues.apache.org/jira/browse/INFRA-19607 but looks like it
> hasn't
> > gained any traction from them yet.
> >
> >
> >
> > On Fri, Dec 20, 2019 at 8:29 PM Maxime Beauchemin <
> > maximebeauchemin@gmail.com> wrote:
> >
> > > +1!
> > >
> > > I forgot whether I shared this before, but I wrote a probot for Apache
> > > Superset that does a few nice things, and we can grow over time to do
> > more
> > > things without having to beg Apache Infra for anything (currently only
> > them
> > > have admin rights and can register apps on our repos)
> > > https://github.com/apache-superset/superset-github-bot
> > >
> > > This bot, for now [as documented on the README]:
> > > - enables non-committer to label/unlabel PRs and Issues using comments
> > > (allowing PMs and other non-committer to label things)
> > > - auto-labels all PRs and issues with a [whitelisted] organization
> (adds
> > an
> > > "airbnb" or "lyft" label to the PR)
> > > - enables forwarding events to other webhooks
> > >
> > > Eventually I'd like for it to also auto-label based on files/folder
> that
> > > are touched in a PR: for instance "db-migration" or "scheduler" or
> > > "webserver" would be nice.
> > >
> > > We could rename the bot to be an "Apache Github Bot" and keep it
> > > generalized (it reads a yaml config file from the project's repo, so
> each
> > > feature of the bot can be configured on a per-project basis). We could
> > > build a collection of things that other Apache projects are likely to
> > want.
> > > We may even be able to automate some Apache email-driven processes
> using
> > > Github issues instead, for instance a committer vote process or release
> > > process vote could be automated by the bot: it would send emails, ask
> > > people to use reactions (thumbs up/down) and close the vote / send the
> > > RESULTS email templates to the list. It could also look for ASF headers
> > in
> > > files (replacing the Apache-RAT).
> > >
> > > It could make for a great ApacheCon talk eventually as we add
> > > functionality.
> > >
> > > This is a pet project of mine for now, but I'd love to make room for
> > people
> > > to jump in and contribute to it.
> > >
> > > Max
> > >
> > > On Fri, Dec 20, 2019 at 10:04 AM Huang Xinbin <bi...@gmail.com>
> > > wrote:
> > >
> > > > +1 +1 (if I can vote XD)
> > > >
> > > > Best
> > > > Bin
> > > >
> > > > On 2019/12/20 13:43:11, Felix Uellendall <fe...@pm.me.INVALID>
> > wrote:
> > > > > +1
> > > > >
> > > > > Sent from ProtonMail Mobile
> > > > >
> > > > > On Fri, Dec 20, 2019 at 14:17, Tomasz Urbaszek <
> > > > tomasz.urbaszek@polidea.com> wrote:
> > > > >
> > > > > > +1 for all four.
> > > > > > T.
> > > > > >
> > > > > > On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła <
> > > > kamil.bregula@polidea.com>
> > > > > > wrote:
> > > > > >
> > > > > >> +1
> > > > > >>
> > > > > >> On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk <
> > > > Jarek.Potiuk@polidea.com>
> > > > > >> wrote:
> > > > > >>
> > > > > >> > +100
> > > > > >> >
> > > > > >> > On Fri, Dec 20, 2019 at 7:02 AM hotmail <
> > > zhongjiajie955@hotmail.com
> > > > >
> > > > > >> > wrote:
> > > > > >> >
> > > > > >> > > I think the ci-reporter is great, because ours CI log is
> > > tooooooo
> > > > long
> > > > > >> to
> > > > > >> > > read, and I just want to know what unittest failed in my PR
> > > > > >> > >
> > > > > >> > > Best Wish
> > > > > >> > > — Jiajie
> > > > > >> > >
> > > > > >> > >
> > > > > >> >
> > > > > >> > --
> > > > > >> >
> > > > > >> > Jarek Potiuk
> > > > > >> > Polidea <https://www.polidea.com/> | Principal Software
> > Engineer
> > > > > >> >
> > > > > >> > M: +48 660 796 129 <+48660796129>
> > > > > >> > [image: Polidea] <https://www.polidea.com/>
> > > > > >> >
> > > > > >>
> > > > > >
> > > > > > --
> > > > > >
> > > > > > Tomasz Urbaszek
> > > > > > Polidea <https://www.polidea.com/> | Junior Software Engineer
> > > > > >
> > > > > > M: +48 505 628 493 <+48505628493>
> > > > > > E: tomasz.urbaszek@polidea.com <to...@polidea.com>
> > > > > >
> > > > > > Unique Tech
> > > > > > Check out our projects! <https://www.polidea.com/our-work>
> > > >
> > >
> >
>
--
Jarek Potiuk
Polidea <https://www.polidea.com/> | Principal Software Engineer
M: +48 660 796 129 <+48660796129>
[image: Polidea] <https://www.polidea.com/>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Kevin Yang <yr...@gmail.com>.
+1!
Kaxil Naik <ka...@gmail.com>于2019年12月29日 周日下午6:21写道：
> Thanks Max,
>
> I will raise a JIRA with the INFRA to add that too.
>
> Btw I had raised a request for the 4 integrations
> https://issues.apache.org/jira/browse/INFRA-19607 but looks like it hasn't
> gained any traction from them yet.
>
>
>
> On Fri, Dec 20, 2019 at 8:29 PM Maxime Beauchemin <
> maximebeauchemin@gmail.com> wrote:
>
> > +1!
> >
> > I forgot whether I shared this before, but I wrote a probot for Apache
> > Superset that does a few nice things, and we can grow over time to do
> more
> > things without having to beg Apache Infra for anything (currently only
> them
> > have admin rights and can register apps on our repos)
> > https://github.com/apache-superset/superset-github-bot
> >
> > This bot, for now [as documented on the README]:
> > - enables non-committer to label/unlabel PRs and Issues using comments
> > (allowing PMs and other non-committer to label things)
> > - auto-labels all PRs and issues with a [whitelisted] organization (adds
> an
> > "airbnb" or "lyft" label to the PR)
> > - enables forwarding events to other webhooks
> >
> > Eventually I'd like for it to also auto-label based on files/folder that
> > are touched in a PR: for instance "db-migration" or "scheduler" or
> > "webserver" would be nice.
> >
> > We could rename the bot to be an "Apache Github Bot" and keep it
> > generalized (it reads a yaml config file from the project's repo, so each
> > feature of the bot can be configured on a per-project basis). We could
> > build a collection of things that other Apache projects are likely to
> want.
> > We may even be able to automate some Apache email-driven processes using
> > Github issues instead, for instance a committer vote process or release
> > process vote could be automated by the bot: it would send emails, ask
> > people to use reactions (thumbs up/down) and close the vote / send the
> > RESULTS email templates to the list. It could also look for ASF headers
> in
> > files (replacing the Apache-RAT).
> >
> > It could make for a great ApacheCon talk eventually as we add
> > functionality.
> >
> > This is a pet project of mine for now, but I'd love to make room for
> people
> > to jump in and contribute to it.
> >
> > Max
> >
> > On Fri, Dec 20, 2019 at 10:04 AM Huang Xinbin <bi...@gmail.com>
> > wrote:
> >
> > > +1 +1 (if I can vote XD)
> > >
> > > Best
> > > Bin
> > >
> > > On 2019/12/20 13:43:11, Felix Uellendall <fe...@pm.me.INVALID>
> wrote:
> > > > +1
> > > >
> > > > Sent from ProtonMail Mobile
> > > >
> > > > On Fri, Dec 20, 2019 at 14:17, Tomasz Urbaszek <
> > > tomasz.urbaszek@polidea.com> wrote:
> > > >
> > > > > +1 for all four.
> > > > > T.
> > > > >
> > > > > On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła <
> > > kamil.bregula@polidea.com>
> > > > > wrote:
> > > > >
> > > > >> +1
> > > > >>
> > > > >> On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk <
> > > Jarek.Potiuk@polidea.com>
> > > > >> wrote:
> > > > >>
> > > > >> > +100
> > > > >> >
> > > > >> > On Fri, Dec 20, 2019 at 7:02 AM hotmail <
> > zhongjiajie955@hotmail.com
> > > >
> > > > >> > wrote:
> > > > >> >
> > > > >> > > I think the ci-reporter is great, because ours CI log is
> > tooooooo
> > > long
> > > > >> to
> > > > >> > > read, and I just want to know what unittest failed in my PR
> > > > >> > >
> > > > >> > > Best Wish
> > > > >> > > — Jiajie
> > > > >> > >
> > > > >> > >
> > > > >> >
> > > > >> > --
> > > > >> >
> > > > >> > Jarek Potiuk
> > > > >> > Polidea <https://www.polidea.com/> | Principal Software
> Engineer
> > > > >> >
> > > > >> > M: +48 660 796 129 <+48660796129>
> > > > >> > [image: Polidea] <https://www.polidea.com/>
> > > > >> >
> > > > >>
> > > > >
> > > > > --
> > > > >
> > > > > Tomasz Urbaszek
> > > > > Polidea <https://www.polidea.com/> | Junior Software Engineer
> > > > >
> > > > > M: +48 505 628 493 <+48505628493>
> > > > > E: tomasz.urbaszek@polidea.com <to...@polidea.com>
> > > > >
> > > > > Unique Tech
> > > > > Check out our projects! <https://www.polidea.com/our-work>
> > >
> >
>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Kaxil Naik <ka...@gmail.com>.
Thanks Max,
I will raise a JIRA with the INFRA to add that too.
Btw I had raised a request for the 4 integrations
https://issues.apache.org/jira/browse/INFRA-19607 but looks like it hasn't
gained any traction from them yet.
On Fri, Dec 20, 2019 at 8:29 PM Maxime Beauchemin <
maximebeauchemin@gmail.com> wrote:
> +1!
>
> I forgot whether I shared this before, but I wrote a probot for Apache
> Superset that does a few nice things, and we can grow over time to do more
> things without having to beg Apache Infra for anything (currently only them
> have admin rights and can register apps on our repos)
> https://github.com/apache-superset/superset-github-bot
>
> This bot, for now [as documented on the README]:
> - enables non-committer to label/unlabel PRs and Issues using comments
> (allowing PMs and other non-committer to label things)
> - auto-labels all PRs and issues with a [whitelisted] organization (adds an
> "airbnb" or "lyft" label to the PR)
> - enables forwarding events to other webhooks
>
> Eventually I'd like for it to also auto-label based on files/folder that
> are touched in a PR: for instance "db-migration" or "scheduler" or
> "webserver" would be nice.
>
> We could rename the bot to be an "Apache Github Bot" and keep it
> generalized (it reads a yaml config file from the project's repo, so each
> feature of the bot can be configured on a per-project basis). We could
> build a collection of things that other Apache projects are likely to want.
> We may even be able to automate some Apache email-driven processes using
> Github issues instead, for instance a committer vote process or release
> process vote could be automated by the bot: it would send emails, ask
> people to use reactions (thumbs up/down) and close the vote / send the
> RESULTS email templates to the list. It could also look for ASF headers in
> files (replacing the Apache-RAT).
>
> It could make for a great ApacheCon talk eventually as we add
> functionality.
>
> This is a pet project of mine for now, but I'd love to make room for people
> to jump in and contribute to it.
>
> Max
>
> On Fri, Dec 20, 2019 at 10:04 AM Huang Xinbin <bi...@gmail.com>
> wrote:
>
> > +1 +1 (if I can vote XD)
> >
> > Best
> > Bin
> >
> > On 2019/12/20 13:43:11, Felix Uellendall <fe...@pm.me.INVALID> wrote:
> > > +1
> > >
> > > Sent from ProtonMail Mobile
> > >
> > > On Fri, Dec 20, 2019 at 14:17, Tomasz Urbaszek <
> > tomasz.urbaszek@polidea.com> wrote:
> > >
> > > > +1 for all four.
> > > > T.
> > > >
> > > > On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła <
> > kamil.bregula@polidea.com>
> > > > wrote:
> > > >
> > > >> +1
> > > >>
> > > >> On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk <
> > Jarek.Potiuk@polidea.com>
> > > >> wrote:
> > > >>
> > > >> > +100
> > > >> >
> > > >> > On Fri, Dec 20, 2019 at 7:02 AM hotmail <
> zhongjiajie955@hotmail.com
> > >
> > > >> > wrote:
> > > >> >
> > > >> > > I think the ci-reporter is great, because ours CI log is
> tooooooo
> > long
> > > >> to
> > > >> > > read, and I just want to know what unittest failed in my PR
> > > >> > >
> > > >> > > Best Wish
> > > >> > > — Jiajie
> > > >> > >
> > > >> > >
> > > >> >
> > > >> > --
> > > >> >
> > > >> > Jarek Potiuk
> > > >> > Polidea <https://www.polidea.com/> | Principal Software Engineer
> > > >> >
> > > >> > M: +48 660 796 129 <+48660796129>
> > > >> > [image: Polidea] <https://www.polidea.com/>
> > > >> >
> > > >>
> > > >
> > > > --
> > > >
> > > > Tomasz Urbaszek
> > > > Polidea <https://www.polidea.com/> | Junior Software Engineer
> > > >
> > > > M: +48 505 628 493 <+48505628493>
> > > > E: tomasz.urbaszek@polidea.com <to...@polidea.com>
> > > >
> > > > Unique Tech
> > > > Check out our projects! <https://www.polidea.com/our-work>
> >
>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Maxime Beauchemin <ma...@gmail.com>.
+1!
I forgot whether I shared this before, but I wrote a probot for Apache
Superset that does a few nice things, and we can grow over time to do more
things without having to beg Apache Infra for anything (currently only them
have admin rights and can register apps on our repos)
https://github.com/apache-superset/superset-github-bot
This bot, for now [as documented on the README]:
- enables non-committer to label/unlabel PRs and Issues using comments
(allowing PMs and other non-committer to label things)
- auto-labels all PRs and issues with a [whitelisted] organization (adds an
"airbnb" or "lyft" label to the PR)
- enables forwarding events to other webhooks
Eventually I'd like for it to also auto-label based on files/folder that
are touched in a PR: for instance "db-migration" or "scheduler" or
"webserver" would be nice.
We could rename the bot to be an "Apache Github Bot" and keep it
generalized (it reads a yaml config file from the project's repo, so each
feature of the bot can be configured on a per-project basis). We could
build a collection of things that other Apache projects are likely to want.
We may even be able to automate some Apache email-driven processes using
Github issues instead, for instance a committer vote process or release
process vote could be automated by the bot: it would send emails, ask
people to use reactions (thumbs up/down) and close the vote / send the
RESULTS email templates to the list. It could also look for ASF headers in
files (replacing the Apache-RAT).
It could make for a great ApacheCon talk eventually as we add functionality.
This is a pet project of mine for now, but I'd love to make room for people
to jump in and contribute to it.
Max
On Fri, Dec 20, 2019 at 10:04 AM Huang Xinbin <bi...@gmail.com> wrote:
> +1 +1 (if I can vote XD)
>
> Best
> Bin
>
> On 2019/12/20 13:43:11, Felix Uellendall <fe...@pm.me.INVALID> wrote:
> > +1
> >
> > Sent from ProtonMail Mobile
> >
> > On Fri, Dec 20, 2019 at 14:17, Tomasz Urbaszek <
> tomasz.urbaszek@polidea.com> wrote:
> >
> > > +1 for all four.
> > > T.
> > >
> > > On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła <
> kamil.bregula@polidea.com>
> > > wrote:
> > >
> > >> +1
> > >>
> > >> On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk <
> Jarek.Potiuk@polidea.com>
> > >> wrote:
> > >>
> > >> > +100
> > >> >
> > >> > On Fri, Dec 20, 2019 at 7:02 AM hotmail <zhongjiajie955@hotmail.com
> >
> > >> > wrote:
> > >> >
> > >> > > I think the ci-reporter is great, because ours CI log is tooooooo
> long
> > >> to
> > >> > > read, and I just want to know what unittest failed in my PR
> > >> > >
> > >> > > Best Wish
> > >> > > — Jiajie
> > >> > >
> > >> > >
> > >> >
> > >> > --
> > >> >
> > >> > Jarek Potiuk
> > >> > Polidea <https://www.polidea.com/> | Principal Software Engineer
> > >> >
> > >> > M: +48 660 796 129 <+48660796129>
> > >> > [image: Polidea] <https://www.polidea.com/>
> > >> >
> > >>
> > >
> > > --
> > >
> > > Tomasz Urbaszek
> > > Polidea <https://www.polidea.com/> | Junior Software Engineer
> > >
> > > M: +48 505 628 493 <+48505628493>
> > > E: tomasz.urbaszek@polidea.com <to...@polidea.com>
> > >
> > > Unique Tech
> > > Check out our projects! <https://www.polidea.com/our-work>
>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Huang Xinbin <bi...@gmail.com>.
+1 +1 (if I can vote XD)
Best
Bin
On 2019/12/20 13:43:11, Felix Uellendall <fe...@pm.me.INVALID> wrote:
> +1
>
> Sent from ProtonMail Mobile
>
> On Fri, Dec 20, 2019 at 14:17, Tomasz Urbaszek <to...@polidea.com> wrote:
>
> > +1 for all four.
> > T.
> >
> > On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła <ka...@polidea.com>
> > wrote:
> >
> >> +1
> >>
> >> On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk <Ja...@polidea.com>
> >> wrote:
> >>
> >> > +100
> >> >
> >> > On Fri, Dec 20, 2019 at 7:02 AM hotmail <zh...@hotmail.com>
> >> > wrote:
> >> >
> >> > > I think the ci-reporter is great, because ours CI log is tooooooo long
> >> to
> >> > > read, and I just want to know what unittest failed in my PR
> >> > >
> >> > > Best Wish
> >> > > — Jiajie
> >> > >
> >> > >
> >> >
> >> > --
> >> >
> >> > Jarek Potiuk
> >> > Polidea <https://www.polidea.com/> | Principal Software Engineer
> >> >
> >> > M: +48 660 796 129 <+48660796129>
> >> > [image: Polidea] <https://www.polidea.com/>
> >> >
> >>
> >
> > --
> >
> > Tomasz Urbaszek
> > Polidea <https://www.polidea.com/> | Junior Software Engineer
> >
> > M: +48 505 628 493 <+48505628493>
> > E: tomasz.urbaszek@polidea.com <to...@polidea.com>
> >
> > Unique Tech
> > Check out our projects! <https://www.polidea.com/our-work>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Felix Uellendall <fe...@pm.me.INVALID>.
+1
Sent from ProtonMail Mobile
On Fri, Dec 20, 2019 at 14:17, Tomasz Urbaszek <to...@polidea.com> wrote:
> +1 for all four.
> T.
>
> On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła <ka...@polidea.com>
> wrote:
>
>> +1
>>
>> On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk <Ja...@polidea.com>
>> wrote:
>>
>> > +100
>> >
>> > On Fri, Dec 20, 2019 at 7:02 AM hotmail <zh...@hotmail.com>
>> > wrote:
>> >
>> > > I think the ci-reporter is great, because ours CI log is tooooooo long
>> to
>> > > read, and I just want to know what unittest failed in my PR
>> > >
>> > > Best Wish
>> > > — Jiajie
>> > >
>> > >
>> >
>> > --
>> >
>> > Jarek Potiuk
>> > Polidea <https://www.polidea.com/> | Principal Software Engineer
>> >
>> > M: +48 660 796 129 <+48660796129>
>> > [image: Polidea] <https://www.polidea.com/>
>> >
>>
>
> --
>
> Tomasz Urbaszek
> Polidea <https://www.polidea.com/> | Junior Software Engineer
>
> M: +48 505 628 493 <+48505628493>
> E: tomasz.urbaszek@polidea.com <to...@polidea.com>
>
> Unique Tech
> Check out our projects! <https://www.polidea.com/our-work>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Tomasz Urbaszek <to...@polidea.com>.
+1 for all four.
T.
On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła <ka...@polidea.com>
wrote:
> +1
>
> On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk <Ja...@polidea.com>
> wrote:
>
> > +100
> >
> > On Fri, Dec 20, 2019 at 7:02 AM hotmail <zh...@hotmail.com>
> > wrote:
> >
> > > I think the ci-reporter is great, because ours CI log is tooooooo long
> to
> > > read, and I just want to know what unittest failed in my PR
> > >
> > > Best Wish
> > > — Jiajie
> > >
> > >
> >
> > --
> >
> > Jarek Potiuk
> > Polidea <https://www.polidea.com/> | Principal Software Engineer
> >
> > M: +48 660 796 129 <+48660796129>
> > [image: Polidea] <https://www.polidea.com/>
> >
>
--
Tomasz Urbaszek
Polidea <https://www.polidea.com/> | Junior Software Engineer
M: +48 505 628 493 <+48505628493>
E: tomasz.urbaszek@polidea.com <to...@polidea.com>
Unique Tech
Check out our projects! <https://www.polidea.com/our-work>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Kamil Breguła <ka...@polidea.com>.
+1
On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk <Ja...@polidea.com>
wrote:
> +100
>
> On Fri, Dec 20, 2019 at 7:02 AM hotmail <zh...@hotmail.com>
> wrote:
>
> > I think the ci-reporter is great, because ours CI log is tooooooo long to
> > read, and I just want to know what unittest failed in my PR
> >
> > Best Wish
> > — Jiajie
> >
> >
>
> --
>
> Jarek Potiuk
> Polidea <https://www.polidea.com/> | Principal Software Engineer
>
> M: +48 660 796 129 <+48660796129>
> [image: Polidea] <https://www.polidea.com/>
>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Jarek Potiuk <Ja...@polidea.com>.
+100
On Fri, Dec 20, 2019 at 7:02 AM hotmail <zh...@hotmail.com> wrote:
> I think the ci-reporter is great, because ours CI log is tooooooo long to
> read, and I just want to know what unittest failed in my PR
>
> Best Wish
> — Jiajie
>
>
--
Jarek Potiuk
Polidea <https://www.polidea.com/> | Principal Software Engineer
M: +48 660 796 129 <+48660796129>
[image: Polidea] <https://www.polidea.com/>
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by hotmail <zh...@hotmail.com>.
I think the ci-reporter is great, because ours CI log is tooooooo long to read, and I just want to know what unittest failed in my PR
Best Wish
— Jiajie
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Bjorn Olsen <bj...@gmail.com>.
Hi all
I did some thinking about this and how we can improve the contribution
process. Hadn't had a chance to draft that mail yet but some of it is
relevant to probot so I'll just reply here :)
I think we already have probot stale (at least, I saw some bot comments on
older PRs).
I'd suggest we make it a bit more aggressive, looks like it currently
comments after 6 months of inactivity which is very long. By then nobody
knows the state of the pr.
It would also be cool if it could comment after eg 10days to remind the
contributor to follow up for code review.
I did some analysis and one of the common things holding back PRs from
merging is just that review is not requested, then the pr eventually gets
too stale to merge.
I think this could really help to get more contributions merged.
Kind regards
On Fri, 20 Dec 2019, 04:02 Daniel Imberman, <da...@gmail.com>
wrote:
> +1 +1 +1 +1
> +1 +1 +1 +1
> +1 +1 +1 +1
> +1 +1 +1 +1
> +1 +1 +1 +1
> +1 +1 +1 +1
> +1 +1 +1 +1
> …
>
> Yes please.
>
>
> via Newton Mail [
> https://cloudmagic.com/k/d/mailapp?ct=dx&cv=10.0.32&pv=10.14.5&source=email_footer_2
> ]
> On Thu, Dec 19, 2019 at 5:51 PM, Kaxil Naik <ka...@gmail.com> wrote:
> Hello all,
>
> I would like to propose that we add the following ProBot integrations to
> Airflow repo:
>
> - https://github.com/apps/ci-reporter - Works with your project's CI
> tool to report failed builds into the relevant PR.
> - https://github.com/apps/mergeable - Prevents merging of Pull Requests
> based on configurations. Make your Pull Requests mergeable only when:
> - https://github.com/apps/wip/ - Prevent merging of WIP PRs
> - https://github.com/apps/stale/ - Closes abandoned issues after a
> period of inactivity.
>
>
> We can add more integrations later but for now, I propose we add the above
> 4. If we have a positive consensus I will raise a JIRA issue with the
> Apache INFRA team.
>
> Regards,
> Kaxil
Re: [VOTE] Add Probot Integrations to Airflow Github Repo
Posted by Daniel Imberman <da...@gmail.com>.
+1 +1 +1 +1
+1 +1 +1 +1
+1 +1 +1 +1
+1 +1 +1 +1
+1 +1 +1 +1
+1 +1 +1 +1
+1 +1 +1 +1
…
Yes please.
via Newton Mail [https://cloudmagic.com/k/d/mailapp?ct=dx&cv=10.0.32&pv=10.14.5&source=email_footer_2]
On Thu, Dec 19, 2019 at 5:51 PM, Kaxil Naik <ka...@gmail.com> wrote:
Hello all,
I would like to propose that we add the following ProBot integrations to
Airflow repo:
- https://github.com/apps/ci-reporter - Works with your project's CI
tool to report failed builds into the relevant PR.
- https://github.com/apps/mergeable - Prevents merging of Pull Requests
based on configurations. Make your Pull Requests mergeable only when:
- https://github.com/apps/wip/ - Prevent merging of WIP PRs
- https://github.com/apps/stale/ - Closes abandoned issues after a
period of inactivity.
We can add more integrations later but for now, I propose we add the above
4. If we have a positive consensus I will raise a JIRA issue with the
Apache INFRA team.
Regards,
Kaxil