You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/16 23:29:12 UTC
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10068: chore: type src/dashboard/util/charts
etr2460 commented on a change in pull request #10068:
URL: https://github.com/apache/incubator-superset/pull/10068#discussion_r441197345
##########
File path: superset-frontend/src/dashboard/util/charts/getFormDataWithExtraFilters.ts
##########
@@ -25,16 +25,24 @@ import getEffectiveExtraFilters from './getEffectiveExtraFilters';
const cachedFiltersByChart = {};
const cachedFormdataByChart = {};
+interface GetFormDataWithExtraFiltersArguments {
+ chart: Record<string, any>;
Review comment:
I don't think we're at a point where it matches any existing types yet... My plan was to only start adding specific param types once needed to get typing to work. Then, as these were added, I'd expect other files to start failing without specific enough types. Finally, once everything is typed, we can go through and clean up unknowns, anys, and Records.
Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org