You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Master-Frank (via GitHub)" <gi...@apache.org> on 2026/10/23 10:30:19 UTC
[PR] test(runtime-host): stop ShellRun crash recovery from racing its markers [maka]
Master-Frank opened a new pull request, #6268:
URL: https://github.com/apache/maka/pull/6268
## Summary
`ShellRun process crash recovery from <phase> does not redispatch` fails intermittently. The parent kills the fixture as soon as `ready.json` appears, then asserts that the background command wrote `starts` exactly once. Goal idle does not wait for that command to start, so the assertion can run before `starts` exists (`ENOENT`). A torn `ready.json` also makes `JSON.parse` throw `SyntaxError`, and the poll only tolerated `ENOENT`.
The fixture already publishes `ready.json` by writing a temporary file and renaming it into place. This change waits until `starts` is `1` and `process-id` is a pid before that publish, so the kill cannot land first. The parent's poll now treats a `SyntaxError` from `JSON.parse` as not ready yet, the same as a missing file.
Fixes #6266
## Verification
- `npx biome check` on the edited test: pass.
- `npx tsc -b packages/runtime-host`: pass.
- Fixed test, Node 22.23.4, Linux: `ShellRun process crash recovery` passed 16/16 (`--test-concurrency=1`).
- Unmodified pre-fix test on this host passed 10/10. The reported flake was 3/10 on macOS, Node 24.21.0, so this machine did not lose the race on its own.
- Same fixture with the background command delayed 3s before it writes `starts`: the pre-fix test fails with `ENOENT` on `root/starts` (the signature in the issue). With this change, both the `running` and `terminal` phases pass.
The full `@maka/runtime-host` `test:dist` suite was not run.
## AI use
Select exactly one:
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Cursor Opus5.5 authored the test change.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [ ] Yes — described under Summary above
- [x] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(runtime-host): stop ShellRun crash recovery from racing its markers [maka]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx closed pull request #6268: test(runtime-host): stop ShellRun crash recovery from racing its markers
URL: https://github.com/apache/maka/pull/6268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(runtime-host): stop ShellRun crash recovery from racing its markers [maka]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #6268:
URL: https://github.com/apache/maka/pull/6268#issuecomment-6431280747
Closing as superseded: #6298 removed the ShellRun crash-recovery tests this PR hardens, so there is nothing left to fix. Thanks @Master-Frank for the fix and the analysis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(runtime-host): stop ShellRun crash recovery from racing its markers [maka]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #6268:
URL: https://github.com/apache/maka/pull/6268#issuecomment-6430961116
Heads-up: #6298 (merged as da614305c) rewrote `goal-root-authority.test.ts` and removed both `ShellRun crash fixture` and `ShellRun process crash recovery from <phase> does not redispatch`. This PR now conflicts in that region, and the test it hardens no longer exists on main, so there is nothing left to rebase onto. Unless the crash-recovery coverage is meant to return in a new form, this looks superseded and #6266 moot. Leaving the close decision to the maintainers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org