You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2019/03/07 00:11:08 UTC
[kudu-CR] docs: KUDU-2411: document the binary test jar
Hello Andrew Wong, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12685
to review the following change.
Change subject: docs: KUDU-2411: document the binary test jar
......................................................................
docs: KUDU-2411: document the binary test jar
This patch adds documentation for how to use the Kudu binary test jar.
Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
---
M docs/developing.adoc
1 file changed, 128 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/12685/1
--
To view, visit http://gerrit.cloudera.org:8080/12685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
Gerrit-Change-Number: 12685
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] docs: KUDU-2411: Document the binary test jar
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 )
Change subject: docs: KUDU-2411: Document the binary test jar
......................................................................
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/12685/2/docs/developing.adoc
File docs/developing.adoc:
http://gerrit.cloudera.org:8080/#/c/12685/2/docs/developing.adoc@265
PS2, Line 265: jar
Nit: JAR being an acronym, we should probably write it in upper-case in official documentation.
http://gerrit.cloudera.org:8080/#/c/12685/2/docs/developing.adoc@282
PS2, Line 282: The binary test jar must be run on one of the supported Kudu platforms, which includes:
We should probably link to the generic Kudu system requirements too, so that people know to use e.g. ext4 or xfs filesystems.
http://gerrit.cloudera.org:8080/#/c/12685/2/docs/developing.adoc@285
PS2, Line 285: modern
I mean, can we really call a distro that's about 5 years old (Ubuntu 14) 'modern'?
http://gerrit.cloudera.org:8080/#/c/12685/2/docs/developing.adoc@307
PS2, Line 307: property ${os.detected.classifier} -->
Nit: cleaner indentation would be one character less.
http://gerrit.cloudera.org:8080/#/c/12685/2/docs/developing.adoc@355
PS2, Line 355: // The KuduTestHarness automatically starts and stops a real Kudu cluster
: // when each test is run.
Should probably mention that it creates a bunch of on-disk state at startup, then deletes it on shutdown. Maybe also mention where that state lives (since it'll persist in an abnormal exist). Maybe also mention that cluster logging goes to stderr (or if it's configurable via log4j, mention that).
--
To view, visit http://gerrit.cloudera.org:8080/12685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
Gerrit-Change-Number: 12685
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 02:00:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: KUDU-2411: Document the binary test jar
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12685
to look at the new patch set (#3).
Change subject: docs: KUDU-2411: Document the binary test jar
......................................................................
docs: KUDU-2411: Document the binary test jar
This patch adds documentation for how to use the Kudu binary test jar.
Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
---
M docs/developing.adoc
1 file changed, 132 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/12685/3
--
To view, visit http://gerrit.cloudera.org:8080/12685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
Gerrit-Change-Number: 12685
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] docs: KUDU-2411: Document the binary test jar
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12685 )
Change subject: docs: KUDU-2411: Document the binary test jar
......................................................................
docs: KUDU-2411: Document the binary test jar
This patch adds documentation for how to use the Kudu binary test jar.
Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
Reviewed-on: http://gerrit.cloudera.org:8080/12685
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M docs/developing.adoc
1 file changed, 132 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
Gerrit-Change-Number: 12685
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] docs: KUDU-2411: Document the binary test jar
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 )
Change subject: docs: KUDU-2411: Document the binary test jar
......................................................................
Patch Set 2: Code-Review+2
Sweet, thanks! I'll leave this open for a bit in case Grant wants a gander.
--
To view, visit http://gerrit.cloudera.org:8080/12685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
Gerrit-Change-Number: 12685
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 00:37:53 +0000
Gerrit-HasComments: No
[kudu-CR] docs: KUDU-2411: Document the binary test jar
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 )
Change subject: docs: KUDU-2411: Document the binary test jar
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
Gerrit-Change-Number: 12685
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 17:26:36 +0000
Gerrit-HasComments: No
[kudu-CR] docs: KUDU-2411: document the binary test jar
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 )
Change subject: docs: KUDU-2411: document the binary test jar
......................................................................
Patch Set 1:
Rendered docs here: https://github.com/mpercy/kudu/blob/binary-jar-docs-1/docs/developing.adoc#jvm-based-integration-testing
--
To view, visit http://gerrit.cloudera.org:8080/12685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
Gerrit-Change-Number: 12685
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 00:12:29 +0000
Gerrit-HasComments: No
[kudu-CR] docs: KUDU-2411: Document the binary test jar
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 )
Change subject: docs: KUDU-2411: Document the binary test jar
......................................................................
Patch Set 2:
Thanks for the quick review!
--
To view, visit http://gerrit.cloudera.org:8080/12685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
Gerrit-Change-Number: 12685
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 00:39:04 +0000
Gerrit-HasComments: No
[kudu-CR] docs: KUDU-2411: Document the binary test jar
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12685
to look at the new patch set (#2).
Change subject: docs: KUDU-2411: Document the binary test jar
......................................................................
docs: KUDU-2411: Document the binary test jar
This patch adds documentation for how to use the Kudu binary test jar.
Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
---
M docs/developing.adoc
1 file changed, 128 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/12685/2
--
To view, visit http://gerrit.cloudera.org:8080/12685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
Gerrit-Change-Number: 12685
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] docs: KUDU-2411: document the binary test jar
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 )
Change subject: docs: KUDU-2411: document the binary test jar
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12685/1/docs/developing.adoc
File docs/developing.adoc:
http://gerrit.cloudera.org:8080/#/c/12685/1/docs/developing.adoc@317
PS1, Line 317: <dependency>
: <groupId>org.apache.kudu</groupId>
: <artifactId>kudu-test-utils</artifactId>
: <version>1.9.0</version>
: <scope>test</scope>
: </dependency>
: <dependency>
: <groupId>org.apache.kudu</groupId>
: <artifactId>kudu-binary</artifactId>
: <version>1.9.0</version>
: <classifier>${os.detected.classifier}</classifier>
: <scope>test</scope>
> Is it important to keep these in sync with each other? And in sync with the
Good catch; I'll make it 1.10.0 on this branch and change it to 1.9.0 in the backport.
--
To view, visit http://gerrit.cloudera.org:8080/12685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
Gerrit-Change-Number: 12685
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 00:34:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: KUDU-2411: Document the binary test jar
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 )
Change subject: docs: KUDU-2411: Document the binary test jar
......................................................................
Patch Set 2:
updated the rendering as well
--
To view, visit http://gerrit.cloudera.org:8080/12685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
Gerrit-Change-Number: 12685
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 00:35:58 +0000
Gerrit-HasComments: No
[kudu-CR] docs: KUDU-2411: document the binary test jar
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 )
Change subject: docs: KUDU-2411: document the binary test jar
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Looks good!
http://gerrit.cloudera.org:8080/#/c/12685/1/docs/developing.adoc
File docs/developing.adoc:
http://gerrit.cloudera.org:8080/#/c/12685/1/docs/developing.adoc@317
PS1, Line 317: <dependency>
: <groupId>org.apache.kudu</groupId>
: <artifactId>kudu-test-utils</artifactId>
: <version>1.9.0</version>
: <scope>test</scope>
: </dependency>
: <dependency>
: <groupId>org.apache.kudu</groupId>
: <artifactId>kudu-binary</artifactId>
: <version>1.9.0</version>
: <classifier>${os.detected.classifier}</classifier>
: <scope>test</scope>
Is it important to keep these in sync with each other? And in sync with the kudu-client version? Is that worth noting?
--
To view, visit http://gerrit.cloudera.org:8080/12685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
Gerrit-Change-Number: 12685
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 00:25:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: KUDU-2411: Document the binary test jar
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 )
Change subject: docs: KUDU-2411: Document the binary test jar
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/12685/1/docs/developing.adoc
File docs/developing.adoc:
http://gerrit.cloudera.org:8080/#/c/12685/1/docs/developing.adoc@317
PS1, Line 317: <dependency>
: <groupId>org.apache.kudu</groupId>
: <artifactId>kudu-test-utils</artifactId>
: <version>1.9.0</version>
: <scope>test</scope>
: </dependency>
: <dependency>
: <groupId>org.apache.kudu</groupId>
: <artifactId>kudu-binary</artifactId>
: <version>1.9.0</version>
: <classifier>${os.detected.classifier}</classifier>
: <scope>test</scope>
> Good catch; I'll make it 1.10.0 on this branch and change it to 1.9.0 in th
It's not important to keep these in sync though. And it can be a useful way to test forwards and backwards compatibility to change the binary (server) version to not match the client version.
I think we should commit using 1.9.0 as we likely won't bump this in every release and it would be nice to have a version that works, even in master.
http://gerrit.cloudera.org:8080/#/c/12685/2/docs/developing.adoc
File docs/developing.adoc:
http://gerrit.cloudera.org:8080/#/c/12685/2/docs/developing.adoc@268
PS2, Line 268: by the Kudu team uploading relocatable Kudu binaries (Linux and Mac) to Maven
This sounds a bit weird. It more about the process than the contents and use.
Maybe something like:
This is made possible because the Kudu binary jar contains relocatable Kudu binaries which are used by the `KuduTestHarness` in the kudu-test-utils jar. The `KuduTestHarness` contains the logic to search the
classpath for the Kudu binaries and start a mini-cluster using them.
http://gerrit.cloudera.org:8080/#/c/12685/2/docs/developing.adoc@300
PS2, Line 300: Maven example for Kudu 1.9.0:
Should we use 1.9.0?
--
To view, visit http://gerrit.cloudera.org:8080/12685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
Gerrit-Change-Number: 12685
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 04:23:47 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: KUDU-2411: Document the binary test jar
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 )
Change subject: docs: KUDU-2411: Document the binary test jar
......................................................................
Patch Set 2:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/12685/1/docs/developing.adoc
File docs/developing.adoc:
http://gerrit.cloudera.org:8080/#/c/12685/1/docs/developing.adoc@317
PS1, Line 317: <dependency>
: <groupId>org.apache.kudu</groupId>
: <artifactId>kudu-test-utils</artifactId>
: <version>1.10.0</version>
: <scope>test</scope>
: </dependency>
: <dependency>
: <groupId>org.apache.kudu</groupId>
: <artifactId>kudu-binary</artifactId>
: <version>1.10.0</version>
: <classifier>${os.detected.classifier}</classifier>
: <scope>test</scope>
> It's not important to keep these in sync though. And it can be a useful way
I don't know why we wouldn't bump this every release.
http://gerrit.cloudera.org:8080/#/c/12685/2/docs/developing.adoc
File docs/developing.adoc:
http://gerrit.cloudera.org:8080/#/c/12685/2/docs/developing.adoc@265
PS2, Line 265: jar
> Nit: JAR being an acronym, we should probably write it in upper-case in off
Done
http://gerrit.cloudera.org:8080/#/c/12685/2/docs/developing.adoc@268
PS2, Line 268: by the Kudu team uploading relocatable Kudu binaries (Linux and Mac) to Maven
> This sounds a bit weird. It more about the process than the contents and us
Done
http://gerrit.cloudera.org:8080/#/c/12685/2/docs/developing.adoc@282
PS2, Line 282: The binary test jar must be run on one of the supported Kudu platforms, which includes:
> We should probably link to the generic Kudu system requirements too, so tha
Done
http://gerrit.cloudera.org:8080/#/c/12685/2/docs/developing.adoc@285
PS2, Line 285: modern
> I mean, can we really call a distro that's about 5 years old (Ubuntu 14) 'm
I guess I'll call it recent
http://gerrit.cloudera.org:8080/#/c/12685/2/docs/developing.adoc@300
PS2, Line 300: Maven example for Kudu 1.10.0:
> Should we use 1.9.0?
See previous discussion and my other comment
http://gerrit.cloudera.org:8080/#/c/12685/2/docs/developing.adoc@307
PS2, Line 307: property ${os.detected.classifier} -->
> Nit: cleaner indentation would be one character less.
Done
http://gerrit.cloudera.org:8080/#/c/12685/2/docs/developing.adoc@355
PS2, Line 355: // The KuduTestHarness automatically starts and stops a real Kudu cluster
: // when each test is run.
> Should probably mention that it creates a bunch of on-disk state at startup
Done
--
To view, visit http://gerrit.cloudera.org:8080/12685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8189f1703626587a5313d8c1fb11d046455d9f39
Gerrit-Change-Number: 12685
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 06:42:27 +0000
Gerrit-HasComments: Yes