You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by "Harry262530 (via GitHub)" <gi...@apache.org> on 2023/01/21 04:24:37 UTC
[GitHub] [streampipes] Harry262530 opened a new pull request, #1142: pull request for auto pr labeler
Harry262530 opened a new pull request, #1142:
URL: https://github.com/apache/streampipes/pull/1142
<!--
~ Licensed to the Apache Software Foundation (ASF) under one or more
~ contributor license agreements. See the NOTICE file distributed with
~ this work for additional information regarding copyright ownership.
~ The ASF licenses this file to You under the Apache License, Version 2.0
~ (the "License"); you may not use this file except in compliance with
~ the License. You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
~
-->
<!--
Thanks for contributing! Here are some tips you can follow to help us incorporate your contribution quickly and easily:
1. If this is your first time, please read our contributor guidelines:
- https://streampipes.apache.org/getinvolved.html
- https://cwiki.apache.org/confluence/display/STREAMPIPES/Getting+Started
2. Make sure the PR title is formatted like: `[#<GitHub issue id>] PR title ...`
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., `[WIP][#<GitHub issue id>] PR title ...`.
4. Please write your PR title to summarize what this PR proposes/fixes.
5. Link the PR to the corresponding GitHub issue (if present) in the `Development` section in the right menu bar.
6. Be sure to keep the PR description updated to reflect all changes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
8. Make sure tests pass via `mvn clean install`.
9. (Optional) If the contribution is large, please file an Apache ICLA
- http://apache.org/licenses/icla.pdf
-->
### Purpose
<!--
Please clarify what changes you are proposing and describe how those changes will address the issue.
Furthermore, describe potential consequences the changes might have.
-->
### Remarks
<!--
Is there anything left we need to pay attention on?
Are there some references that might be important? E.g. links to Confluence, or discussions
on the mailing list or GitHub.
-->
PR introduces (a) breaking change(s): <yes/no>
PR introduces (a) deprecation(s): <yes/no>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] dominikriemer commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically
Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer commented on code in PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#discussion_r1087521805
##########
.github/pr-labeler-config.yml:
##########
@@ -0,0 +1,61 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+backend:
+# TODO
+
+connect:
+ - streampipes-extensions/streampipes-connect-adapters/**/*
+ - streampipes-extensions/streampipes-connect-adapters-iiot/**/*
+
+
+dependencies:
+ - ./**/pom.xml
+ - ./**/setup.py
+ - ui/**/package.json
+ - ui/**/package-lock.json
+
+documentation:
+ - ./**/*.md
+
+gh-actions:
+ - .github/**/*
+
+installer:
+ - installer/**/*
+
+java:
+ - ./**/*.java
+
+javascript:
+ - ./**/*.js
+
+'pipeline elements':
+ - streampipes-exensions/streampipes-extensions-*/**/*
+ - streampipes-extensions/streampipes-pipeline-*/**/*
Review Comment:
Do we have such a module in streampipes-extensions currently?
##########
.github/pr-labeler-config.yml:
##########
@@ -0,0 +1,46 @@
+backend:
+# TODO
Review Comment:
Not sure if it's possible but we could filter for all modules starting with streampipes-* except streampipes-extensions and non-java modules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1104] add GitHub workflow to label PRs automatically (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on code in PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#discussion_r1088195897
##########
.github/pr-labeler-config.yml:
##########
@@ -0,0 +1,46 @@
+backend:
+# TODO
Review Comment:
Had the same idea, I'll have a look if the config's syntax allows for that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] Harry262530 commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically
Posted by "Harry262530 (via GitHub)" <gi...@apache.org>.
Harry262530 commented on code in PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083275393
##########
.github/workflows/prlabelling.yaml:
##########
@@ -0,0 +1,16 @@
+name: "Pull Request Labeler"
+run-name: ${{ github.actor }} created Pull Request Labeler
+
+on:
+- pull_request_target
+
+jobs:
Review Comment:
should i assign permissions ,contents and pull request or just leave it for default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1104] add GitHub workflow to label PRs automatically (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti merged PR #1142:
URL: https://github.com/apache/streampipes/pull/1142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on code in PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083271649
##########
.github/prlabeller.yml:
##########
@@ -0,0 +1,21 @@
+# Add repo label to any change in any file
Review Comment:
This is just the example config from the GitHub action, right?
That does not suit for us, but that's not a problem.
I will take care of adapting the config accordingly.
##########
config_merge.yml:
##########
@@ -0,0 +1,18 @@
+name: 'PRLabeler'
Review Comment:
What's the purpose of this file?
From my understanding, we only need the other two files.
##########
.github/workflows/prlabelling.yaml:
##########
@@ -0,0 +1,16 @@
+name: "Pull Request Labeler"
+run-name: ${{ github.actor }} created Pull Request Labeler
+
+on:
+- pull_request_target
Review Comment:
If I am not mistaken, this event is only produced when a PR from a forked repository is created.
This is not what we desire here. I think the more general `pull_request` event is better suited for us and we should filter on opening events. Read more about that here: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request
##########
.github/workflows/prlabelling.yaml:
##########
@@ -0,0 +1,16 @@
+name: "Pull Request Labeler"
+run-name: ${{ github.actor }} created Pull Request Labeler
+
+on:
+- pull_request_target
+
+jobs:
Review Comment:
It would be great if you could filter for PRs created by @dependabot
To do so you can follow this example [here](https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#accessing-and-using-event-properties)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on code in PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083274439
##########
.github/prlabeller.yml:
##########
@@ -0,0 +1,21 @@
+# Add repo label to any change in any file
Review Comment:
I see, but we don't use such a label
You can find an overview of all our labels [here](https://github.com/apache/streampipes/labels)
Feel free to improve the config, if you want to e
##########
.github/prlabeller.yml:
##########
@@ -0,0 +1,21 @@
+# Add repo label to any change in any file
Review Comment:
I see, but we don't use such a label
You can find an overview of all our labels [here](https://github.com/apache/streampipes/labels)
Feel free to improve the config, if you want to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on code in PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083274194
##########
.github/workflows/prlabelling.yaml:
##########
@@ -0,0 +1,16 @@
+name: "Pull Request Labeler"
+run-name: ${{ github.actor }} created Pull Request Labeler
+
+on:
+- pull_request_target
Review Comment:
You can just leave this PR open and push new commits to your existing branch, then this PR is updated automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] Harry262530 commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically
Posted by "Harry262530 (via GitHub)" <gi...@apache.org>.
Harry262530 commented on code in PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083273920
##########
.github/prlabeller.yml:
##########
@@ -0,0 +1,21 @@
+# Add repo label to any change in any file
Review Comment:
yah,
basically i was trying to give at least one label to any issue as 'repo'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] Harry262530 commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically
Posted by "Harry262530 (via GitHub)" <gi...@apache.org>.
Harry262530 commented on code in PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083274910
##########
.github/prlabeller.yml:
##########
@@ -0,0 +1,21 @@
+# Add repo label to any change in any file
Review Comment:
sure,
i will try my level best
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on code in PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#discussion_r1087222213
##########
.github/pr-labeler-config.yml:
##########
@@ -0,0 +1,46 @@
+backend:
+# TODO
Review Comment:
@tenthe @dominikriemer what do you think we should provide here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] Harry262530 commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically
Posted by "Harry262530 (via GitHub)" <gi...@apache.org>.
Harry262530 commented on code in PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083274176
##########
config_merge.yml:
##########
@@ -0,0 +1,18 @@
+name: 'PRLabeler'
Review Comment:
actually for the past 1 day i studied about pull request and labels so I saw this file on one repo, so I included it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] Harry262530 commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically
Posted by "Harry262530 (via GitHub)" <gi...@apache.org>.
Harry262530 commented on code in PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083274304
##########
.github/workflows/prlabelling.yaml:
##########
@@ -0,0 +1,16 @@
+name: "Pull Request Labeler"
+run-name: ${{ github.actor }} created Pull Request Labeler
+
+on:
+- pull_request_target
Review Comment:
sure,
i'll do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on pull request #1142: [#1104] add GitHub workflow to label PRs automatically
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#issuecomment-1404279104
@tenthe @dominikriemer I came with an initial version of the label config
Although, I'm not really user whether all these file path filters will work, I would just give it a try
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1104] add GitHub workflow to label PRs automatically (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on code in PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#discussion_r1088195357
##########
.github/pr-labeler-config.yml:
##########
@@ -0,0 +1,61 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+backend:
+# TODO
+
+connect:
+ - streampipes-extensions/streampipes-connect-adapters/**/*
+ - streampipes-extensions/streampipes-connect-adapters-iiot/**/*
+
+
+dependencies:
+ - ./**/pom.xml
+ - ./**/setup.py
+ - ui/**/package.json
+ - ui/**/package-lock.json
+
+documentation:
+ - ./**/*.md
+
+gh-actions:
+ - .github/**/*
+
+installer:
+ - installer/**/*
+
+java:
+ - ./**/*.java
+
+javascript:
+ - ./**/*.js
+
+'pipeline elements':
+ - streampipes-exensions/streampipes-extensions-*/**/*
+ - streampipes-extensions/streampipes-pipeline-*/**/*
Review Comment:
Yes we have, e.g. https://github.com/apache/streampipes/tree/dev/streampipes-extensions/streampipes-pipeline-elements-all-flink
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] Harry262530 commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically
Posted by "Harry262530 (via GitHub)" <gi...@apache.org>.
Harry262530 commented on code in PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083274037
##########
.github/workflows/prlabelling.yaml:
##########
@@ -0,0 +1,16 @@
+name: "Pull Request Labeler"
+run-name: ${{ github.actor }} created Pull Request Labeler
+
+on:
+- pull_request_target
Review Comment:
thanks for the advice
should I change it and then send another pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on code in PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083274659
##########
config_merge.yml:
##########
@@ -0,0 +1,18 @@
+name: 'PRLabeler'
Review Comment:
Can you provide me with a link to an example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on code in PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083274659
##########
config_merge.yml:
##########
@@ -0,0 +1,18 @@
+name: 'PRLabeler'
Review Comment:
Can you provide me with an example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on code in PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083291525
##########
.github/workflows/prlabelling.yaml:
##########
@@ -0,0 +1,16 @@
+name: "Pull Request Labeler"
+run-name: ${{ github.actor }} created Pull Request Labeler
+
+on:
+- pull_request_target
+
+jobs:
Review Comment:
I think this looks fine for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org