You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/11/28 08:52:46 UTC

Review Request: SQOOP-725. Run hbase unit tests against hadoop-2

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8243/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

Patch to enable hbase tests against hadoop-2.0. The build on Apache Jenkins against hadoop-23 and hadoop-2 would need to be disabled, since there are no maven artifacts available. So a local build of hbase against the correct version of hadoop(if it is 23 or 2) is needed, for the build to be successful.


This addresses bug SQOOP-725.
    https://issues.apache.org/jira/browse/SQOOP-725


Diffs
-----

  build.xml 12ba785 
  ivy/ivysettings.xml 251131c 
  src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 3f5899e 
  src/test/com/cloudera/sqoop/hbase/TestHBaseImport.java 2108e28 
  src/test/com/cloudera/sqoop/hbase/TestHBaseQueryImport.java 705dcae 

Diff: https://reviews.apache.org/r/8243/diff/


Testing
-------


Thanks,

Hari Shreedharan


Re: Review Request: SQOOP-725. Run hbase unit tests against hadoop-2

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8243/#review13853
-----------------------------------------------------------

Ship it!


Looks good, thank you for your effort Hari!

- Jarek Cecho


On Nov. 28, 2012, 10:41 p.m., Hari Shreedharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8243/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2012, 10:41 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> Patch to enable hbase tests against hadoop-2.0. The build on Apache Jenkins against hadoop-23 and hadoop-2 would need to be disabled, since there are no maven artifacts available. So a local build of hbase against the correct version of hadoop(if it is 23 or 2) is needed, for the build to be successful.
> 
> 
> This addresses bug SQOOP-725.
>     https://issues.apache.org/jira/browse/SQOOP-725
> 
> 
> Diffs
> -----
> 
>   build.xml 12ba785 
>   ivy/ivysettings.xml 251131c 
>   src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 3f5899e 
>   src/test/com/cloudera/sqoop/hbase/TestHBaseImport.java 2108e28 
>   src/test/com/cloudera/sqoop/hbase/TestHBaseQueryImport.java 705dcae 
> 
> Diff: https://reviews.apache.org/r/8243/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hari Shreedharan
> 
>


Re: Review Request: SQOOP-725. Run hbase unit tests against hadoop-2

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8243/
-----------------------------------------------------------

(Updated Nov. 28, 2012, 10:41 p.m.)


Review request for Sqoop.


Description
-------

Patch to enable hbase tests against hadoop-2.0. The build on Apache Jenkins against hadoop-23 and hadoop-2 would need to be disabled, since there are no maven artifacts available. So a local build of hbase against the correct version of hadoop(if it is 23 or 2) is needed, for the build to be successful.


This addresses bug SQOOP-725.
    https://issues.apache.org/jira/browse/SQOOP-725


Diffs (updated)
-----

  build.xml 12ba785 
  ivy/ivysettings.xml 251131c 
  src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 3f5899e 
  src/test/com/cloudera/sqoop/hbase/TestHBaseImport.java 2108e28 
  src/test/com/cloudera/sqoop/hbase/TestHBaseQueryImport.java 705dcae 

Diff: https://reviews.apache.org/r/8243/diff/


Testing
-------


Thanks,

Hari Shreedharan