You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/23 06:42:31 UTC
[GitHub] [apisix] membphis commented on a change in pull request #2273: test: add integration test
membphis commented on a change in pull request #2273:
URL: https://github.com/apache/apisix/pull/2273#discussion_r493231665
##########
File path: t/pycases/cases/nginx.conf
##########
@@ -0,0 +1,16 @@
+worker_processes 1;
+error_log error.log;
+events {
+ worker_connections 1024;
+}
+http {
+ server {
+ listen 9000;
+ location / {
+ default_type text/html;
+ content_by_lua '
Review comment:
`content_by_lua_block` is better
##########
File path: t/pycases/cases/nginx.conf
##########
@@ -0,0 +1,16 @@
+worker_processes 1;
+error_log error.log;
+events {
+ worker_connections 1024;
Review comment:
`4096` is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org