You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by GitBox <gi...@apache.org> on 2020/10/06 14:32:00 UTC
[GitHub] [sling-feature-converter-maven-plugin] bosschaert opened a new pull request #1: SLING-9794 Content package artifacts found by maven plugin don't always have their 'file' attribute set
bosschaert opened a new pull request #1:
URL: https://github.com/apache/sling-feature-converter-maven-plugin/pull/1
This fixes the NPE that can happen in this case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-feature-converter-maven-plugin] bosschaert merged pull request #1: SLING-9794 Content package artifacts found by maven plugin don't always have their 'file' attribute set
Posted by GitBox <gi...@apache.org>.
bosschaert merged pull request #1:
URL: https://github.com/apache/sling-feature-converter-maven-plugin/pull/1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-feature-converter-maven-plugin] bosschaert commented on a change in pull request #1: SLING-9794 Content package artifacts found by maven plugin don't always have their 'file' attribute set
Posted by GitBox <gi...@apache.org>.
bosschaert commented on a change in pull request #1:
URL: https://github.com/apache/sling-feature-converter-maven-plugin/pull/1#discussion_r500396169
##########
File path: src/main/java/org/apache/sling/cpconverter/maven/mojos/ContentPackage.java
##########
@@ -90,13 +99,57 @@ public boolean isModuleIsContentPackage() {
// all dependencies, transitives included
artifacts = project.getArtifacts();
}
+
+ // Sometimes artifacts don't have their 'file' attribute set, which we need. For those that don't, resolve them
+ final Set<Artifact> fileArtifacts = new HashSet<>();
+ for (Artifact a : artifacts) {
+ if (a.getFile() != null) {
+ fileArtifacts.add(a);
+ } else {
+ if (repoSystem != null && repoSession != null) {
+ // Resolving the artifact via Aether will fill in the file attribute
+ Artifact fileArt = resolveArtifact(repoSystem, repoSession, a);
+ if (fileArt != null) {
Review comment:
I think it would be an error condition in reality. Right now the code ignores those artifacts, but maybe it would be better to throw an exception instead...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-feature-converter-maven-plugin] sonarcloud[bot] removed a comment on pull request #1: SLING-9794 Content package artifacts found by maven plugin don't always have their 'file' attribute set
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #1:
URL: https://github.com/apache/sling-feature-converter-maven-plugin/pull/1#issuecomment-704314231
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types
=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-feature-converter-maven-plugin] cziegeler commented on a change in pull request #1: SLING-9794 Content package artifacts found by maven plugin don't always have their 'file' attribute set
Posted by GitBox <gi...@apache.org>.
cziegeler commented on a change in pull request #1:
URL: https://github.com/apache/sling-feature-converter-maven-plugin/pull/1#discussion_r500341181
##########
File path: src/main/java/org/apache/sling/cpconverter/maven/mojos/ContentPackage.java
##########
@@ -90,13 +99,57 @@ public boolean isModuleIsContentPackage() {
// all dependencies, transitives included
artifacts = project.getArtifacts();
}
+
+ // Sometimes artifacts don't have their 'file' attribute set, which we need. For those that don't, resolve them
+ final Set<Artifact> fileArtifacts = new HashSet<>();
+ for (Artifact a : artifacts) {
+ if (a.getFile() != null) {
+ fileArtifacts.add(a);
+ } else {
+ if (repoSystem != null && repoSession != null) {
+ // Resolving the artifact via Aether will fill in the file attribute
+ Artifact fileArt = resolveArtifact(repoSystem, repoSession, a);
+ if (fileArt != null) {
Review comment:
Is it an error condition if the file can't be resolved?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-feature-converter-maven-plugin] bosschaert commented on a change in pull request #1: SLING-9794 Content package artifacts found by maven plugin don't always have their 'file' attribute set
Posted by GitBox <gi...@apache.org>.
bosschaert commented on a change in pull request #1:
URL: https://github.com/apache/sling-feature-converter-maven-plugin/pull/1#discussion_r500516862
##########
File path: src/main/java/org/apache/sling/cpconverter/maven/mojos/ContentPackage.java
##########
@@ -90,13 +99,57 @@ public boolean isModuleIsContentPackage() {
// all dependencies, transitives included
artifacts = project.getArtifacts();
}
+
+ // Sometimes artifacts don't have their 'file' attribute set, which we need. For those that don't, resolve them
+ final Set<Artifact> fileArtifacts = new HashSet<>();
+ for (Artifact a : artifacts) {
+ if (a.getFile() != null) {
+ fileArtifacts.add(a);
+ } else {
+ if (repoSystem != null && repoSession != null) {
+ // Resolving the artifact via Aether will fill in the file attribute
+ Artifact fileArt = resolveArtifact(repoSystem, repoSession, a);
+ if (fileArt != null) {
Review comment:
I've made that change. Thanks for the review, @cziegeler !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-feature-converter-maven-plugin] cziegeler commented on a change in pull request #1: SLING-9794 Content package artifacts found by maven plugin don't always have their 'file' attribute set
Posted by GitBox <gi...@apache.org>.
cziegeler commented on a change in pull request #1:
URL: https://github.com/apache/sling-feature-converter-maven-plugin/pull/1#discussion_r500409258
##########
File path: src/main/java/org/apache/sling/cpconverter/maven/mojos/ContentPackage.java
##########
@@ -90,13 +99,57 @@ public boolean isModuleIsContentPackage() {
// all dependencies, transitives included
artifacts = project.getArtifacts();
}
+
+ // Sometimes artifacts don't have their 'file' attribute set, which we need. For those that don't, resolve them
+ final Set<Artifact> fileArtifacts = new HashSet<>();
+ for (Artifact a : artifacts) {
+ if (a.getFile() != null) {
+ fileArtifacts.add(a);
+ } else {
+ if (repoSystem != null && repoSession != null) {
+ // Resolving the artifact via Aether will fill in the file attribute
+ Artifact fileArt = resolveArtifact(repoSystem, repoSession, a);
+ if (fileArt != null) {
Review comment:
Yes, that was my thinking here as well, better throw an exception
Apart from that the PR looks good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-feature-converter-maven-plugin] sonarcloud[bot] commented on pull request #1: SLING-9794 Content package artifacts found by maven plugin don't always have their 'file' attribute set
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #1:
URL: https://github.com/apache/sling-feature-converter-maven-plugin/pull/1#issuecomment-704314231
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types
=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-feature-converter-maven-plugin] sonarcloud[bot] commented on pull request #1: SLING-9794 Content package artifacts found by maven plugin don't always have their 'file' attribute set
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #1:
URL: https://github.com/apache/sling-feature-converter-maven-plugin/pull/1#issuecomment-704518214
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types
=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-feature-converter-maven-plugin&pullRequest=1&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org