[jira] [Commented] (YARN-6169) container-executor message on empty configuration file can be improved

["Miklos Szegedi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860590#comment-15860590 ] 

Miklos Szegedi commented on YARN-6169:
--------------------------------------

It would also be nice to print some additional information in the following case:
{code}
  if (user_info->pw_uid < min_uid && !is_whitelisted(user)) {
    fprintf(LOGFILE, "Requested user %s is not whitelisted and has id %d,"
	    "which is below the minimum allowed %d\n", user, user_info->pw_uid, min_uid);
    fprintf(LOGFILE, "The allowed.system.users configuration entry can be used"
        " to whitelist a user");
    fflush(LOGFILE);
    free(user_info);
    return NULL;
  }
{code}

> container-executor message on empty configuration file can be improved
> ----------------------------------------------------------------------
>
>                 Key: YARN-6169
>                 URL: https://issues.apache.org/jira/browse/YARN-6169
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Miklos Szegedi
>            Priority: Trivial
>
> If the configuration file is empty, we get the following error message:
> {{Invalid configuration provided in /root/etc/hadoop/container-executor.cfg}}
> This is does not provide enough details to figure out what is the issue at the first glance. We should use something like 'Empty configuration file provided...'
> {code}
>   if (cfg->size == 0) {
>     fprintf(ERRORFILE, "Invalid configuration provided in %s\n", file_name);
>     exit(INVALID_CONFIG_FILE);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org