You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/16 07:55:00 UTC

[GitHub] [flink] klion26 opened a new pull request #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink dock

klion26 opened a new pull request #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink dock
URL: https://github.com/apache/flink/pull/10868
 
 
   ## What is the purpose of the change
   
   Sync the Chinese version doc of `StreamingFileSink`
   
   
   ## Verifying this change
   
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (yno)
     - The runtime per-record code paths (performance sensitive): ( no )
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no )
     - The S3 file system connector: ( no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink dock

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink dock
URL: https://github.com/apache/flink/pull/10868#issuecomment-575033614
 
 
   <!--
   Meta data
   Hash:6738a937a595abc0af8e89fe39b29d28bc96d44a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144685782 TriggerType:PUSH TriggerID:6738a937a595abc0af8e89fe39b29d28bc96d44a
   Hash:6738a937a595abc0af8e89fe39b29d28bc96d44a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4391 TriggerType:PUSH TriggerID:6738a937a595abc0af8e89fe39b29d28bc96d44a
   -->
   ## CI report:
   
   * 6738a937a595abc0af8e89fe39b29d28bc96d44a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144685782) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4391) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] klion26 commented on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink doc

Posted by GitBox <gi...@apache.org>.
klion26 commented on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink doc
URL: https://github.com/apache/flink/pull/10868#issuecomment-576264513
 
 
   @carp84 thanks for your review, addressed the comments

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink doc

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink doc
URL: https://github.com/apache/flink/pull/10868#issuecomment-575033614
 
 
   <!--
   Meta data
   Hash:6738a937a595abc0af8e89fe39b29d28bc96d44a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144685782 TriggerType:PUSH TriggerID:6738a937a595abc0af8e89fe39b29d28bc96d44a
   Hash:6738a937a595abc0af8e89fe39b29d28bc96d44a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4391 TriggerType:PUSH TriggerID:6738a937a595abc0af8e89fe39b29d28bc96d44a
   Hash:abd700f9c0fd57498cd5612bf41d72fb07bab4c6 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:abd700f9c0fd57498cd5612bf41d72fb07bab4c6
   -->
   ## CI report:
   
   * 6738a937a595abc0af8e89fe39b29d28bc96d44a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144685782) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4391) 
   * abd700f9c0fd57498cd5612bf41d72fb07bab4c6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink doc

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink doc
URL: https://github.com/apache/flink/pull/10868#issuecomment-575033614
 
 
   <!--
   Meta data
   Hash:6738a937a595abc0af8e89fe39b29d28bc96d44a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144685782 TriggerType:PUSH TriggerID:6738a937a595abc0af8e89fe39b29d28bc96d44a
   Hash:6738a937a595abc0af8e89fe39b29d28bc96d44a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4391 TriggerType:PUSH TriggerID:6738a937a595abc0af8e89fe39b29d28bc96d44a
   Hash:abd700f9c0fd57498cd5612bf41d72fb07bab4c6 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4505 TriggerType:PUSH TriggerID:abd700f9c0fd57498cd5612bf41d72fb07bab4c6
   Hash:abd700f9c0fd57498cd5612bf41d72fb07bab4c6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145218020 TriggerType:PUSH TriggerID:abd700f9c0fd57498cd5612bf41d72fb07bab4c6
   -->
   ## CI report:
   
   * 6738a937a595abc0af8e89fe39b29d28bc96d44a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144685782) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4391) 
   * abd700f9c0fd57498cd5612bf41d72fb07bab4c6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145218020) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4505) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink dock

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink dock
URL: https://github.com/apache/flink/pull/10868#issuecomment-575033614
 
 
   <!--
   Meta data
   Hash:6738a937a595abc0af8e89fe39b29d28bc96d44a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:6738a937a595abc0af8e89fe39b29d28bc96d44a
   -->
   ## CI report:
   
   * 6738a937a595abc0af8e89fe39b29d28bc96d44a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink dock

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink dock
URL: https://github.com/apache/flink/pull/10868#issuecomment-575029714
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 6738a937a595abc0af8e89fe39b29d28bc96d44a (Thu Jan 16 07:58:21 UTC 2020)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] carp84 commented on a change in pull request #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink doc

Posted by GitBox <gi...@apache.org>.
carp84 commented on a change in pull request #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink doc
URL: https://github.com/apache/flink/pull/10868#discussion_r368471961
 
 

 ##########
 File path: docs/dev/connectors/streamfile_sink.zh.md
 ##########
 @@ -28,99 +28,16 @@ under the License.
 
 这个连接器提供了一个 Sink 来将分区文件写入到支持 [Flink `FileSystem`]({{ site.baseurl}}/zh/ops/filesystems/index.html) 接口的文件系统中。
 
-为了处理无界的流数据，Streaming File Sink 会将数据写入到桶中。如何分桶是可以配置的，默认策略是基于时间的分桶，这种策略每个小时创建并写入一个新的桶，从而得到流数据在特定时间间隔内接收记录所对应的文件。
+Streaming File Sink 会将数据写入到桶中。由于输入流可能是无界的，因此每个桶中的数据被划分为多个有限大小的文件。如何分桶是可以配置的，默认使用基于时间的分桶策略，这种策略每个小时创建并写入一个新的桶，从而得到流数据在特定时间间隔内接收记录所对应的文件。
 
 Review comment:
   这种策略每个小时创建并写入一个新的桶，从而得到流数据在特定时间间隔内接收记录所对应的文件
   -> 这种策略每个小时创建一个新的桶，桶中包含的文件将记录所有该小时内从流中接收到的数据。

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] klion26 edited a comment on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink dock

Posted by GitBox <gi...@apache.org>.
klion26 edited a comment on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink dock
URL: https://github.com/apache/flink/pull/10868#issuecomment-575028797
 
 
   cc @carp84 @wuchong 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] carp84 merged pull request #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink doc

Posted by GitBox <gi...@apache.org>.
carp84 merged pull request #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink doc
URL: https://github.com/apache/flink/pull/10868
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] klion26 commented on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink dock

Posted by GitBox <gi...@apache.org>.
klion26 commented on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink dock
URL: https://github.com/apache/flink/pull/10868#issuecomment-575028797
 
 
   cc @carp84 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink dock

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10868: [FLINK-15278][docs-zh] Update Chinese version StreamingFileSink dock
URL: https://github.com/apache/flink/pull/10868#issuecomment-575033614
 
 
   <!--
   Meta data
   Hash:6738a937a595abc0af8e89fe39b29d28bc96d44a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144685782 TriggerType:PUSH TriggerID:6738a937a595abc0af8e89fe39b29d28bc96d44a
   Hash:6738a937a595abc0af8e89fe39b29d28bc96d44a Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4391 TriggerType:PUSH TriggerID:6738a937a595abc0af8e89fe39b29d28bc96d44a
   -->
   ## CI report:
   
   * 6738a937a595abc0af8e89fe39b29d28bc96d44a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144685782) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4391) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services