You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2022/08/30 23:22:34 UTC

[GitHub] [datasketches-cpp] AlexanderSaydakov opened a new pull request, #302: No class level serde

AlexanderSaydakov opened a new pull request, #302:
URL: https://github.com/apache/datasketches-cpp/pull/302

   removed serde from class template


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] AlexanderSaydakov commented on a diff in pull request #302: No class level serde

Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on code in PR #302:
URL: https://github.com/apache/datasketches-cpp/pull/302#discussion_r960175677


##########
sampling/include/var_opt_union_impl.hpp:
##########
@@ -201,7 +191,7 @@ var_opt_union<T,S,A> var_opt_union<T,S,A>::deserialize(const void* bytes, size_t
   bool is_empty = flags & EMPTY_FLAG_MASK;
 
   if (is_empty) {
-    return var_opt_union<T,S,A>(max_k);
+    return var_opt_union<T, A>(max_k);

Review Comment:
   right



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] jmalkin commented on a diff in pull request #302: No class level serde

Posted by GitBox <gi...@apache.org>.
jmalkin commented on code in PR #302:
URL: https://github.com/apache/datasketches-cpp/pull/302#discussion_r960116534


##########
sampling/include/var_opt_union_impl.hpp:
##########
@@ -201,7 +191,7 @@ var_opt_union<T,S,A> var_opt_union<T,S,A>::deserialize(const void* bytes, size_t
   bool is_empty = flags & EMPTY_FLAG_MASK;
 
   if (is_empty) {
-    return var_opt_union<T,S,A>(max_k);
+    return var_opt_union<T, A>(max_k);

Review Comment:
   probably don't need `<T,A>` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] coveralls commented on pull request #302: No class level serde

Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #302:
URL: https://github.com/apache/datasketches-cpp/pull/302#issuecomment-1232273624

   ## Pull Request Test Coverage Report for [Build 2960230317](https://coveralls.io/builds/52080524)
   
   * **13** of **13**   **(100.0%)**  changed or added relevant lines in **3** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **92.347%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/52080524/badge)](https://coveralls.io/builds/52080524) |
   | :-- | --: |
   | Change from base [Build 2951990696](https://coveralls.io/builds/52041630): |  0.0% |
   | Covered Lines: | 2196 |
   | Relevant Lines: | 2378 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] AlexanderSaydakov merged pull request #302: No class level serde

Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov merged PR #302:
URL: https://github.com/apache/datasketches-cpp/pull/302


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org