[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4125: Rewrite users/register to Go

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #4125: Rewrite users/register to Go
URL: https://github.com/apache/trafficcontrol/pull/4125#discussion_r348125763
 
 

 ##########
 File path: lib/go-tc/users.go
 ##########
 @@ -139,3 +143,27 @@ type UserDeliveryServiceDeleteResponse struct {
 type UserPasswordResetRequest struct {
 	Email rfc.EmailAddress `json:"email"`
 }
+
+// UserRegistrationRequest is the request submitted by operators when they want to register a new
+// user.
+type UserRegistrationRequest struct {
+	Email rfc.EmailAddress `json:"email"`
+	// Role - despite being named "Role" - is actually merely the *ID* of a Role to give the new user.
+	Role uint `json:"role"`
 
 Review comment:
   Maybe, maybe not. "RoleID" is certainly more appropriate, but "Role" is in keeping with the de facto standard of this_case in the database, ThisCase in struct fields, and thisCase in JSON.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services