You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by richard zhou <ri...@intel.com> on 2015/01/20 09:42:09 UTC
Review Request 30065: SQOOP2: Make getUserName function in
RequestContext support Kerberos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30065/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
SQOOP-2026
SQOOP2: Make getUserName function in RequestContext support Kerberos
Diffs
-----
client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java aa5fd3598bdbbba95b640bb51b9e01529feade04
server/src/main/java/org/apache/sqoop/server/RequestContext.java d0963f5bcd09a5f31601f677304165d513cc7de3
Diff: https://reviews.apache.org/r/30065/diff/
Testing
-------
local and integration test
Thanks,
richard zhou
Re: Review Request 30065: SQOOP2: Make getUserName function in
RequestContext support Kerberos
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30065/#review68851
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On Jan. 21, 2015, 2:35 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30065/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2015, 2:35 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> SQOOP-2026
> SQOOP2: Make getUserName function in RequestContext support Kerberos
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java aa5fd3598bdbbba95b640bb51b9e01529feade04
> server/src/main/java/org/apache/sqoop/server/RequestContext.java d0963f5bcd09a5f31601f677304165d513cc7de3
>
> Diff: https://reviews.apache.org/r/30065/diff/
>
>
> Testing
> -------
>
> local and integration test
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 30065: SQOOP2: Make getUserName function in
RequestContext support Kerberos
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30065/
-----------------------------------------------------------
(Updated Jan. 21, 2015, 2:35 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
SQOOP-2026
SQOOP2: Make getUserName function in RequestContext support Kerberos
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java aa5fd3598bdbbba95b640bb51b9e01529feade04
server/src/main/java/org/apache/sqoop/server/RequestContext.java d0963f5bcd09a5f31601f677304165d513cc7de3
Diff: https://reviews.apache.org/r/30065/diff/
Testing
-------
local and integration test
Thanks,
richard zhou
Re: Review Request 30065: SQOOP2: Make getUserName function in
RequestContext support Kerberos
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30065/
-----------------------------------------------------------
(Updated Jan. 21, 2015, 2:32 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
SQOOP-2026
SQOOP2: Make getUserName function in RequestContext support Kerberos
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java aa5fd3598bdbbba95b640bb51b9e01529feade04
server/src/main/java/org/apache/sqoop/server/RequestContext.java d0963f5bcd09a5f31601f677304165d513cc7de3
Diff: https://reviews.apache.org/r/30065/diff/
Testing
-------
local and integration test
Thanks,
richard zhou
Re: Review Request 30065: SQOOP2: Make getUserName function in
RequestContext support Kerberos
Posted by richard zhou <ri...@intel.com>.
> On Jan. 21, 2015, 2:23 a.m., Abraham Elmahrek wrote:
> > client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java, line 228
> > <https://reviews.apache.org/r/30065/diff/1/?file=826093#file826093line228>
> >
> > the user.name property is the system name I think. If the user has authenticated with Kerberos, it may not be the same as their system name. How about UGI.getShortUserName()?
Add comment to clarify this issue.
- richard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30065/#review68847
-----------------------------------------------------------
On Jan. 20, 2015, 8:42 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30065/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2015, 8:42 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> SQOOP-2026
> SQOOP2: Make getUserName function in RequestContext support Kerberos
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java aa5fd3598bdbbba95b640bb51b9e01529feade04
> server/src/main/java/org/apache/sqoop/server/RequestContext.java d0963f5bcd09a5f31601f677304165d513cc7de3
>
> Diff: https://reviews.apache.org/r/30065/diff/
>
>
> Testing
> -------
>
> local and integration test
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 30065: SQOOP2: Make getUserName function in
RequestContext support Kerberos
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30065/#review68847
-----------------------------------------------------------
client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java
<https://reviews.apache.org/r/30065/#comment113342>
the user.name property is the system name I think. If the user has authenticated with Kerberos, it may not be the same as their system name. How about UGI.getShortUserName()?
server/src/main/java/org/apache/sqoop/server/RequestContext.java
<https://reviews.apache.org/r/30065/#comment113343>
space
- Abraham Elmahrek
On Jan. 20, 2015, 8:42 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30065/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2015, 8:42 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> SQOOP-2026
> SQOOP2: Make getUserName function in RequestContext support Kerberos
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java aa5fd3598bdbbba95b640bb51b9e01529feade04
> server/src/main/java/org/apache/sqoop/server/RequestContext.java d0963f5bcd09a5f31601f677304165d513cc7de3
>
> Diff: https://reviews.apache.org/r/30065/diff/
>
>
> Testing
> -------
>
> local and integration test
>
>
> Thanks,
>
> richard zhou
>
>