You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2016/09/13 22:47:34 UTC
[kudu-CR] Set desiredBlockSize in pbToColumnSchema
Will Berkeley has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4407
Change subject: Set desiredBlockSize in pbToColumnSchema
......................................................................
Set desiredBlockSize in pbToColumnSchema
pbToColumnSchema forgets to set desiredBlockSize; this fixes
it.
Change-Id: I918a483b6e4bf84db6e6d97e47768f999f6ab880
---
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/4407/1
--
To view, visit http://gerrit.cloudera.org:8080/4407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I918a483b6e4bf84db6e6d97e47768f999f6ab880
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] Set desiredBlockSize in pbToColumnSchema
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Set desiredBlockSize in pbToColumnSchema
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/3412/
--
To view, visit http://gerrit.cloudera.org:8080/4407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I918a483b6e4bf84db6e6d97e47768f999f6ab880
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Set desiredBlockSize in pbToColumnSchema
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Set desiredBlockSize in pbToColumnSchema
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4407/2//COMMIT_MSG
Commit Message:
Line 7: Set desiredBlockSize in pbToColumnSchema
In the future, can you prefix with [java client]? Helps triaging reviews.
--
To view, visit http://gerrit.cloudera.org:8080/4407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I918a483b6e4bf84db6e6d97e47768f999f6ab880
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Set desiredBlockSize in pbToColumnSchema
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Set desiredBlockSize in pbToColumnSchema
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3406/
--
To view, visit http://gerrit.cloudera.org:8080/4407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I918a483b6e4bf84db6e6d97e47768f999f6ab880
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Set desiredBlockSize in pbToColumnSchema
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: Set desiredBlockSize in pbToColumnSchema
......................................................................
Set desiredBlockSize in pbToColumnSchema
pbToColumnSchema forgets to set desiredBlockSize; this fixes
it.
Change-Id: I918a483b6e4bf84db6e6d97e47768f999f6ab880
Reviewed-on: http://gerrit.cloudera.org:8080/4407
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I918a483b6e4bf84db6e6d97e47768f999f6ab880
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Set desiredBlockSize in pbToColumnSchema
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: Set desiredBlockSize in pbToColumnSchema
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4407/2//COMMIT_MSG
Commit Message:
Line 7: Set desiredBlockSize in pbToColumnSchema
> In the future, can you prefix with [java client]? Helps triaging reviews.
No probs.
--
To view, visit http://gerrit.cloudera.org:8080/4407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I918a483b6e4bf84db6e6d97e47768f999f6ab880
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes