[GitHub] avro pull request #118: AVRO-1891: Fix specific nested logical types

[rdblue <gi...@git.apache.org>]

GitHub user rdblue opened a pull request:

    https://github.com/apache/avro/pull/118

    AVRO-1891: Fix specific nested logical types

    This changes the datum readers to use `getConversionFor` and `getConversionByClass` instance methods that delegate to the data models. This allows specific to use a set of conversions determined by the current record class to pick up the conversions that were present when it was compiled.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rdblue/avro AVRO-1891-fix-specific-nested-logical-types

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #118
    
----
commit 6c04cb3f3daec9e87e49d440faa35a248767fb3b
Author: Ryan Blue <bl...@apache.org>
Date:   2016-09-04T21:54:40Z

    AVRO-1908: Fix TestSpecificCompiler reference to private method.
    
    AVRO-1884 changed makePath to a private method from a package-private
    static method. This broke the test that references the method in IPC.
    The fix is to make the instance method package-private and update the
    test to use an instance of SpecificCompiler.

commit 31be7fa9d4589e7553d274d089aa3bf97c0297b3
Author: Ryan Blue <bl...@apache.org>
Date:   2016-09-05T19:15:09Z

    AVRO-1891: Add conversion getters to datum readers.
    
    This adds getConversionFor and getConversionByClass to
    GenericDatumReader so that SpecificDatumReader can override them to
    resolve conversions using the set of conversions used when a specific
    class was compiled, determined by the CONVERSIONS static variable or by
    adding the conversions for each field returned by getConversion(String).

commit cf5bff3b6f7d312a65c28dbb053e6dbb6ab61c58
Author: Ryan Blue <bl...@apache.org>
Date:   2016-09-05T19:44:13Z

    AVRO-1891: Java: Add converions to compiled specific records.
    
    This adds a CONVERSIONS static field with the converisons that the
    specific compiler used to produce a record. Together with the last
    commit, this will enable new specific classes to use nested logical
    types.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---