You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/02 10:21:27 UTC
[GitHub] [airflow] uranusjr opened a new pull request #17376: Remove /dagrun/create and /dagrun/edit generated by F.A.B
uranusjr opened a new pull request #17376:
URL: https://github.com/apache/airflow/pull/17376
This came up during a conversaion with @ashb. Currently we are exposing the ability to directly create and edit a DagRun instance via F.A.B.’s CRUD view generation (the plus and edit icons on the DagRun list view). But these views don’t really make a lot of sense; creating a DagRun requires doing more than just adding a DagRun instance to the database (which is why triggering a DAG run in the home view uses `/trigger` instead). The `/dagrun/add` view provides essentially a way to manually modify Airflow’s internal state.
The story with `/dagrun/edit` is similar. The only thing on a DagRun that can be reasonably edited is the state (running, failed, skipped, etc.), but that should also do more things than just setting the state, which is why we have *Mark Failed*, *Mark Success*, and *Clear* action buttons. So these two are removed, along with a bunch of stuff only they used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17376: Remove /dagrun/create and /dagrun/edit generated by F.A.B
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17376:
URL: https://github.com/apache/airflow/pull/17376#issuecomment-891093903
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17376: Remove /dagrun/create and /dagrun/edit generated by F.A.B
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17376:
URL: https://github.com/apache/airflow/pull/17376#issuecomment-891111077
Grr, so it seems F.A.B. does not allow disabling the edit form as long as there is an action that uses the edit permission (wtf). So we need to jump through some hoops for this. One workaround I can think of is to keep the edit view, but make all fields readonly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #17376: Remove /dagrun/create and disable /dagrun/edit generated by F.A.B
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #17376:
URL: https://github.com/apache/airflow/pull/17376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17376: Remove /dagrun/create and /dagrun/edit generated by F.A.B
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17376:
URL: https://github.com/apache/airflow/pull/17376#issuecomment-891162346
OK, maybe this is good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org