You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/29 20:01:59 UTC

[GitHub] [superset] lyndsiWilliams opened a new pull request #15463: fix: Database connection modal touch up

lyndsiWilliams opened a new pull request #15463:
URL: https://github.com/apache/superset/pull/15463


   ### SUMMARY
   Touched up the code as per comments in the [Database Connection UI PR](https://github.com/apache/superset/pull/14881).
   
   - Removed unnecessary TODO and named the remaining ones
   - Added translation functionality to text lines
   
   ### TESTING INSTRUCTIONS
   Observe the code changes in the current files, as compared to the comments in the [Database Connection UI PR](https://github.com/apache/superset/pull/14881).
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] hughhhh merged pull request #15463: fix: Database connection modal touch up

Posted by GitBox <gi...@apache.org>.
hughhhh merged pull request #15463:
URL: https://github.com/apache/superset/pull/15463


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org