You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/16 17:56:00 UTC
[jira] [Commented] (FLINK-7442) Add option for using a child-first
classloader for loading user code
[ https://issues.apache.org/jira/browse/FLINK-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129158#comment-16129158 ]
ASF GitHub Bot commented on FLINK-7442:
---------------------------------------
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/4554
[FLINK-7442] Add option for using child-first classloader for loading user code
## What is the purpose of the change
This PR introduces a new core option (`classloader.resolve-order: child-first`) that allows using a child-first class loader for user code. The default is still to use a parent-first class loader.
This also does a minor refactoring in the way the blob manager retrieves the cleanup interval. It's now also read from the `Configuration`, since we already have the `Configuration` for the class loader settings.
## Brief change log
- Introduce new option
- Pass `Configuration` thought to all places where we previously created a user class loader
- Instantiate correct class loader based on config
## Verifying this change
This PR introduces new end-to-end tests that verify the new feature in a complete Flink workflow, including starting the program using `bin/flink run`.
## Does this pull request potentially affect one of the following parts:
This affects class loader, which is quite important to get right.
## Documentation
- the new flag is documented in the config documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink jira-7441-child-first-classloader
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4554.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4554
----
commit 23405759ec0578060a8a91beb4fbab12e5578607
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2017-08-14T12:53:14Z
[FLINK-7442] Add option for using a child-first classloader for loading user code
commit 61a1482baf3c36b939fa5befd08b96edf82a0d95
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2017-08-16T11:28:32Z
Add end-to-end tests
----
> Add option for using a child-first classloader for loading user code
> --------------------------------------------------------------------
>
> Key: FLINK-7442
> URL: https://issues.apache.org/jira/browse/FLINK-7442
> Project: Flink
> Issue Type: Improvement
> Components: Local Runtime
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)