[GitHub] [flink] xintongsong commented on a change in pull request #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance.

[GitBox <gi...@apache.org>]

xintongsong commented on a change in pull request #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance.
URL: https://github.com/apache/flink/pull/9105#discussion_r304699498
 
 

 ##########
 File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnConfigurationITCase.java
 ##########
 @@ -187,6 +191,12 @@ public void testFlinkContainerMemory() throws Exception {
 					assertThat(
 						(double) taskManagerInfo.getHardwareDescription().getSizeOfJvmHeap() / (double) expectedHeadSize,
 						is(closeTo(1.0, 0.15)));
+
+					final int defaultTaskManagerMemoryMB = ConfigurationUtils.getTaskManagerHeapMemory(configuration).getMebiBytes();
 
 Review comment:
   I kind of think it differently. 
   I think we already have `testCreateSlotsPerWorker` that checks the behavior of `updateTaskManagerConfigAndCreateWorkerSlotProfiles`. If we just set constant `defaultTaskManagerMemoryMB` and expect a corresponding constant `expectedManagedMemoryMB`, then later if we change the logic in `updateTaskManagerConfigAndCreateWorkerSlotProfiles `  that it calculates managed memory from task manager memory differently, we may have to also change this test case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services