You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bu...@apache.org on 2010/10/25 00:08:18 UTC

DO NOT REPLY [Bug 50149] New: [PATCH] support the javah task in gcj/gij

https://issues.apache.org/bugzilla/show_bug.cgi?id=50149

           Summary: [PATCH] support the javah task in gcj/gij
           Product: Ant
           Version: 1.8.1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Core tasks
        AssignedTo: notifications@ant.apache.org
        ReportedBy: bero@arklinux.org


Created an attachment (id=26208)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26208)
Add support for gcj/gij javah

Currently, ant doesn't support the javah task when used with the GNU gcj/gij
VM.

Adding support for this is fairly simple (gcjh works pretty much like kaffeh
which is supported).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50149] [PATCH] support the javah task in gcj/gij

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50149

--- Comment #3 from Stefan Bodewig <bo...@apache.org> 2010-10-25 06:30:22 EDT ---
thanks

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50149] [PATCH] support the javah task in gcj/gij

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50149

Stefan Bodewig <bo...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |1.8.2
           Severity|normal                      |enhancement

--- Comment #1 from Stefan Bodewig <bo...@apache.org> 2010-10-25 06:15:27 EDT ---
Thanks Bernhard, I've committed a modified patch in svn revision 1027025

The modifications:

(1) use isGij() as method name rather than isGnu() since GNU looked too generic
    to me.  Then again I don't know much and am open to get educated why
    isGnu would be the better choice ;-)

(2) testing for GIJ after Kaffee in JavahAdapterFactory to make the diff
    smaller - shouldn't have any functional impact.

(3) kept the build.sysclasspath handling of Kaffeeh - you won't notice
    any difference unless anybody sets the build.sysclasspath property.

(4) removed the @since Ark Linux ... line

If you disagree with any of the changes, please speak up.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50149] [PATCH] support the javah task in gcj/gij

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50149

--- Comment #2 from Bernhard Rosenkraenzer <be...@arklinux.org> 2010-10-25 06:23:29 EDT ---
The changes are ok with me -- my original reasoning for using isGnu as opposed
to isGij is that the same thing is used for both Gij and Gcj, but I guess
anyone using gcj/gij will know they're the same in terms of source
compatibility anyway.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.