You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/14 15:00:24 UTC
[GitHub] [arrow-rs] viirya opened a new pull request, #1878: Fix memory leak in ffi_stream test
viirya opened a new pull request, #1878:
URL: https://github.com/apache/arrow-rs/pull/1878
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1872.
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Verified by `cargo +nightly miri test -p arrow -- --skip csv --skip ipc --skip json --skip util --skip compute --skip array --skip buffer --skip datatypes --skip ffi --skip record_batch --skip tensor`
# What changes are included in this PR?
<!---
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1878: Fix memory leak in ffi_stream test
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1878:
URL: https://github.com/apache/arrow-rs/pull/1878#issuecomment-1155457719
Oh, I skip array::xxx. There are a few ffi tests under array:: module too. Let me look at them. Thanks @jhorstmann
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on pull request #1878: Fix memory leak in ffi_stream test
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on PR #1878:
URL: https://github.com/apache/arrow-rs/pull/1878#issuecomment-1155360101
Tried to reproduce the miri report and I see still some leaks related to `test_round_trip` in `array::ffi::tests`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on pull request #1878: Fix memory leak in ffi_stream test
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on PR #1878:
URL: https://github.com/apache/arrow-rs/pull/1878#issuecomment-1155448011
> How to reproduce it?
I did run
```
cargo +nightly miri test -p arrow -- --skip csv --skip ipc --skip json
```
or
```
cargo +nightly miri test -p arrow -- --skip csv --skip ipc --skip json -- array::ffi::tests::test_u32
```
for one specific test. Only difference to your command line is fewer `skip` parameters :)
CI looks like it passed because of #1873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1878: Fix memory leak in ffi_stream test
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1878:
URL: https://github.com/apache/arrow-rs/pull/1878#issuecomment-1155313253
cc @sunchao @jhorstmann
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1878: Fix memory leak in ffi_stream test
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1878:
URL: https://github.com/apache/arrow-rs/pull/1878#issuecomment-1155372254
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1878?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1878](https://codecov.io/gh/apache/arrow-rs/pull/1878?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5397126) into [master](https://codecov.io/gh/apache/arrow-rs/commit/cedaf8a6ab55826c34f3b1bc9a21dbaf3e0328bc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cedaf8a) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #1878 +/- ##
==========================================
- Coverage 83.46% 83.46% -0.01%
==========================================
Files 201 201
Lines 57014 57016 +2
==========================================
+ Hits 47586 47587 +1
- Misses 9428 9429 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1878?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/1878/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2ZmaS5ycw==) | `86.97% <ø> (ø)` | |
| [arrow/src/ffi\_stream.rs](https://codecov.io/gh/apache/arrow-rs/pull/1878/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2ZmaV9zdHJlYW0ucnM=) | `79.89% <100.00%> (+0.22%)` | :arrow_up: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1878/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.98% <0.00%> (-0.23%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1878?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1878?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cedaf8a...5397126](https://codecov.io/gh/apache/arrow-rs/pull/1878?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1878: Fix memory leak in ffi_stream test
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1878:
URL: https://github.com/apache/arrow-rs/pull/1878#issuecomment-1155460185
@jhorstmann Fixed them and verified by `cargo +nightly miri test -p arrow -- --skip csv --skip ipc --skip json -- array::ffi::tests`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1878: Fix memory leak in ffi test
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1878:
URL: https://github.com/apache/arrow-rs/pull/1878#issuecomment-1155528017
Thanks @sunchao @jhorstmann
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on pull request #1878: Fix memory leak in ffi test
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on PR #1878:
URL: https://github.com/apache/arrow-rs/pull/1878#issuecomment-1155501922
Nice, can confirm that miri is happy with that change! I'm not that familiar with the ffi api, that `ArrowArray::try_from_raw` does not take ownership of the Arcs feels a bit asymmetric with the `into_raw` method, but this seems to be intentional from the discussion in #1449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1878: Fix memory leak in ffi_stream test
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1878:
URL: https://github.com/apache/arrow-rs/pull/1878#issuecomment-1155402756
> Tried to reproduce the miri report and I see still some leaks related to `test_round_trip` in `array::ffi::tests`.
How to reproduce it? I ran `cargo +nightly miri test -p arrow -- --skip csv --skip ipc --skip json --skip util --skip compute --skip array --skip buffer --skip datatypes --skip bitmap --skip record_batch --skip tensor` and got all tests passed without leaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya merged pull request #1878: Fix memory leak in ffi test
Posted by GitBox <gi...@apache.org>.
viirya merged PR #1878:
URL: https://github.com/apache/arrow-rs/pull/1878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org