You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2013/03/08 16:53:52 UTC

Review Request: fix occasional hang in pn_messenger_stop()

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9825/
-----------------------------------------------------------

Review request for qpid and Rafael Schloming.


Description
-------

Fixes messenger to add check of endpoint state before processing the connection.  Fix provided by Rafi.


This addresses bug proton-268.
    https://issues.apache.org/jira/browse/proton-268


Diffs
-----

  /proton/trunk/proton-c/src/messenger.c 1454051 
  /proton/trunk/tests/python/proton_tests/messenger.py 1454051 

Diff: https://reviews.apache.org/r/9825/diff/


Testing
-------

new unit test added - passes for proton-c, -j, -jni tests


Thanks,

Kenneth Giusti

Re: Review Request: fix occasional hang in pn_messenger_stop()

Posted by Rafael Schloming <rh...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9825/#review17611
-----------------------------------------------------------

Ship it!


Ship It!

- Rafael Schloming


On March 8, 2013, 3:53 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9825/
> -----------------------------------------------------------
> 
> (Updated March 8, 2013, 3:53 p.m.)
> 
> 
> Review request for qpid and Rafael Schloming.
> 
> 
> Description
> -------
> 
> Fixes messenger to add check of endpoint state before processing the connection.  Fix provided by Rafi.
> 
> 
> This addresses bug proton-268.
>     https://issues.apache.org/jira/browse/proton-268
> 
> 
> Diffs
> -----
> 
>   /proton/trunk/proton-c/src/messenger.c 1454051 
>   /proton/trunk/tests/python/proton_tests/messenger.py 1454051 
> 
> Diff: https://reviews.apache.org/r/9825/diff/
> 
> 
> Testing
> -------
> 
> new unit test added - passes for proton-c, -j, -jni tests
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>