You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/28 06:23:26 UTC
[GitHub] [doris] HappenLee opened a new pull request, #10467: [Bug][Vectorized] Support array function in where pre in volap_scan_node
HappenLee opened a new pull request, #10467:
URL: https://github.com/apache/doris/pull/10467
# Proposed changes
Issue Number: close #10388
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10467: [Bug][Vectorized] Support array function in where pre in volap_scan_node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10467:
URL: https://github.com/apache/doris/pull/10467#issuecomment-1176140078
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on pull request #10467: [Bug][Vectorized] Support array function in where pre in volap_scan_node
Posted by GitBox <gi...@apache.org>.
cambyzju commented on PR #10467:
URL: https://github.com/apache/doris/pull/10467#issuecomment-1168613682
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #10467: [Bug][Vectorized] Support array function in where pre in volap_scan_node
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt merged PR #10467:
URL: https://github.com/apache/doris/pull/10467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yinzhijian commented on a diff in pull request #10467: [Bug][Vectorized] Support array function in where pre in volap_scan_node
Posted by GitBox <gi...@apache.org>.
yinzhijian commented on code in PR #10467:
URL: https://github.com/apache/doris/pull/10467#discussion_r909599132
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##########
@@ -1263,6 +1263,11 @@ public void addScalarAndVectorizedBuiltin(String fnName, String symbol, boolean
boolean varArgs, Type ... args) {
ArrayList<Type> argsType = new ArrayList<Type>();
for (Type type : args) {
+ // only to prevent olap scan node use array expr to find a fake symbol
+ // TODO: delete the code after we remove origin exec engine
+ if (type.isArrayType()) {
+ symbol = "_ZN5doris19array_fake_fucntionEPN9doris_udf15FunctionContextE";
Review Comment:
array_fake_function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yinzhijian commented on a diff in pull request #10467: [Bug][Vectorized] Support array function in where pre in volap_scan_node
Posted by GitBox <gi...@apache.org>.
yinzhijian commented on code in PR #10467:
URL: https://github.com/apache/doris/pull/10467#discussion_r909598103
##########
be/src/exprs/array_functions.cpp:
##########
@@ -41,4 +41,8 @@ void ArrayFunctions::init() {}
ARRAY_FUNCTION(IntVal, TYPE_INT);
ARRAY_FUNCTION(StringVal, TYPE_VARCHAR);
+doris_udf::AnyVal array_fake_fucntion(FunctionContext* context) {
Review Comment:
```suggestion
doris_udf::AnyVal array_fake_function(FunctionContext* context) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on pull request #10467: [Bug][Vectorized] Support array function in where pre in volap_scan_node
Posted by GitBox <gi...@apache.org>.
eldenmoon commented on PR #10467:
URL: https://github.com/apache/doris/pull/10467#issuecomment-1169490530
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yinzhijian commented on a diff in pull request #10467: [Bug][Vectorized] Support array function in where pre in volap_scan_node
Posted by GitBox <gi...@apache.org>.
yinzhijian commented on code in PR #10467:
URL: https://github.com/apache/doris/pull/10467#discussion_r909598346
##########
be/src/exprs/array_functions.h:
##########
@@ -32,4 +32,6 @@ class ArrayFunctions {
static CollectionVal array(FunctionContext* context, int num_children, const StringVal* values);
};
+
+doris_udf::AnyVal array_fake_fucntion(FunctionContext* context);
Review Comment:
array_fake_function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10467: [Bug][Vectorized] Support array function in where pre in volap_scan_node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10467:
URL: https://github.com/apache/doris/pull/10467#issuecomment-1176140029
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org