You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "James Wheare (JIRA)" <ji...@apache.org> on 2008/10/22 13:54:44 UTC
[jira] Created: (THRIFT-180) [PATCH] Throw TTransportException
instead of TException in TSocket.php
[PATCH] Throw TTransportException instead of TException in TSocket.php
----------------------------------------------------------------------
Key: THRIFT-180
URL: https://issues.apache.org/jira/browse/THRIFT-180
Project: Thrift
Issue Type: Improvement
Components: Library (PHP)
Reporter: James Wheare
Priority: Trivial
Attachments: TSocket.php.diff
In our use of the thrift PHP libs, it's been useful to have TSocket throw TTransportException instead of plain TException so we can catch socket exceptions separately from other thrift errors. Attached is a simple patch that also makes use of the TTransportException error constants.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-180) [PATCH] Throw TTransportException
instead of TException in TSocket.php
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-180:
---------------------------------
Patch Info: (was: [Patch Available])
This patch doesn't apply cleanly anymore.
> [PATCH] Throw TTransportException instead of TException in TSocket.php
> ----------------------------------------------------------------------
>
> Key: THRIFT-180
> URL: https://issues.apache.org/jira/browse/THRIFT-180
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Reporter: James Wheare
> Priority: Trivial
> Attachments: TSocket.php.patch
>
>
> In our use of the thrift PHP libs, it's been useful to have TSocket throw TTransportException instead of plain TException so we can catch socket exceptions separately from other thrift errors. Attached is a simple patch that also makes use of the TTransportException error constants.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-180) [PATCH] Throw TTransportException
instead of TException in TSocket.php
Posted by "James Wheare (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Wheare updated THRIFT-180:
--------------------------------
Attachment: TSocket.php.patch
Better patch that matches whitespace conventions and also improves stream handle exceptions in write operations. It first checks if the stream handle is still an open resource before trying to get metadata and also throws a TTransportException::END_OF_FILE on EOF.
> [PATCH] Throw TTransportException instead of TException in TSocket.php
> ----------------------------------------------------------------------
>
> Key: THRIFT-180
> URL: https://issues.apache.org/jira/browse/THRIFT-180
> Project: Thrift
> Issue Type: Improvement
> Components: Library (PHP)
> Reporter: James Wheare
> Priority: Trivial
> Attachments: TSocket.php.patch
>
>
> In our use of the thrift PHP libs, it's been useful to have TSocket throw TTransportException instead of plain TException so we can catch socket exceptions separately from other thrift errors. Attached is a simple patch that also makes use of the TTransportException error constants.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-180) [PATCH] Throw TTransportException
instead of TException in TSocket.php
Posted by "James Wheare (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Wheare updated THRIFT-180:
--------------------------------
Attachment: TSocket.php.diff
> [PATCH] Throw TTransportException instead of TException in TSocket.php
> ----------------------------------------------------------------------
>
> Key: THRIFT-180
> URL: https://issues.apache.org/jira/browse/THRIFT-180
> Project: Thrift
> Issue Type: Improvement
> Components: Library (PHP)
> Reporter: James Wheare
> Priority: Trivial
> Attachments: TSocket.php.diff
>
>
> In our use of the thrift PHP libs, it's been useful to have TSocket throw TTransportException instead of plain TException so we can catch socket exceptions separately from other thrift errors. Attached is a simple patch that also makes use of the TTransportException error constants.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-180) [PATCH] Throw TTransportException
instead of TException in TSocket.php
Posted by "James Wheare (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Wheare updated THRIFT-180:
--------------------------------
Comment: was deleted
> [PATCH] Throw TTransportException instead of TException in TSocket.php
> ----------------------------------------------------------------------
>
> Key: THRIFT-180
> URL: https://issues.apache.org/jira/browse/THRIFT-180
> Project: Thrift
> Issue Type: Improvement
> Components: Library (PHP)
> Reporter: James Wheare
> Priority: Trivial
> Attachments: TSocket.php.patch
>
>
> In our use of the thrift PHP libs, it's been useful to have TSocket throw TTransportException instead of plain TException so we can catch socket exceptions separately from other thrift errors. Attached is a simple patch that also makes use of the TTransportException error constants.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-180) [PATCH] Throw TTransportException
instead of TException in TSocket.php
Posted by "James Wheare (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Wheare updated THRIFT-180:
--------------------------------
Attachment: TSocket.php.patch
Better extension
> [PATCH] Throw TTransportException instead of TException in TSocket.php
> ----------------------------------------------------------------------
>
> Key: THRIFT-180
> URL: https://issues.apache.org/jira/browse/THRIFT-180
> Project: Thrift
> Issue Type: Improvement
> Components: Library (PHP)
> Reporter: James Wheare
> Priority: Trivial
> Attachments: TSocket.php.patch
>
>
> In our use of the thrift PHP libs, it's been useful to have TSocket throw TTransportException instead of plain TException so we can catch socket exceptions separately from other thrift errors. Attached is a simple patch that also makes use of the TTransportException error constants.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-180) [PATCH] Throw TTransportException
instead of TException in TSocket.php
Posted by "James Wheare (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Wheare updated THRIFT-180:
--------------------------------
Attachment: (was: TSocket.php.diff)
> [PATCH] Throw TTransportException instead of TException in TSocket.php
> ----------------------------------------------------------------------
>
> Key: THRIFT-180
> URL: https://issues.apache.org/jira/browse/THRIFT-180
> Project: Thrift
> Issue Type: Improvement
> Components: Library (PHP)
> Reporter: James Wheare
> Priority: Trivial
> Attachments: TSocket.php.patch
>
>
> In our use of the thrift PHP libs, it's been useful to have TSocket throw TTransportException instead of plain TException so we can catch socket exceptions separately from other thrift errors. Attached is a simple patch that also makes use of the TTransportException error constants.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-180) [PATCH] Throw TTransportException
instead of TException in TSocket.php
Posted by "James Wheare (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Wheare updated THRIFT-180:
--------------------------------
Attachment: (was: TSocket.php.patch)
> [PATCH] Throw TTransportException instead of TException in TSocket.php
> ----------------------------------------------------------------------
>
> Key: THRIFT-180
> URL: https://issues.apache.org/jira/browse/THRIFT-180
> Project: Thrift
> Issue Type: Improvement
> Components: Library (PHP)
> Reporter: James Wheare
> Priority: Trivial
> Attachments: TSocket.php.patch
>
>
> In our use of the thrift PHP libs, it's been useful to have TSocket throw TTransportException instead of plain TException so we can catch socket exceptions separately from other thrift errors. Attached is a simple patch that also makes use of the TTransportException error constants.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.