[jira] Commented: (SHINDIG-269) package all features in a single jar, load from classpath

["Chris Chabot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597272#action_12597272 ] 

Chris Chabot commented on SHINDIG-269:
--------------------------------------

> In the long run, it might be good to move the features out of the root directory and into e.g. src/javascript

The javascript directory contains mostly just javascript sample files, not stuff that's really required by shindig, putting features in them would be slightly confusing .. plus  I can't say how the java side deals with this, but on the PHP side the /gadgets/files/* files are served directly from the <shindig_root>/javascript directory. So if you would put the features there, you could access them directly through /gadgets/files/features/<something>, probably not something we want :)

All in all, leave the features where they are I'd say 



> package all features in a single jar, load from classpath
> ---------------------------------------------------------
>
>                 Key: SHINDIG-269
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-269
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Features (Javascript), Gadget Rendering Server (Java)
>            Reporter: Henning Schmiedehausen
>         Attachments: javascript-jar.patch
>
>
> The attached patch creates a Maven project for the features directory. This allows automatic packaging up of the features into a single jar, which then can be placed on the classpath for the gadget server and the demo container. 
> This removes the need for the various javascript related plugins from the gadget rendering server and also a number of the cross-project linking and copying. The features directory itself is not modified, so the PHP version should still run fine. 
> In the long run, it might be good to move the features out of the root directory and into e.g. src/javascript to allow better control of the jar creation. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.