[GitHub] [airflow] potiuk commented on pull request #17141: ECSOperator / pass context to self.xcom_pull as it was missing (when using reattach)

[GitBox <gi...@apache.org>]

potiuk commented on pull request #17141:
URL: https://github.com/apache/airflow/pull/17141#issuecomment-884366770


   > Nice catch, shows how easily mocking in tests can be fraught (i.e. in this case missing the assert that context was provided). 
   
   It's not very well understood concept but unit tests do not replace manual tests, not even are a proof that things are right. They are there mostly to make sure that behaviour have not changed and is the same as before (so prevent regression). And having unit tests written at all (whether they are correct or not) makes it simply easier to fix things and re-run tests after we find and fix problems (and fix test afterwards :)).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org