You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/09/29 06:17:32 UTC

[GitHub] [incubator-kvrocks] caipengbo opened a new pull request, #930: Make the semantics of TYPE and SCAN commands consistent with Redis

caipengbo opened a new pull request, #930:
URL: https://github.com/apache/incubator-kvrocks/pull/930

   fixed #928 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] tisonkun closed pull request #930: Make the semantics of TYPE and SCAN commands consistent with Redis

Posted by GitBox <gi...@apache.org>.
tisonkun closed pull request #930: Make the semantics of TYPE and SCAN commands consistent with Redis
URL: https://github.com/apache/incubator-kvrocks/pull/930


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] caipengbo commented on pull request #930: Make the semantics of TYPE and SCAN commands consistent with Redis

Posted by GitBox <gi...@apache.org>.
caipengbo commented on PR #930:
URL: https://github.com/apache/incubator-kvrocks/pull/930#issuecomment-1261841112

   > @caipengbo Can you add some tests for this fix?
   
    I'll add test cases as soon as possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on pull request #930: Make the semantics of TYPE and SCAN commands consistent with Redis

Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #930:
URL: https://github.com/apache/incubator-kvrocks/pull/930#issuecomment-1261818976

   @caipengbo Can you add some tests for this fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on pull request #930: Make the semantics of TYPE and SCAN commands consistent with Redis

Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #930:
URL: https://github.com/apache/incubator-kvrocks/pull/930#issuecomment-1261844222

   > > @caipengbo Can you add some tests for this fix?
   > 
   > I'll add test cases as soon as possible.
   
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] caipengbo commented on pull request #930: Make the semantics of TYPE and SCAN commands consistent with Redis

Posted by GitBox <gi...@apache.org>.
caipengbo commented on PR #930:
URL: https://github.com/apache/incubator-kvrocks/pull/930#issuecomment-1283459692

   Sorry, I have been delayed by some things. I will do it as soon as possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] tisonkun commented on pull request #930: Make the semantics of TYPE and SCAN commands consistent with Redis

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #930:
URL: https://github.com/apache/incubator-kvrocks/pull/930#issuecomment-1306843290

   Closed as conflict and no response for a while.
   
   @caipengbo you're welcome to rebase the patch and add test cases so that we revive this pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] tisonkun commented on pull request #930: Make the semantics of TYPE and SCAN commands consistent with Redis

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #930:
URL: https://github.com/apache/incubator-kvrocks/pull/930#issuecomment-1283428386

   @caipengbo could you add test cases and rebase this patch onto master? I think it's almost good to merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org