[jira] [Commented] (HIVE-20238) Remove stringifyException Method

["Hive QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-20238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957522#comment-16957522 ] 

Hive QA commented on HIVE-20238:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983753/HIVE-20238.8.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19118/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19118/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19118/

Messages:
{noformat}
**** This message was trimmed, see log for full details ****
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/ReplCopyTask.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/ReplTxnTask.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkReduceRecordHandler.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/LocalSparkJobMonitor.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/RemoteSparkJobMonitor.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MapRecordSource.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MergeFileRecordProcessor.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordSource.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezProcessor.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryImpl.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/hooks/LineageLogger.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/io/merge/MergeFileTask.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateTask.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/SimpleFetchOptimizer.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/processors/DfsProcessor.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsNoJobTask.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/stats/ColStatsProcessor.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVariance.java: does not exist in index
error: a/ql/src/test/org/apache/hadoop/hive/metastore/TestMetastoreExpr.java: does not exist in index
error: a/ql/src/test/org/apache/hadoop/hive/metastore/txn/TestTxnHandler.java: does not exist in index
error: a/ql/src/test/org/apache/hadoop/hive/ql/exec/TestMsckCreatePartitionsInBatches.java: does not exist in index
error: a/ql/src/test/org/apache/hadoop/hive/ql/exec/TestMsckDropPartitionsInBatches.java: does not exist in index
error: a/ql/src/test/org/apache/hadoop/hive/ql/exec/spark/session/TestSparkSessionManagerImpl.java: does not exist in index
error: a/ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java: does not exist in index
error: a/ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveRemote.java: does not exist in index
error: a/ql/src/test/results/clientnegative/authorization_disallow_transform.q.out: does not exist in index
error: a/ql/src/test/results/clientnegative/bad_exec_hooks.q.out: does not exist in index
error: a/ql/src/test/results/clientnegative/fallbackauth_disallow_transform.q.out: does not exist in index
error: a/ql/src/test/results/clientnegative/stats_aggregator_error_1.q.out: does not exist in index
error: a/ql/src/test/results/clientpositive/llap/lineage3.q.out: does not exist in index
error: a/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDe.java: does not exist in index
error: a/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java: does not exist in index
error: a/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java: does not exist in index
error: a/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/StringUtils.java: does not exist in index
error: a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java: does not exist in index
error: a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/TokenStoreDelegationTokenSecretManager.java: does not exist in index
error: a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java: does not exist in index
error: a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java: does not exist in index
error: a/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestEmbeddedHiveMetaStore.java: does not exist in index
error: a/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java: does not exist in index
error: a/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java: does not exist in index
error: patch failed: cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:154
Falling back to three-way merge...
Applied patch to 'cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java' with conflicts.
error: patch failed: itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java:131
Falling back to three-way merge...
Applied patch to 'itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java' with conflicts.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/Context.java:624
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/Context.java' with conflicts.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/Driver.java:364
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/Driver.java' with conflicts.
error: ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java: does not exist in index
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java:63
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java' with conflicts.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/ReplCopyTask.java:209
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/ReplCopyTask.java' cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java:186
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java' cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java:47
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java' with conflicts.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java:48
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java' with conflicts.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MergeFileRecordProcessor.java:217
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MergeFileRecordProcessor.java' with conflicts.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:1929
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java' with conflicts.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/processors/DfsProcessor.java:96
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/processors/DfsProcessor.java' with conflicts.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java:44
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java' with conflicts.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java:43
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java' with conflicts.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:219
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java' cleanly.
error: patch failed: ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveRemote.java:23
Falling back to three-way merge...
Applied patch to 'ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveRemote.java' cleanly.
error: patch failed: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:9591
Falling back to three-way merge...
Applied patch to 'standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java' cleanly.
error: patch failed: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java:1768
Falling back to three-way merge...
Applied patch to 'standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java' cleanly.
error: src/java/org/apache/hadoop/hive/cli/CliDriver.java: does not exist in index
error: src/java/org/apache/hive/common/util/HiveStringUtils.java: does not exist in index
error: src/java/org/apache/hadoop/hive/druid/DruidKafkaUtils.java: does not exist in index
error: util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java: does not exist in index
error: src/java/org/apache/hadoop/hive/metastore/SerDeStorageSchemaReader.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/Context.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/Driver.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/HookRunner.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/CopyTask.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/ExplainSQRewriteTask.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/ReplCopyTask.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/ReplTxnTask.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/Task.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/spark/SparkReduceRecordHandler.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/spark/status/LocalSparkJobMonitor.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/spark/status/RemoteSparkJobMonitor.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/tez/MapRecordSource.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/tez/MergeFileRecordProcessor.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordSource.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/tez/TezProcessor.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/history/HiveHistoryImpl.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/hooks/LineageLogger.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/io/merge/MergeFileTask.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateTask.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/optimizer/SimpleFetchOptimizer.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/processors/DfsProcessor.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/session/SessionState.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/stats/BasicStatsNoJobTask.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/stats/ColStatsProcessor.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVariance.java: does not exist in index
error: src/test/org/apache/hadoop/hive/metastore/TestMetastoreExpr.java: does not exist in index
error: src/test/org/apache/hadoop/hive/metastore/txn/TestTxnHandler.java: does not exist in index
error: src/test/org/apache/hadoop/hive/ql/exec/TestMsckCreatePartitionsInBatches.java: does not exist in index
error: src/test/org/apache/hadoop/hive/ql/exec/TestMsckDropPartitionsInBatches.java: does not exist in index
error: src/test/org/apache/hadoop/hive/ql/exec/spark/session/TestSparkSessionManagerImpl.java: does not exist in index
error: src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java: does not exist in index
error: src/test/org/apache/hadoop/hive/ql/metadata/TestHiveRemote.java: does not exist in index
error: src/test/results/clientnegative/authorization_disallow_transform.q.out: does not exist in index
error: src/test/results/clientnegative/bad_exec_hooks.q.out: does not exist in index
error: src/test/results/clientnegative/fallbackauth_disallow_transform.q.out: does not exist in index
error: src/test/results/clientnegative/stats_aggregator_error_1.q.out: does not exist in index
error: src/test/results/clientpositive/llap/lineage3.q.out: does not exist in index
error: src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDe.java: does not exist in index
error: src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java: does not exist in index
error: metastore-common/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java: does not exist in index
error: metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/StringUtils.java: does not exist in index
error: metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java: does not exist in index
error: metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/TokenStoreDelegationTokenSecretManager.java: does not exist in index
error: metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java: does not exist in index
error: metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java: does not exist in index
error: metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestEmbeddedHiveMetaStore.java: does not exist in index
error: metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java: does not exist in index
error: metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java: does not exist in index
The patch does not appear to apply with p0, p1, or p2
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-19118
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12983753 - PreCommit-HIVE-Build

> Remove stringifyException Method
> --------------------------------
>
>                 Key: HIVE-20238
>                 URL: https://issues.apache.org/jira/browse/HIVE-20238
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 4.0.0
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>              Labels: newbie, noob
>             Fix For: 4.0.0
>
>         Attachments: HIVE-20238.1.patch, HIVE-20238.2.patch, HIVE-20238.3.patch, HIVE-20238.4.patch, HIVE-20238.5.patch, HIVE-20238.6.patch, HIVE-20238.7.patch, HIVE-20238.8.patch, HIVE-20238.8.patch
>
>
> Deprecate the method {{stringifyException}}
> https://github.com/apache/hive/blob/c2940a07cf0891e922672782b73ec22551a7eedd/common/src/java/org/apache/hive/common/util/HiveStringUtils.java#L146
> The code already exists in Hadoop proper:
> https://github.com/apache/hadoop/blob/2b2399d623539ab68e71a38fa9fbfc9a405bddb8/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java#L86
> And beyond that, I was told on the Hadoop dev mailing list that this function should not be used anymore.  Developers should just be using the SLF4J facilities and not this home-grown thing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)