You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2026/02/17 18:07:15 UTC

[PR] GH-49261: [C++][CI] Use differential fuzzing on IPC file fuzzer [arrow]

pitrou opened a new pull request, #49312:
URL: https://github.com/apache/arrow/pull/49312

   Thanks for opening a pull request!
   
   If this is your first pull request you can find detailed information on how to contribute here:
   
     * [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
     * [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
     * [AI-generated Code Guidance](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code)
   
   Please remove this line and the above text before creating your pull request.
   
   ### Rationale for this change
   
   ### What changes are included in this PR?
   
   ### Are these changes tested?
   
   ### Are there any user-facing changes?
   
   **This PR includes breaking changes to public APIs.** (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
   
   **This PR contains a "Critical Fix".** (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49261: [C++][CI] Use differential fuzzing on IPC file fuzzer [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #49312:
URL: https://github.com/apache/arrow/pull/49312#issuecomment-3919168534

   You're right @kou, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49261: [C++][CI] Use differential fuzzing on IPC file fuzzer [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #49312:
URL: https://github.com/apache/arrow/pull/49312#issuecomment-3917018279

   The IPC file format is just the IPC stream format + a fixed-size header + a footer with additional metadata for random access (like a ZIP catalog, basically).
   
   However, since the IPC file format allows for random access, the IPC file reader has specifics shortcuts and heuristics to make better use of IO, meaning different code paths than the IPC stream format.
   
   (it's not a problem to exercise the IPC stream reader code, either, even though we have a separate fuzz harness for it)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49311: [C++][CI] Use differential fuzzing on IPC file fuzzer [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #49312:
URL: https://github.com/apache/arrow/pull/49312#issuecomment-3997657524

   It turns out that the differential fuzzing between IPC file and IPC stream can fail because of a mismatching schema, see https://github.com/apache/arrow/issues/49448


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49261: [C++][CI] Use differential fuzzing on IPC file fuzzer [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49312:
URL: https://github.com/apache/arrow/pull/49312#issuecomment-3916441297

   Revision: 589a1ff01f057e9cd1860db3eb66aa84beb89935
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-c68bd13b91](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c68bd13b91)
   
   |Task|Status|
   |----|------|
   |test-build-cpp-fuzz|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-c68bd13b91-github-test-build-cpp-fuzz)](https://github.com/ursacomputing/crossbow/actions/runs/22110707050/job/63905857245)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49311: [C++][CI] Use differential fuzzing on IPC file fuzzer [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #49312:
URL: https://github.com/apache/arrow/pull/49312


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49261: [C++][CI] Use differential fuzzing on IPC file fuzzer [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #49312:
URL: https://github.com/apache/arrow/pull/49312#issuecomment-3916419138

   @addisoncrump FYI and if you're not bored of this :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49261: [C++][CI] Use differential fuzzing on IPC file fuzzer [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #49312:
URL: https://github.com/apache/arrow/pull/49312#issuecomment-3918107679

   Should we refer GH-49311 not GH-49261 from this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49261: [C++][CI] Use differential fuzzing on IPC file fuzzer [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #49312:
URL: https://github.com/apache/arrow/pull/49312#issuecomment-3916431572

   @github-actions crossbow submit *fuzz*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49261: [C++][CI] Use differential fuzzing on IPC file fuzzer [arrow]

Posted by "addisoncrump (via GitHub)" <gi...@apache.org>.
addisoncrump commented on PR #49312:
URL: https://github.com/apache/arrow/pull/49312#issuecomment-3916952126

   Looks like a reasonable differential fuzzer impl. Are the two sources of information different? Or is one just a "wrapped" version of another? If so, your fuzzer might be exploring a lot of code that isn't relevant to the actual conversion bit (i.e., the bit you're actually testing).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org