You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/04/21 17:46:44 UTC

[GitHub] [beam] tvalentyn commented on a change in pull request #14605: [BEAM-2085] Fixups for Python resource hints.

tvalentyn commented on a change in pull request #14605:
URL: https://github.com/apache/beam/pull/14605#discussion_r617757350



##########
File path: sdks/python/apache_beam/transforms/resources.py
##########
@@ -134,6 +134,8 @@ def _parse_storage_size_str(value):
       raise ValueError()
 
     suffix = match.group(1)
+    if suffix not in units:
+      raise ValueError()

Review comment:
       there is one interpretation where lowercase b means bits.. so wanted to avoid this confusion just in case even though unlikely
   https://en.wikipedia.org/wiki/JEDEC_memory_standards#Unit_prefixes_for_semiconductor_storage_capacity




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org