[jira] [Commented] (HADOOP-12284) UserGroupInformation doAs can throw misleading exception

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647182#comment-14647182 ] 

Hadoop QA commented on HADOOP-12284:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  16m 38s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 37s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 39s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   1m  5s | The applied patch generated  1 new checkstyle issues (total was 108, now 109). |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install |   1m 23s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 50s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests |  22m 31s | Tests passed in hadoop-common. |
| | |  61m 43s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12747916/HADOOP-12284.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / ddc867ce |
| checkstyle |  https://builds.apache.org/job/PreCommit-HADOOP-Build/7366/artifact/patchprocess/diffcheckstylehadoop-common.txt |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7366/artifact/patchprocess/testrun_hadoop-common.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/7366/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/7366/console |


This message was automatically generated.

> UserGroupInformation doAs can throw misleading exception
> --------------------------------------------------------
>
>                 Key: HADOOP-12284
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12284
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>            Reporter: Aaron Dossett
>            Assignee: Aaron Dossett
>            Priority: Trivial
>         Attachments: HADOOP-12284.patch
>
>
> If doAs() catches a PrivilegedActionException it extracts the underlying cause through getCause and then rethrows an exception based on the class of the Cause.  If getCause returns null this executes, this is how it rethrown:
> else {
>         throw new UndeclaredThrowableException(cause);
>       }
> If cause == null that seems misleading. I have seen actual instances where cause is null, so this isn't just a theoretical concern.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)