You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/09 14:23:56 UTC
[GitHub] [apisix-dashboard] Baoyuantop opened a new pull request #2052: fix: websocket enable in route
Baoyuantop opened a new pull request #2052:
URL: https://github.com/apache/apisix-dashboard/pull/2052
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Pass the normal `enable_websocket` state to the API.
**Related issues**
fix #1933
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [x] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #2052: fix: websocket enable in route
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #2052:
URL: https://github.com/apache/apisix-dashboard/pull/2052#issuecomment-895267965
👷 Deploy Preview for *apisix-dashboard* processing.
🔨 Explore the source changes: 69b19d907a4aea84ba22bc44a46ac92ff0a327e9
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61113a75d438fe00074f4162](https://app.netlify.com/sites/apisix-dashboard/deploys/61113a75d438fe00074f4162?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2052: fix: websocket enable in route
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2052:
URL: https://github.com/apache/apisix-dashboard/pull/2052#issuecomment-895267965
✔️ Deploy Preview for *apisix-dashboard* ready!
🔨 Explore the source changes: 0f4e85625092f748064bf4919939a2ad2208133a
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6111dc8097b02900077de1cb](https://app.netlify.com/sites/apisix-dashboard/deploys/6111dc8097b02900077de1cb?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-2052--apisix-dashboard.netlify.app](https://deploy-preview-2052--apisix-dashboard.netlify.app?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2052: fix: websocket enable in route
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2052:
URL: https://github.com/apache/apisix-dashboard/pull/2052#issuecomment-895267965
✔️ Deploy Preview for *apisix-dashboard* ready!
🔨 Explore the source changes: 69b19d907a4aea84ba22bc44a46ac92ff0a327e9
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61113a75d438fe00074f4162](https://app.netlify.com/sites/apisix-dashboard/deploys/61113a75d438fe00074f4162?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-2052--apisix-dashboard.netlify.app/](https://deploy-preview-2052--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2052: fix: websocket enable in route
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2052:
URL: https://github.com/apache/apisix-dashboard/pull/2052#issuecomment-895267965
👷 Deploy Preview for *apisix-dashboard* processing.
🔨 Explore the source changes: 0f4e85625092f748064bf4919939a2ad2208133a
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6111dc8097b02900077de1cb](https://app.netlify.com/sites/apisix-dashboard/deploys/6111dc8097b02900077de1cb?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2052: fix: websocket enable in route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2052:
URL: https://github.com/apache/apisix-dashboard/pull/2052#issuecomment-895300843
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2052](https://codecov.io/gh/apache/apisix-dashboard/pull/2052?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (267d3fc) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c3ea6879436147f01640ef6344c4445b41ab4593?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c3ea687) will **increase** coverage by `0.07%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 267d3fc differs from pull request most recent head 0f4e856. Consider uploading reports for the commit 0f4e856 to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2052 +/- ##
==========================================
+ Coverage 65.88% 65.96% +0.07%
==========================================
Files 121 121
Lines 3210 3214 +4
Branches 778 781 +3
==========================================
+ Hits 2115 2120 +5
+ Misses 1095 1094 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `65.96% <100.00%> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=) | `72.72% <ø> (ø)` | |
| [web/src/app.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9hcHAudHN4) | `100.00% <100.00%> (ø)` | |
| [web/src/components/Plugin/UI/limit-conn.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb25uLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `83.33% <100.00%> (ø)` | |
| [web/src/pages/Route/components/Step1/MetaView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01ldGFWaWV3LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `73.77% <0.00%> (+1.63%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2052?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2052?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c3ea687...0f4e856](https://codecov.io/gh/apache/apisix-dashboard/pull/2052?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #2052: fix: websocket enable in route
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #2052:
URL: https://github.com/apache/apisix-dashboard/pull/2052#discussion_r685423533
##########
File path: web/cypress/integration/route/create-edit-route-with-redirect-plugin.spec.js
##########
@@ -31,6 +31,7 @@ context('Create Edit and Delete Route with redirect plugin', () => {
deleteAlert: '.ant-modal-body',
notificationCloseIcon: '.ant-notification-close-icon',
notification: '.ant-notification-notice-message',
+ webSocketSelector: '[title=WebSocket]',
Review comment:
it would be better to assert both websocket label and switch are not existed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2052: fix: websocket enable in route
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #2052:
URL: https://github.com/apache/apisix-dashboard/pull/2052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2052: fix: websocket enable in route
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2052:
URL: https://github.com/apache/apisix-dashboard/pull/2052#issuecomment-895300843
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2052](https://codecov.io/gh/apache/apisix-dashboard/pull/2052?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7768b6f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c3ea6879436147f01640ef6344c4445b41ab4593?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c3ea687) will **increase** coverage by `0.06%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 7768b6f differs from pull request most recent head 69b19d9. Consider uploading reports for the commit 69b19d9 to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2052 +/- ##
==========================================
+ Coverage 65.88% 65.95% +0.06%
==========================================
Files 121 121
Lines 3210 3213 +3
Branches 778 781 +3
==========================================
+ Hits 2115 2119 +4
+ Misses 1095 1094 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `65.95% <100.00%> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=) | `72.72% <ø> (ø)` | |
| [web/src/app.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9hcHAudHN4) | `100.00% <100.00%> (ø)` | |
| [web/src/pages/Route/components/Step1/MetaView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01ldGFWaWV3LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `73.77% <0.00%> (+1.63%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2052?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2052?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c3ea687...69b19d9](https://codecov.io/gh/apache/apisix-dashboard/pull/2052?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on a change in pull request #2052: fix: websocket enable in route
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on a change in pull request #2052:
URL: https://github.com/apache/apisix-dashboard/pull/2052#discussion_r685646102
##########
File path: web/cypress/integration/route/create-edit-route-with-redirect-plugin.spec.js
##########
@@ -31,6 +31,7 @@ context('Create Edit and Delete Route with redirect plugin', () => {
deleteAlert: '.ant-modal-body',
notificationCloseIcon: '.ant-notification-close-icon',
notification: '.ant-notification-notice-message',
+ webSocketSelector: '[title=WebSocket]',
Review comment:
Done ~ @liuxiran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org