You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "YannByron (via GitHub)" <gi...@apache.org> on 2024/03/29 03:44:28 UTC

[PR] [core] add deletedFiles in NewFilesIncrement [paimon]

YannByron opened a new pull request, #3117:
URL: https://github.com/apache/paimon/pull/3117

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #xxx
   
   <!-- What is the purpose of the change -->
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] add deletedFiles in NewFilesIncrement [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #3117:
URL: https://github.com/apache/paimon/pull/3117


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] add deletedFiles in NewFilesIncrement [paimon]

Posted by "YannByron (via GitHub)" <gi...@apache.org>.
YannByron commented on code in PR #3117:
URL: https://github.com/apache/paimon/pull/3117#discussion_r1544095614


##########
paimon-core/src/main/java/org/apache/paimon/mergetree/MergeTreeWriter.java:
##########
@@ -305,7 +311,9 @@ public void close() throws Exception {
 
         // delete temporary files
         List<DataFileMeta> delete = new ArrayList<>(newFiles);
+        delete.addAll(deletedFiles);

Review Comment:
   OK, but we still need to clear `deletedFiles`, right ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] add deletedFiles in NewFilesIncrement [paimon]

Posted by "YannByron (via GitHub)" <gi...@apache.org>.
YannByron commented on PR #3117:
URL: https://github.com/apache/paimon/pull/3117#issuecomment-2029300899

   https://github.com/apache/paimon/issues/3057


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] add deletedFiles in NewFilesIncrement [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #3117:
URL: https://github.com/apache/paimon/pull/3117#issuecomment-2026755895

   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] add deletedFiles in NewFilesIncrement [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #3117:
URL: https://github.com/apache/paimon/pull/3117#discussion_r1544061313


##########
paimon-core/src/main/java/org/apache/paimon/mergetree/MergeTreeWriter.java:
##########
@@ -305,7 +311,9 @@ public void close() throws Exception {
 
         // delete temporary files
         List<DataFileMeta> delete = new ArrayList<>(newFiles);
+        delete.addAll(deletedFiles);

Review Comment:
   we don't need to delete delete files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] add deletedFiles in NewFilesIncrement [paimon]

Posted by "nonggialiang (via GitHub)" <gi...@apache.org>.
nonggialiang commented on PR #3117:
URL: https://github.com/apache/paimon/pull/3117#issuecomment-2068835920

   @YannByron @JingsongLi 
   Shall we increase the CommitMessageSerializer.CURRENT_VERSION and deserialize the objects according to the version for backward compactibility support ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org