You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "Forus0322 (via GitHub)" <gi...@apache.org> on 2024/12/20 02:40:04 UTC
[PR] [Improve] Optimize jobsOverview for null to be the starting NPE excep… [incubator-streampark]
Forus0322 opened a new pull request, #4152:
URL: https://github.com/apache/incubator-streampark/pull/4152
…tion.
<!--
Thank you for contributing to StreamPark! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
## Contribution Checklist
- If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
- Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
-->
## What changes were proposed in this pull request
Issue Number: close #xxx <!-- REMOVE this line if no issue to close -->
<!--(For example: This pull request proposed to add checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verifying this change
<!--*(Please pick either of the following options)*-->
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added integration tests for end-to-end.*
- *Added *Test to verify the change.*
- *Manually verified the change by testing locally.* -->
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): (yes / no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve] Optimize jobsOverview for null to be the starting NPE excep… [incubator-streampark]
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #4152:
URL: https://github.com/apache/incubator-streampark/pull/4152#issuecomment-2556780908
There are some code style issue, you can run `mvn spotless:apply ` to fixed them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve] Optimize jobsOverview for null to be the starting NPE excep… [incubator-streampark]
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on code in PR #4152:
URL: https://github.com/apache/incubator-streampark/pull/4152#discussion_r1893805351
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/watcher/FlinkAppHttpWatcher.java:
##########
@@ -305,7 +305,7 @@ private void getStateFromFlink(FlinkApplication application) throws Exception {
FlinkDeployMode deployMode = application.getDeployModeEnum();
if (FlinkDeployMode.YARN_APPLICATION.equals(deployMode)
|| FlinkDeployMode.YARN_PER_JOB.equals(deployMode)) {
- if (jobsOverview.getJobs() != null) {
+ if (jobsOverview!= null && jobsOverview.getJobs() != null) {
Review Comment:
There is a code style issue here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve] Optimize jobsOverview for null to be the starting NPE excep… [streampark]
Posted by "Forus0322 (via GitHub)" <gi...@apache.org>.
Forus0322 closed pull request #4152: [Improve] Optimize jobsOverview for null to be the starting NPE excep…
URL: https://github.com/apache/streampark/pull/4152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve] Optimize jobsOverview for null to be the starting NPE excep… [incubator-streampark]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4152:
URL: https://github.com/apache/incubator-streampark/pull/4152#issuecomment-2556151386
## [](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4152) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4152&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4152&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-streampark&pullRequest=4152&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4152&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4152&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4152)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve] Optimize jobsOverview for null to be the starting NPE excep… [incubator-streampark]
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #4152:
URL: https://github.com/apache/incubator-streampark/pull/4152#issuecomment-2585534386
Thanks for your contribution. This PR has some code-style issues. Could you please fix them first? If you do, I would be happy to merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org