You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@quickstep.apache.org by na...@apache.org on 2016/07/20 17:17:53 UTC
incubator-quickstep git commit: Avoid checking Bloom filter bit
before setting it
Repository: incubator-quickstep
Updated Branches:
refs/heads/expt_bloom_filter_hash_fn d04402d84 -> cdd991e7b
Avoid checking Bloom filter bit before setting it
Project: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/commit/cdd991e7
Tree: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/tree/cdd991e7
Diff: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/diff/cdd991e7
Branch: refs/heads/expt_bloom_filter_hash_fn
Commit: cdd991e7b09a4e9a24b5c2ba2974e28fd71e19a6
Parents: d04402d
Author: Navneet Potti <na...@gmail.com>
Authored: Wed Jul 20 12:17:35 2016 -0500
Committer: Navneet Potti <na...@gmail.com>
Committed: Wed Jul 20 12:17:35 2016 -0500
----------------------------------------------------------------------
utility/BloomFilter.hpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-quickstep/blob/cdd991e7/utility/BloomFilter.hpp
----------------------------------------------------------------------
diff --git a/utility/BloomFilter.hpp b/utility/BloomFilter.hpp
index 17a6da8..973ca14 100644
--- a/utility/BloomFilter.hpp
+++ b/utility/BloomFilter.hpp
@@ -233,8 +233,7 @@ class BloomFilterBlocked {
*/
inline void insertUnSafe(const std::uint8_t *key_begin, const std::size_t length) {
Position first_pos = getFirstPosition(key_begin, length);
- if (!getBitAtPosition(first_pos))
- setBitAtPosition(first_pos);
+ setBitAtPosition(first_pos);
Position other_pos;
for (std::uint8_t i = 1; i <hash_fn_count_; ++i) {
other_pos = getOtherPosition(key_begin, length, first_pos, i);