You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "MartijnVisser (via GitHub)" <gi...@apache.org> on 2023/03/31 06:54:19 UTC
[GitHub] [flink-connector-pulsar] MartijnVisser opened a new pull request, #37: [FLINK-31676][Connector/Pulsar] Replace Shaded Guava from Flink with Shaded Guava from Pulsar
MartijnVisser opened a new pull request, #37:
URL: https://github.com/apache/flink-connector-pulsar/pull/37
## Purpose of the change
* Replace dependency on Flink-Shaded for connectors, since externalized connectors shouldn't rely on Flink-Shaded
## Brief change log
- Removed all occurrences of `org.apache.flink.shaded.guava30.com` with `org.apache.pulsar.shade.com`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Significant changes
*(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for
convenience.)*
- [X] Dependencies have been added or upgraded
- [ ] Public API has been changed (Public API is any class annotated with `@Public(Evolving)`)
- [ ] Serializers have been changed
- [ ] New feature has been introduced
- If yes, how is this documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-pulsar] syhily commented on pull request #37: [FLINK-31676][Connector/Pulsar] Replace Shaded Guava from Flink with Shaded Guava from Pulsar
Posted by "syhily (via GitHub)" <gi...@apache.org>.
syhily commented on PR #37:
URL: https://github.com/apache/flink-connector-pulsar/pull/37#issuecomment-1495218308
`flink-shade` is an transitive dependency. We can't prevent the use of it, but we can ask others to use Pulsar's shaded Guava when review the PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-pulsar] MartijnVisser commented on pull request #37: [FLINK-31676][Connector/Pulsar] Replace Shaded Guava from Flink with Shaded Guava from Pulsar
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #37:
URL: https://github.com/apache/flink-connector-pulsar/pull/37#issuecomment-1491954797
> how can we prevent dependencies on Flink Shade predictably?
I don't think we can; it's a transitive dependency of Flink, which is needed in order to build/test the connector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-pulsar] MartijnVisser merged pull request #37: [FLINK-31676][Connector/Pulsar] Replace Shaded Guava from Flink with Shaded Guava from Pulsar
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #37:
URL: https://github.com/apache/flink-connector-pulsar/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org