[jira] [Commented] (ARROW-17457) [C++] Substarit End-To-End Tests for Relations

["Weston Pace (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581854#comment-17581854 ] 

Weston Pace commented on ARROW-17457:
-------------------------------------

It is a bit spread out but we have some end-to-end tests on some of these features.  There are a few different round trip tests (and your examples) which test the read relation.  The tests in {{arrow/engine/substrait/function_test.cc}} do round trip testing for Project and Aggregate.  We do not have any round trip tests that I know of for Filter or Join.

> [C++] Substarit End-To-End Tests for Relations
> ----------------------------------------------
>
>                 Key: ARROW-17457
>                 URL: https://issues.apache.org/jira/browse/ARROW-17457
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Vibhatha Lakmal Abeykoon
>            Assignee: Vibhatha Lakmal Abeykoon
>            Priority: Major
>
> At the moment the test coverage for Substrait integration covers the functional tests for serializing and deserializing. But it lacks test for running end-to-end functional tests which proves whether a Substrait plan can deliver the expected outcome. As a part of this, for each relation (Read, Filter, Project, Join, Aggregate) must have end-to-end tests covering the options associated with each relation. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)