[jira] [Commented] (STORM-2428) Flux-core jar contains unpacked dependencies

["Matthew Fleming (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967842#comment-15967842 ] 

Matthew Fleming commented on STORM-2428:
----------------------------------------

+1 on this.. I think you should be shading those dependencies into different packages. If you look at _storm-core_, the shaded packages are under _org.apache.storm.shade_ which works really well.

[~jnioche] the way I'm getting around this is the ordering within my pom.. if you put the dependency (that is in the jar but not the version you want to use) before the flux dependencies, the classpath ordering is maintained by maven. I haven't tried it in the shaded jar (for deployment) but there it's pretty ez to just strip out the non-shaded dependencies from within the flux-core jars on that but maybe the shade jar also considers the order of the dependencies (again don't know just yet)

> Flux-core jar contains unpacked dependencies
> --------------------------------------------
>
>                 Key: STORM-2428
>                 URL: https://issues.apache.org/jira/browse/STORM-2428
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: Flux
>    Affects Versions: 1.1.0, 1.0.3
>            Reporter: Julien Nioche
>
> The jar file for flux-core contains classes from /org/apache/http/. This was not the case before and causes problems with projects which rely on a different version of http-client. 
> I can't see any references to http-client in the pom though.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)