[GitHub] [iceberg] rdblue commented on a change in pull request #2240: Auto promote sorted column metrics to truncate(16)

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2240:
URL: https://github.com/apache/iceberg/pull/2240#discussion_r583316259



##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -120,6 +120,8 @@ private TableProperties() {
   public static final String METRICS_MODE_COLUMN_CONF_PREFIX = "write.metadata.metrics.column.";
   public static final String DEFAULT_WRITE_METRICS_MODE = "write.metadata.metrics.default";
   public static final String DEFAULT_WRITE_METRICS_MODE_DEFAULT = "truncate(16)";
+  public static final String SORTED_COL_DEFAULT_METRICS_MODE = "write.metadata.sorted.metrics.default";

Review comment:
       I agree with this behavior and I also would not add a new table property.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org