You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/20 08:15:00 UTC
[jira] [Commented] (NIFI-3781) Controller Service Config Dialog
'View Details' button feels confusing and inconsistent with Processors
[ https://issues.apache.org/jira/browse/NIFI-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134336#comment-16134336 ]
ASF GitHub Bot commented on NIFI-3781:
--------------------------------------
GitHub user yuri1969 opened a pull request:
https://github.com/apache/nifi/pull/2102
NIFI-3781 - Controller Service Config Dialog...
..'View Details' button feels confusing and inconsistent with Processors
* Merged 'View Details' and 'Edit' buttons to a single 'Configure'/'View Details' one.
* Fixed confusing 'View Details' modal's title.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yuri1969/nifi NIFI-3781
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2102.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2102
----
commit af69559ba3979ee6155f8a0d9fc885c4cb51e854
Author: yuri1969 <19...@gmail.com>
Date: 2017-08-19T18:49:33Z
NIFI-3781 - Controller Service Config Dialog...
..'View Details' button feels confusing and inconsistent with Processors
* Merged 'View Details' and 'Edit' buttons to a single 'Configure'/'View Details' one.
* Fixed confusing 'View Details' modal's title.
----
> Controller Service Config Dialog 'View Details' button feels confusing and inconsistent with Processors
> -------------------------------------------------------------------------------------------------------
>
> Key: NIFI-3781
> URL: https://issues.apache.org/jira/browse/NIFI-3781
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core UI
> Reporter: Mark Payne
>
> If a Processor is running, the user is able to right-click and "View Configuration." If stopped, the user is able to right-click and "Configure." With Controller Services, however, there is always a "View Details" (which is essentially the same as View Configuration). There is an "Edit" button only when the service is disabled.
> Often, I find myself clicking the "View Details" icon when a service is disabled and trying to configure the service, but I can't because it is a read-only view.
> I recommend removing the "View Details" icon from the left-hand side and instead have the right-hand side offer either "View Configuration" or "Configure" based on whether the service is enabled or disabled. I feel this is more consistent with how Processors work.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)