You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/25 10:23:19 UTC

[GitHub] [flink] cshuo opened a new pull request #16979: [FLINK-23962][table-planner] Fix updateKind trait propagating problem…

cshuo opened a new pull request #16979:
URL: https://github.com/apache/flink/pull/16979


   … in changelog inference for DAG optimizing
   
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   For sql jobs with multi-sinks, the plan is divided into relNode blocks, changeLog mode should be also inferred among blocks. Currently, updateKind trait is not propagated properly from parent block to child blocks.
   
   ## Brief change log
     - Modify updateKind trait propagating logic in `StreamCommonSubGraphBasedOptimizer`
   
   
   ## Verifying this change
     - Plan unit test with changeLog verified.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16979: [FLINK-23962][table-planner] Fix updateKind trait propagating problem…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16979:
URL: https://github.com/apache/flink/pull/16979#issuecomment-905395955


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "559fd2eee6cdbbd1a71fc5a5f55611aeea9d709d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22820",
       "triggerID" : "559fd2eee6cdbbd1a71fc5a5f55611aeea9d709d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 559fd2eee6cdbbd1a71fc5a5f55611aeea9d709d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22820) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16979: [FLINK-23962][table-planner] Fix updateKind trait propagating problem…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16979:
URL: https://github.com/apache/flink/pull/16979#issuecomment-905395955


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "559fd2eee6cdbbd1a71fc5a5f55611aeea9d709d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22820",
       "triggerID" : "559fd2eee6cdbbd1a71fc5a5f55611aeea9d709d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 559fd2eee6cdbbd1a71fc5a5f55611aeea9d709d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22820) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16979: [FLINK-23962][table-planner] Fix updateKind trait propagating problem…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16979:
URL: https://github.com/apache/flink/pull/16979#issuecomment-905376923


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 559fd2eee6cdbbd1a71fc5a5f55611aeea9d709d (Wed Aug 25 10:27:07 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] godfreyhe closed pull request #16979: [FLINK-23962][table-planner] Fix updateKind trait propagating problem…

Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #16979:
URL: https://github.com/apache/flink/pull/16979


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tsreaper commented on a change in pull request #16979: [FLINK-23962][table-planner] Fix updateKind trait propagating problem…

Posted by GitBox <gi...@apache.org>.
tsreaper commented on a change in pull request #16979:
URL: https://github.com/apache/flink/pull/16979#discussion_r696566068



##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/StreamCommonSubGraphBasedOptimizer.scala
##########
@@ -85,12 +83,13 @@ class StreamCommonSubGraphBasedOptimizer(planner: StreamPlanner)
       return sinkBlocks
     }
 
-    // infer updateAsRetraction property and miniBatchInterval property for all input blocks
+    // infer modifyKind property for each blocks independently
+    sinkBlocks.foreach(b => optimizeBlock(b, isSinkBlock = true))
+    // infer and propagate updateKind and miniBatchInterval property for each blocks
     sinkBlocks.foreach { b =>
-      inferTraits(b, b.isUpdateBeforeRequired, b.getMiniBatchInterval, isSinkBlock = true)
+      propagateUpdateKindAndMiniBatchInterval(
+        b, b.isUpdateBeforeRequired, b.getMiniBatchInterval, isSinkBlock = true)
     }
-    // propagate updateAsRetraction property and miniBatchInterval property to all input blocks
-    sinkBlocks.foreach(propagateTraits(_, isSinkBlock = true))
     // clear the intermediate result
     sinkBlocks.foreach(resetIntermediateResult)
     // optimize recursively RelNodeBlock

Review comment:
       This final call to `optimizeBlock` is only updating the intermediate results and is not for some real optimization. However this will increase the planning time by 50%. Is it possible to remove this call?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] cshuo commented on pull request #16979: [FLINK-23962][table-planner] Fix updateKind trait propagating problem…

Posted by GitBox <gi...@apache.org>.
cshuo commented on pull request #16979:
URL: https://github.com/apache/flink/pull/16979#issuecomment-905406195


   cc @godfreyhe plz have a look at this pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] cshuo commented on pull request #16979: [FLINK-23962][table-planner] Fix updateKind trait propagating problem…

Posted by GitBox <gi...@apache.org>.
cshuo commented on pull request #16979:
URL: https://github.com/apache/flink/pull/16979#issuecomment-908063197


   the following improvement JIRA: https://issues.apache.org/jira/browse/FLINK-24048


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] cshuo commented on a change in pull request #16979: [FLINK-23962][table-planner] Fix updateKind trait propagating problem…

Posted by GitBox <gi...@apache.org>.
cshuo commented on a change in pull request #16979:
URL: https://github.com/apache/flink/pull/16979#discussion_r696579500



##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/StreamCommonSubGraphBasedOptimizer.scala
##########
@@ -85,12 +83,13 @@ class StreamCommonSubGraphBasedOptimizer(planner: StreamPlanner)
       return sinkBlocks
     }
 
-    // infer updateAsRetraction property and miniBatchInterval property for all input blocks
+    // infer modifyKind property for each blocks independently
+    sinkBlocks.foreach(b => optimizeBlock(b, isSinkBlock = true))
+    // infer and propagate updateKind and miniBatchInterval property for each blocks
     sinkBlocks.foreach { b =>
-      inferTraits(b, b.isUpdateBeforeRequired, b.getMiniBatchInterval, isSinkBlock = true)
+      propagateUpdateKindAndMiniBatchInterval(
+        b, b.isUpdateBeforeRequired, b.getMiniBatchInterval, isSinkBlock = true)
     }
-    // propagate updateAsRetraction property and miniBatchInterval property to all input blocks
-    sinkBlocks.foreach(propagateTraits(_, isSinkBlock = true))
     // clear the intermediate result
     sinkBlocks.foreach(resetIntermediateResult)
     // optimize recursively RelNodeBlock

Review comment:
       For solution here, it cannot be remove. You're right that the final `optimizeBlock ` is updating the intermediate results, but the updated intermediate result is physical node plan optimized with correct `ModifyKind` and `UpdateKind` trait, which are inferred and propagated by Line 86 ~ 91.
   
   The plan is optimized 3 times currently. Actually, we can move changeLog and minibatch interval inference out of optimizing phase, in that way the plan only needs one optimizing. This refactor involves many changes, so I think we may put it in later version.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16979: [FLINK-23962][table-planner] Fix updateKind trait propagating problem…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16979:
URL: https://github.com/apache/flink/pull/16979#issuecomment-905395955


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "559fd2eee6cdbbd1a71fc5a5f55611aeea9d709d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559fd2eee6cdbbd1a71fc5a5f55611aeea9d709d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 559fd2eee6cdbbd1a71fc5a5f55611aeea9d709d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org