You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/25 08:49:23 UTC

[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1734: Add null check in SnapshotService to avoid NPE

codecov-io edited a comment on pull request #1734:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1734#issuecomment-733558715


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1734?src=pr&el=h1) Report
   > Merging [#1734](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1734?src=pr&el=desc) (3b2a2ed) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/1df7beaac29d4907a176710750f7c3dd56c116b1?el=desc) (1df7bea) will **increase** coverage by `0.03%`.
   > The diff coverage is `85.71%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1734/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1734?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1734      +/-   ##
   ============================================
   + Coverage     86.18%   86.22%   +0.03%     
     Complexity      105      105              
   ============================================
     Files           252      252              
     Lines          5682     5683       +1     
     Branches        878      878              
   ============================================
   + Hits           4897     4900       +3     
   + Misses          471      470       -1     
   + Partials        314      313       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1734?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1734/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `84.37% <85.71%> (+3.42%)` | `1.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1734?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1734?src=pr&el=footer). Last update [1df7bea...3b2a2ed](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1734?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org