You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/06/23 00:11:32 UTC
[kudu-CR] KUDU-2052: use XFS IOC UNRESVSP64 ioctl to punch holes on xfs
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7269
to review the following change.
Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
......................................................................
KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
There's not much to say beyond what's already in the bug report.
To test, I created a 128 GB loopback-mounted xfs filesystem and ran the new
benchmark on it. I included the results below. I also ran the entire Kudu
test suite on that filesystem.
$ TEST_TMPDIR=/data/8/adar/xfs/ bin/env-test \
--gtest_filter=*Benchmark* \
--never_fsync=false \
--unlock_unsafe_flags
Time spent writing 1073741824 bytes to file: real 0.538s user 0.006s sys 0.533s
Time spent syncing file: real 8.142s user 0.002s sys 0.193s
Time spent punching first hole of size 10485760: real 0.131s user 0.000s sys 0.130s
Time spent syncing file: real 0.000s user 0.000s sys 0.000s
Time spent repunching 1000 holes of size 10485760: real 0.007s user 0.004s sys 0.003s
$ TEST_TMPDIR=/data/8/adar/xfs/ bin/env-test \
--gtest_filter=*Benchmark* \
--never_fsync=false \
--unlock_unsafe_flags \
--unlock_experimental_flags \
--env_use_alternate_hole_punch_on_xfs=false
Time spent writing 1073741824 bytes to file: real 0.555s user 0.007s sys 0.550s
Time spent syncing file: real 8.241s user 0.000s sys 0.219s
Time spent punching first hole of size 10485760: real 0.175s user 0.000s sys 0.148s
Time spent syncing file: real 0.000s user 0.000s sys 0.000s
Time spent repunching 1000 holes of size 10485760: real 27.719s user 0.026s sys 0.029s
Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
---
M src/kudu/util/env-test.cc
M src/kudu/util/env_posix.cc
2 files changed, 104 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/7269/1
--
To view, visit http://gerrit.cloudera.org:8080/7269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2052: use XFS IOC UNRESVSP64 ioctl to punch holes on xfs
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has uploaded a new patch set (#5).
Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
......................................................................
KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
There's not much to say beyond what's already in the bug report.
To test, I created a 128 GB loopback-mounted xfs filesystem and ran the new
benchmark on it. I included the results below. I also ran the entire Kudu
test suite on that filesystem.
$ TEST_TMPDIR=/data/8/adar/xfs/ bin/env-test \
--gtest_filter=*Benchmark* \
--never_fsync=false \
--unlock_unsafe_flags
Time spent writing 1073741824 bytes to file: real 0.538s user 0.006s sys 0.533s
Time spent syncing file: real 8.142s user 0.002s sys 0.193s
Time spent punching first hole of size 10485760: real 0.131s user 0.000s sys 0.130s
Time spent syncing file: real 0.000s user 0.000s sys 0.000s
Time spent repunching 1000 holes of size 10485760: real 0.007s user 0.004s sys 0.003s
$ TEST_TMPDIR=/data/8/adar/xfs/ bin/env-test \
--gtest_filter=*Benchmark* \
--never_fsync=false \
--unlock_unsafe_flags \
--unlock_experimental_flags \
--env_use_ioctl_hole_punch_on_xfs=false
Time spent writing 1073741824 bytes to file: real 0.555s user 0.007s sys 0.550s
Time spent syncing file: real 8.241s user 0.000s sys 0.219s
Time spent punching first hole of size 10485760: real 0.175s user 0.000s sys 0.148s
Time spent syncing file: real 0.000s user 0.000s sys 0.000s
Time spent repunching 1000 holes of size 10485760: real 27.719s user 0.026s sys 0.029s
Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
---
M src/kudu/util/env-test.cc
M src/kudu/util/env_posix.cc
2 files changed, 126 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/7269/5
--
To view, visit http://gerrit.cloudera.org:8080/7269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2052: use XFS IOC UNRESVSP64 ioctl to punch holes on xfs
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7269/2/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 83: // These struct and ioctl definitions were copied verbatim from xfsprogs.
> Could the use-site be if-deff'd out on OS X instead of redeclaring the stru
Todd sent this question over to ASF legal.
Dan: unfortunately this isn't like the fallocate() definitions where they do exist in (some) Linux distribution headers and thus can be conditioned on macOS. I couldn't find these definitions in any standard headers; AFAICT they only exist in xfsprogs.
PS2, Line 146: env_use_alternate_hole_punch_on_xfs
> maybe instead of 'alternate' say 'ioctl'?
Done
--
To view, visit http://gerrit.cloudera.org:8080/7269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2052: use XFS IOC UNRESVSP64 ioctl to punch holes on xfs
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Jean-Daniel Cryans, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7269
to look at the new patch set (#3).
Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
......................................................................
KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
There's not much to say beyond what's already in the bug report.
To test, I created a 128 GB loopback-mounted xfs filesystem and ran the new
benchmark on it. I included the results below. I also ran the entire Kudu
test suite on that filesystem.
$ TEST_TMPDIR=/data/8/adar/xfs/ bin/env-test \
--gtest_filter=*Benchmark* \
--never_fsync=false \
--unlock_unsafe_flags
Time spent writing 1073741824 bytes to file: real 0.538s user 0.006s sys 0.533s
Time spent syncing file: real 8.142s user 0.002s sys 0.193s
Time spent punching first hole of size 10485760: real 0.131s user 0.000s sys 0.130s
Time spent syncing file: real 0.000s user 0.000s sys 0.000s
Time spent repunching 1000 holes of size 10485760: real 0.007s user 0.004s sys 0.003s
$ TEST_TMPDIR=/data/8/adar/xfs/ bin/env-test \
--gtest_filter=*Benchmark* \
--never_fsync=false \
--unlock_unsafe_flags \
--unlock_experimental_flags \
--env_use_ioctl_hole_punch_on_xfs=false
Time spent writing 1073741824 bytes to file: real 0.555s user 0.007s sys 0.550s
Time spent syncing file: real 8.241s user 0.000s sys 0.219s
Time spent punching first hole of size 10485760: real 0.175s user 0.000s sys 0.148s
Time spent syncing file: real 0.000s user 0.000s sys 0.000s
Time spent repunching 1000 holes of size 10485760: real 27.719s user 0.026s sys 0.029s
Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
---
M src/kudu/util/env-test.cc
M src/kudu/util/env_posix.cc
2 files changed, 120 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/7269/3
--
To view, visit http://gerrit.cloudera.org:8080/7269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2052: use XFS IOC UNRESVSP64 ioctl to punch holes on xfs
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7269
to look at the new patch set (#2).
Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
......................................................................
KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
There's not much to say beyond what's already in the bug report.
To test, I created a 128 GB loopback-mounted xfs filesystem and ran the new
benchmark on it. I included the results below. I also ran the entire Kudu
test suite on that filesystem.
$ TEST_TMPDIR=/data/8/adar/xfs/ bin/env-test \
--gtest_filter=*Benchmark* \
--never_fsync=false \
--unlock_unsafe_flags
Time spent writing 1073741824 bytes to file: real 0.538s user 0.006s sys 0.533s
Time spent syncing file: real 8.142s user 0.002s sys 0.193s
Time spent punching first hole of size 10485760: real 0.131s user 0.000s sys 0.130s
Time spent syncing file: real 0.000s user 0.000s sys 0.000s
Time spent repunching 1000 holes of size 10485760: real 0.007s user 0.004s sys 0.003s
$ TEST_TMPDIR=/data/8/adar/xfs/ bin/env-test \
--gtest_filter=*Benchmark* \
--never_fsync=false \
--unlock_unsafe_flags \
--unlock_experimental_flags \
--env_use_alternate_hole_punch_on_xfs=false
Time spent writing 1073741824 bytes to file: real 0.555s user 0.007s sys 0.550s
Time spent syncing file: real 8.241s user 0.000s sys 0.219s
Time spent punching first hole of size 10485760: real 0.175s user 0.000s sys 0.148s
Time spent syncing file: real 0.000s user 0.000s sys 0.000s
Time spent repunching 1000 holes of size 10485760: real 27.719s user 0.026s sys 0.029s
Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
---
M src/kudu/util/env-test.cc
M src/kudu/util/env_posix.cc
2 files changed, 108 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/7269/2
--
To view, visit http://gerrit.cloudera.org:8080/7269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2052: use XFS IOC UNRESVSP64 ioctl to punch holes on xfs
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-2052: use XFS IOC UNRESVSP64 ioctl to punch holes on xfs
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7269/2/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 83: // These struct and ioctl definitions were copied verbatim from xfsprogs.
> do we have a licensing issue here? This is probably one of those gray areas
Could the use-site be if-deff'd out on OS X instead of redeclaring the struct?
--
To view, visit http://gerrit.cloudera.org:8080/7269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2052: use XFS IOC UNRESVSP64 ioctl to punch holes on xfs
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7269/4/src/kudu/util/env-test.cc
File src/kudu/util/env-test.cc:
PS4, Line 367: for (int i = 0; i < kOneMb; i += sizeof(uint32)) {
: *reinterpret_cast<uint32_t*>(&scratch[i]) = r.Next();
: }
nit: could use RandomString(scratch, arraysize(scratch), &r);
(from random_util.h)
http://gerrit.cloudera.org:8080/#/c/7269/4/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 805: // fallocate() syscall.
Maybe a short comment explaining that this works around a perf issue on el6? (on newer systems the two are identical, so someone might not understand why we went through the effort to do this)
Line 966: WARN_NOT_OK(s, "failed to check if file is on xfs");
should we do a FIRST_K type thing here?
--
To view, visit http://gerrit.cloudera.org:8080/7269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2052: use XFS IOC UNRESVSP64 ioctl to punch holes on xfs
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7269/4/src/kudu/util/env-test.cc
File src/kudu/util/env-test.cc:
PS4, Line 367: for (int i = 0; i < kOneMb; i += sizeof(uint32)) {
: *reinterpret_cast<uint32_t*>(&scratch[i]) = r.Next();
: }
> nit: could use RandomString(scratch, arraysize(scratch), &r);
Ah, I went looking for something like that but couldn't find it. Thanks.
http://gerrit.cloudera.org:8080/#/c/7269/4/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 805: // fallocate() syscall.
> Maybe a short comment explaining that this works around a perf issue on el6
Done
Line 966: WARN_NOT_OK(s, "failed to check if file is on xfs");
> should we do a FIRST_K type thing here?
Done
--
To view, visit http://gerrit.cloudera.org:8080/7269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2052: use XFS IOC UNRESVSP64 ioctl to punch holes on xfs
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
......................................................................
KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
There's not much to say beyond what's already in the bug report.
To test, I created a 128 GB loopback-mounted xfs filesystem and ran the new
benchmark on it. I included the results below. I also ran the entire Kudu
test suite on that filesystem.
$ TEST_TMPDIR=/data/8/adar/xfs/ bin/env-test \
--gtest_filter=*Benchmark* \
--never_fsync=false \
--unlock_unsafe_flags
Time spent writing 1073741824 bytes to file: real 0.538s user 0.006s sys 0.533s
Time spent syncing file: real 8.142s user 0.002s sys 0.193s
Time spent punching first hole of size 10485760: real 0.131s user 0.000s sys 0.130s
Time spent syncing file: real 0.000s user 0.000s sys 0.000s
Time spent repunching 1000 holes of size 10485760: real 0.007s user 0.004s sys 0.003s
$ TEST_TMPDIR=/data/8/adar/xfs/ bin/env-test \
--gtest_filter=*Benchmark* \
--never_fsync=false \
--unlock_unsafe_flags \
--unlock_experimental_flags \
--env_use_ioctl_hole_punch_on_xfs=false
Time spent writing 1073741824 bytes to file: real 0.555s user 0.007s sys 0.550s
Time spent syncing file: real 8.241s user 0.000s sys 0.219s
Time spent punching first hole of size 10485760: real 0.175s user 0.000s sys 0.148s
Time spent syncing file: real 0.000s user 0.000s sys 0.000s
Time spent repunching 1000 holes of size 10485760: real 27.719s user 0.026s sys 0.029s
Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
Reviewed-on: http://gerrit.cloudera.org:8080/7269
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/util/env-test.cc
M src/kudu/util/env_posix.cc
2 files changed, 126 insertions(+), 17 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2052: use XFS IOC UNRESVSP64 ioctl to punch holes on xfs
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
......................................................................
Patch Set 4: Verified+1
In one of the runs, the Python test setup failed with:
16:44:45 F0623 23:44:15.285069 9951 master_main.cc:68] Check failed: _s.ok() Bad status: Network error: error binding socket to 0.0.0.0:51312: Address already in use (error 98)
All of the Python tests in that run failed as a result.
--
To view, visit http://gerrit.cloudera.org:8080/7269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-2052: use XFS IOC UNRESVSP64 ioctl to punch holes on xfs
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7269/2/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 83: // These struct and ioctl definitions were copied verbatim from xfsprogs.
> Could the use-site be if-deff'd out on OS X instead of redeclaring the stru
The header which includes this is part of Linux and distributed as part of xfsprogs-devel on some systems, but isn't commonly installed, so we need to redefine here even on Linux.
I raised the question for ASF legal here: https://issues.apache.org/jira/browse/LEGAL-316
--
To view, visit http://gerrit.cloudera.org:8080/7269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2052: use XFS IOC UNRESVSP64 ioctl to punch holes on xfs
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
......................................................................
Patch Set 2:
(2 comments)
Patch seems fine but I have a licensing worry that may be a blocker
http://gerrit.cloudera.org:8080/#/c/7269/2/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 83: // These struct and ioctl definitions were copied verbatim from xfsprogs.
do we have a licensing issue here? This is probably one of those gray areas, but we should be careful because the original header seems to carry an LGPL license notice. I tried googling a bit to find precedent within the ASF but perhaps we should consult legal?
PS2, Line 146: env_use_alternate_hole_punch_on_xfs
maybe instead of 'alternate' say 'ioctl'?
--
To view, visit http://gerrit.cloudera.org:8080/7269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes