You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Leif Hedstrom <zw...@apache.org> on 2015/03/31 20:33:08 UTC

[IMPORTANT] New clang-format binaries / package

Hi all,

I’ve updated the tar-ball with the clang-format tools:

	http://people.apache.org/~zwoop/clang-format-03312015.tar.bz2


The MD5 of the tar-ball is

	minotaur (18:28) 266/0 $ md5 clang-format-03312015.tar.bz2
	MD5 (clang-format-03312015.tar.bz2) = 6b3e7933f3e93b52361c88970bc0d8fe


Please use this exact version of clang format. Currently, it has a static binary for Linux, which I hope should work on most platforms (let me know if it doesn’t). In addition, it also has a binary for OS X (Yosemite, I have not tested on Maverick). It’s important we all use the same version, so going forward, I’m versioning the packages as well, with the date. If you are developing on a platform other then Linux and OS X, let me know and I’ll try to make a version for that as well.

Question: Should we consider incorporating these binaries and scripts into our source tree?

Thanks,

— leif


Re: [IMPORTANT] New clang-format binaries / package

Posted by Leif Hedstrom <zw...@apache.org>.
I'm honestly not sure why the binary we have isn't  enough . It's not like it need to be download and installed very often . A script to automate the download and install seems fine if some cares to write one. It would have to deal to ask where to install it. :)

Cheers,

-- Leif 



> On May 10, 2015, at 2:46 PM, Phil Sorber <so...@apache.org> wrote:
> 
>> On Sun, May 10, 2015 at 2:41 PM James Peach <ja...@me.com> wrote:
>> 
>> 
>>> On May 10, 2015, at 1:35 PM, Phil Sorber <so...@apache.org> wrote:
>>> 
>>> On Sun, May 10, 2015 at 2:24 PM James Peach <jp...@apache.org> wrote:
>>> 
>>>> 
>>>>> On Mar 31, 2015, at 11:33 AM, Leif Hedstrom <zw...@apache.org> wrote:
>>>>> 
>>>>> Hi all,
>>>>> 
>>>>> I’ve updated the tar-ball with the clang-format tools:
>>>>> 
>>>>>     http://people.apache.org/~zwoop/clang-format-03312015.tar.bz2
>>>>> 
>>>>> 
>>>>> The MD5 of the tar-ball is
>>>>> 
>>>>>     minotaur (18:28) 266/0 $ md5 clang-format-03312015.tar.bz2
>>>>>     MD5 (clang-format-03312015.tar.bz2) =
>>>> 6b3e7933f3e93b52361c88970bc0d8fe
>>>>> 
>>>>> 
>>>>> Please use this exact version of clang format. Currently, it has a
>>>> static binary for Linux, which I hope should work on most platforms
>> (let me
>>>> know if it doesn’t). In addition, it also has a binary for OS X
>> (Yosemite,
>>>> I have not tested on Maverick). It’s important we all use the same
>> version,
>>>> so going forward, I’m versioning the packages as well, with the date. If
>>>> you are developing on a platform other then Linux and OS X, let me know
>> and
>>>> I’ll try to make a version for that as well.
>>>>> 
>>>>> Question: Should we consider incorporating these binaries and scripts
>>>> into our source tree?
>>>> 
>>>> Yes, definitely!
>>> 
>>> I am -1 on binaries in the repo, but if we wanted to put the code and
>> build
>>> it, I'd be ok with that. I assume the license is compatible?
>> 
>> Maybe a submodule? or a script that downloads and stashes the right
>> binaries in the right place?
> I don't have strong feelings on either of those. Basically anything that
> doesn't involve polluting the repo with binaries is ok by me.
> 
> 
>> J

Re: [IMPORTANT] New clang-format binaries / package

Posted by Phil Sorber <so...@apache.org>.
On Sun, May 10, 2015 at 2:41 PM James Peach <ja...@me.com> wrote:

>
> > On May 10, 2015, at 1:35 PM, Phil Sorber <so...@apache.org> wrote:
> >
> > On Sun, May 10, 2015 at 2:24 PM James Peach <jp...@apache.org> wrote:
> >
> >>
> >>> On Mar 31, 2015, at 11:33 AM, Leif Hedstrom <zw...@apache.org> wrote:
> >>>
> >>> Hi all,
> >>>
> >>> I’ve updated the tar-ball with the clang-format tools:
> >>>
> >>>      http://people.apache.org/~zwoop/clang-format-03312015.tar.bz2
> >>>
> >>>
> >>> The MD5 of the tar-ball is
> >>>
> >>>      minotaur (18:28) 266/0 $ md5 clang-format-03312015.tar.bz2
> >>>      MD5 (clang-format-03312015.tar.bz2) =
> >> 6b3e7933f3e93b52361c88970bc0d8fe
> >>>
> >>>
> >>> Please use this exact version of clang format. Currently, it has a
> >> static binary for Linux, which I hope should work on most platforms
> (let me
> >> know if it doesn’t). In addition, it also has a binary for OS X
> (Yosemite,
> >> I have not tested on Maverick). It’s important we all use the same
> version,
> >> so going forward, I’m versioning the packages as well, with the date. If
> >> you are developing on a platform other then Linux and OS X, let me know
> and
> >> I’ll try to make a version for that as well.
> >>>
> >>> Question: Should we consider incorporating these binaries and scripts
> >> into our source tree?
> >>
> >> Yes, definitely!
> >>
> >
> > I am -1 on binaries in the repo, but if we wanted to put the code and
> build
> > it, I'd be ok with that. I assume the license is compatible?
>
> Maybe a submodule? or a script that downloads and stashes the right
> binaries in the right place?
>
>
I don't have strong feelings on either of those. Basically anything that
doesn't involve polluting the repo with binaries is ok by me.


> J

Re: [IMPORTANT] New clang-format binaries / package

Posted by James Peach <ja...@me.com>.
> On May 10, 2015, at 1:35 PM, Phil Sorber <so...@apache.org> wrote:
> 
> On Sun, May 10, 2015 at 2:24 PM James Peach <jp...@apache.org> wrote:
> 
>> 
>>> On Mar 31, 2015, at 11:33 AM, Leif Hedstrom <zw...@apache.org> wrote:
>>> 
>>> Hi all,
>>> 
>>> I’ve updated the tar-ball with the clang-format tools:
>>> 
>>>      http://people.apache.org/~zwoop/clang-format-03312015.tar.bz2
>>> 
>>> 
>>> The MD5 of the tar-ball is
>>> 
>>>      minotaur (18:28) 266/0 $ md5 clang-format-03312015.tar.bz2
>>>      MD5 (clang-format-03312015.tar.bz2) =
>> 6b3e7933f3e93b52361c88970bc0d8fe
>>> 
>>> 
>>> Please use this exact version of clang format. Currently, it has a
>> static binary for Linux, which I hope should work on most platforms (let me
>> know if it doesn’t). In addition, it also has a binary for OS X (Yosemite,
>> I have not tested on Maverick). It’s important we all use the same version,
>> so going forward, I’m versioning the packages as well, with the date. If
>> you are developing on a platform other then Linux and OS X, let me know and
>> I’ll try to make a version for that as well.
>>> 
>>> Question: Should we consider incorporating these binaries and scripts
>> into our source tree?
>> 
>> Yes, definitely!
>> 
> 
> I am -1 on binaries in the repo, but if we wanted to put the code and build
> it, I'd be ok with that. I assume the license is compatible?

Maybe a submodule? or a script that downloads and stashes the right binaries in the right place?

J

Re: [IMPORTANT] New clang-format binaries / package

Posted by Leif Hedstrom <zw...@apache.org>.
> On May 10, 2015, at 5:16 PM, Leif Hedstrom <zw...@apache.org> wrote:
> 
> They are available, see previous email . I can send another link later which is the full download to the current version.


The current version of the binaries (and some scripts) could be directly downloaded from

   https://bintray.com/artifact/download/apache/trafficserver/clang-format-20150331.tar.bz2


I’m not sure how often we’ll update this, maybe once or twice a year? But it is important that we run the same version, since they brilliantly decide to arbitrarily change formatting without adding / modifying configurations :-).

I will update the Wiki page as soon as I can, and hope to wrap up a better git pre-commit hook.

Cheers,

— Leif


Re: [IMPORTANT] New clang-format binaries / package

Posted by Leif Hedstrom <zw...@apache.org>.
They are available, see previous email . I can send another link later which is the full download to the current version.

-- Leif 



> On May 10, 2015, at 5:02 PM, Theo Schlossnagle <je...@omniti.com> wrote:
> 
> Just install it as a dependency. Or make the binaries available at a url to
> make that easier.
>> On May 10, 2015 7:01 PM, "Leif Hedstrom" <zw...@apache.org> wrote:
>> 
>> It would be crazy huge, it takes hours to build. I'm even more -1 on
>> incorporating all of clang and llvm (which you need).
>> 
>> -- Leif
>> 
>> 
>> 
>>>> On May 10, 2015, at 2:35 PM, Phil Sorber <so...@apache.org> wrote:
>>>> 
>>>> On Sun, May 10, 2015 at 2:24 PM James Peach <jp...@apache.org> wrote:
>>>> 
>>>> 
>>>>> On Mar 31, 2015, at 11:33 AM, Leif Hedstrom <zw...@apache.org> wrote:
>>>>> 
>>>>> Hi all,
>>>>> 
>>>>> I’ve updated the tar-ball with the clang-format tools:
>>>>> 
>>>>>     http://people.apache.org/~zwoop/clang-format-03312015.tar.bz2
>>>>> 
>>>>> 
>>>>> The MD5 of the tar-ball is
>>>>> 
>>>>>     minotaur (18:28) 266/0 $ md5 clang-format-03312015.tar.bz2
>>>>>     MD5 (clang-format-03312015.tar.bz2) =
>>>> 6b3e7933f3e93b52361c88970bc0d8fe
>>>>> 
>>>>> 
>>>>> Please use this exact version of clang format. Currently, it has a
>>>> static binary for Linux, which I hope should work on most platforms
>> (let me
>>>> know if it doesn’t). In addition, it also has a binary for OS X
>> (Yosemite,
>>>> I have not tested on Maverick). It’s important we all use the same
>> version,
>>>> so going forward, I’m versioning the packages as well, with the date. If
>>>> you are developing on a platform other then Linux and OS X, let me know
>> and
>>>> I’ll try to make a version for that as well.
>>>>> 
>>>>> Question: Should we consider incorporating these binaries and scripts
>>>> into our source tree?
>>>> 
>>>> Yes, definitely!
>>> 
>>> I am -1 on binaries in the repo, but if we wanted to put the code and
>> build
>>> it, I'd be ok with that. I assume the license is compatible?
>>> 
>>> 
>>>> 
>>>> FWIW, here’s a script that formats the top commit. It’s quite useful in
>>>> conjunction with "git rebase —exec” ...
>>>> 
>>>> #! /bin/bash
>>>> 
>>>> case $(uname -s) in
>>>> Darwin) OS=osx;;
>>>> *) OS=linux;;
>>>> esac
>>>> 
>>>> TOPDIR=$(git rev-parse --show-toplevel)
>>>> FORMAT=$TOPDIR/.git/clang-format/clang-format.$OS
>>>> 
>>>> exec $FORMAT -i $(git show --pretty=format: --name-only)
>> 

Re: [IMPORTANT] New clang-format binaries / package

Posted by Theo Schlossnagle <je...@omniti.com>.
Just install it as a dependency. Or make the binaries available at a url to
make that easier.
On May 10, 2015 7:01 PM, "Leif Hedstrom" <zw...@apache.org> wrote:

> It would be crazy huge, it takes hours to build. I'm even more -1 on
> incorporating all of clang and llvm (which you need).
>
> -- Leif
>
>
>
> > On May 10, 2015, at 2:35 PM, Phil Sorber <so...@apache.org> wrote:
> >
> >> On Sun, May 10, 2015 at 2:24 PM James Peach <jp...@apache.org> wrote:
> >>
> >>
> >>> On Mar 31, 2015, at 11:33 AM, Leif Hedstrom <zw...@apache.org> wrote:
> >>>
> >>> Hi all,
> >>>
> >>> I’ve updated the tar-ball with the clang-format tools:
> >>>
> >>>      http://people.apache.org/~zwoop/clang-format-03312015.tar.bz2
> >>>
> >>>
> >>> The MD5 of the tar-ball is
> >>>
> >>>      minotaur (18:28) 266/0 $ md5 clang-format-03312015.tar.bz2
> >>>      MD5 (clang-format-03312015.tar.bz2) =
> >> 6b3e7933f3e93b52361c88970bc0d8fe
> >>>
> >>>
> >>> Please use this exact version of clang format. Currently, it has a
> >> static binary for Linux, which I hope should work on most platforms
> (let me
> >> know if it doesn’t). In addition, it also has a binary for OS X
> (Yosemite,
> >> I have not tested on Maverick). It’s important we all use the same
> version,
> >> so going forward, I’m versioning the packages as well, with the date. If
> >> you are developing on a platform other then Linux and OS X, let me know
> and
> >> I’ll try to make a version for that as well.
> >>>
> >>> Question: Should we consider incorporating these binaries and scripts
> >> into our source tree?
> >>
> >> Yes, definitely!
> >
> > I am -1 on binaries in the repo, but if we wanted to put the code and
> build
> > it, I'd be ok with that. I assume the license is compatible?
> >
> >
> >>
> >> FWIW, here’s a script that formats the top commit. It’s quite useful in
> >> conjunction with "git rebase —exec” ...
> >>
> >> #! /bin/bash
> >>
> >> case $(uname -s) in
> >> Darwin) OS=osx;;
> >> *) OS=linux;;
> >> esac
> >>
> >> TOPDIR=$(git rev-parse --show-toplevel)
> >> FORMAT=$TOPDIR/.git/clang-format/clang-format.$OS
> >>
> >> exec $FORMAT -i $(git show --pretty=format: --name-only)
>

Re: [IMPORTANT] New clang-format binaries / package

Posted by Leif Hedstrom <zw...@apache.org>.
It would be crazy huge, it takes hours to build. I'm even more -1 on incorporating all of clang and llvm (which you need).

-- Leif 



> On May 10, 2015, at 2:35 PM, Phil Sorber <so...@apache.org> wrote:
> 
>> On Sun, May 10, 2015 at 2:24 PM James Peach <jp...@apache.org> wrote:
>> 
>> 
>>> On Mar 31, 2015, at 11:33 AM, Leif Hedstrom <zw...@apache.org> wrote:
>>> 
>>> Hi all,
>>> 
>>> I’ve updated the tar-ball with the clang-format tools:
>>> 
>>>      http://people.apache.org/~zwoop/clang-format-03312015.tar.bz2
>>> 
>>> 
>>> The MD5 of the tar-ball is
>>> 
>>>      minotaur (18:28) 266/0 $ md5 clang-format-03312015.tar.bz2
>>>      MD5 (clang-format-03312015.tar.bz2) =
>> 6b3e7933f3e93b52361c88970bc0d8fe
>>> 
>>> 
>>> Please use this exact version of clang format. Currently, it has a
>> static binary for Linux, which I hope should work on most platforms (let me
>> know if it doesn’t). In addition, it also has a binary for OS X (Yosemite,
>> I have not tested on Maverick). It’s important we all use the same version,
>> so going forward, I’m versioning the packages as well, with the date. If
>> you are developing on a platform other then Linux and OS X, let me know and
>> I’ll try to make a version for that as well.
>>> 
>>> Question: Should we consider incorporating these binaries and scripts
>> into our source tree?
>> 
>> Yes, definitely!
> 
> I am -1 on binaries in the repo, but if we wanted to put the code and build
> it, I'd be ok with that. I assume the license is compatible?
> 
> 
>> 
>> FWIW, here’s a script that formats the top commit. It’s quite useful in
>> conjunction with "git rebase —exec” ...
>> 
>> #! /bin/bash
>> 
>> case $(uname -s) in
>> Darwin) OS=osx;;
>> *) OS=linux;;
>> esac
>> 
>> TOPDIR=$(git rev-parse --show-toplevel)
>> FORMAT=$TOPDIR/.git/clang-format/clang-format.$OS
>> 
>> exec $FORMAT -i $(git show --pretty=format: --name-only)

Re: [IMPORTANT] New clang-format binaries / package

Posted by Theo Schlossnagle <je...@omniti.com>.
I'm also -1 on compiled binaries in the repo.
On May 10, 2015 4:35 PM, "Phil Sorber" <so...@apache.org> wrote:

> On Sun, May 10, 2015 at 2:24 PM James Peach <jp...@apache.org> wrote:
>
> >
> > > On Mar 31, 2015, at 11:33 AM, Leif Hedstrom <zw...@apache.org> wrote:
> > >
> > > Hi all,
> > >
> > > I’ve updated the tar-ball with the clang-format tools:
> > >
> > >       http://people.apache.org/~zwoop/clang-format-03312015.tar.bz2
> > >
> > >
> > > The MD5 of the tar-ball is
> > >
> > >       minotaur (18:28) 266/0 $ md5 clang-format-03312015.tar.bz2
> > >       MD5 (clang-format-03312015.tar.bz2) =
> > 6b3e7933f3e93b52361c88970bc0d8fe
> > >
> > >
> > > Please use this exact version of clang format. Currently, it has a
> > static binary for Linux, which I hope should work on most platforms (let
> me
> > know if it doesn’t). In addition, it also has a binary for OS X
> (Yosemite,
> > I have not tested on Maverick). It’s important we all use the same
> version,
> > so going forward, I’m versioning the packages as well, with the date. If
> > you are developing on a platform other then Linux and OS X, let me know
> and
> > I’ll try to make a version for that as well.
> > >
> > > Question: Should we consider incorporating these binaries and scripts
> > into our source tree?
> >
> > Yes, definitely!
> >
>
> I am -1 on binaries in the repo, but if we wanted to put the code and build
> it, I'd be ok with that. I assume the license is compatible?
>
>
> >
> > FWIW, here’s a script that formats the top commit. It’s quite useful in
> > conjunction with "git rebase —exec” ...
> >
> > #! /bin/bash
> >
> > case $(uname -s) in
> > Darwin) OS=osx;;
> > *) OS=linux;;
> > esac
> >
> > TOPDIR=$(git rev-parse --show-toplevel)
> > FORMAT=$TOPDIR/.git/clang-format/clang-format.$OS
> >
> > exec $FORMAT -i $(git show --pretty=format: --name-only)
>

Re: [IMPORTANT] New clang-format binaries / package

Posted by Phil Sorber <so...@apache.org>.
On Sun, May 10, 2015 at 2:24 PM James Peach <jp...@apache.org> wrote:

>
> > On Mar 31, 2015, at 11:33 AM, Leif Hedstrom <zw...@apache.org> wrote:
> >
> > Hi all,
> >
> > I’ve updated the tar-ball with the clang-format tools:
> >
> >       http://people.apache.org/~zwoop/clang-format-03312015.tar.bz2
> >
> >
> > The MD5 of the tar-ball is
> >
> >       minotaur (18:28) 266/0 $ md5 clang-format-03312015.tar.bz2
> >       MD5 (clang-format-03312015.tar.bz2) =
> 6b3e7933f3e93b52361c88970bc0d8fe
> >
> >
> > Please use this exact version of clang format. Currently, it has a
> static binary for Linux, which I hope should work on most platforms (let me
> know if it doesn’t). In addition, it also has a binary for OS X (Yosemite,
> I have not tested on Maverick). It’s important we all use the same version,
> so going forward, I’m versioning the packages as well, with the date. If
> you are developing on a platform other then Linux and OS X, let me know and
> I’ll try to make a version for that as well.
> >
> > Question: Should we consider incorporating these binaries and scripts
> into our source tree?
>
> Yes, definitely!
>

I am -1 on binaries in the repo, but if we wanted to put the code and build
it, I'd be ok with that. I assume the license is compatible?


>
> FWIW, here’s a script that formats the top commit. It’s quite useful in
> conjunction with "git rebase —exec” ...
>
> #! /bin/bash
>
> case $(uname -s) in
> Darwin) OS=osx;;
> *) OS=linux;;
> esac
>
> TOPDIR=$(git rev-parse --show-toplevel)
> FORMAT=$TOPDIR/.git/clang-format/clang-format.$OS
>
> exec $FORMAT -i $(git show --pretty=format: --name-only)

Re: [IMPORTANT] New clang-format binaries / package

Posted by James Peach <jp...@apache.org>.
> On Mar 31, 2015, at 11:33 AM, Leif Hedstrom <zw...@apache.org> wrote:
> 
> Hi all,
> 
> I’ve updated the tar-ball with the clang-format tools:
> 
> 	http://people.apache.org/~zwoop/clang-format-03312015.tar.bz2
> 
> 
> The MD5 of the tar-ball is
> 
> 	minotaur (18:28) 266/0 $ md5 clang-format-03312015.tar.bz2
> 	MD5 (clang-format-03312015.tar.bz2) = 6b3e7933f3e93b52361c88970bc0d8fe
> 
> 
> Please use this exact version of clang format. Currently, it has a static binary for Linux, which I hope should work on most platforms (let me know if it doesn’t). In addition, it also has a binary for OS X (Yosemite, I have not tested on Maverick). It’s important we all use the same version, so going forward, I’m versioning the packages as well, with the date. If you are developing on a platform other then Linux and OS X, let me know and I’ll try to make a version for that as well.
> 
> Question: Should we consider incorporating these binaries and scripts into our source tree?

Yes, definitely!

FWIW, here’s a script that formats the top commit. It’s quite useful in conjunction with "git rebase —exec” ...

#! /bin/bash

case $(uname -s) in
Darwin) OS=osx;;
*) OS=linux;;
esac

TOPDIR=$(git rev-parse --show-toplevel)
FORMAT=$TOPDIR/.git/clang-format/clang-format.$OS

exec $FORMAT -i $(git show --pretty=format: --name-only)