You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Stephen Cooper (JIRA)" <de...@myfaces.apache.org> on 2008/02/25 07:24:51 UTC

[jira] Created: (TOMAHAWK-1200) Infinite loop when empty table with detailStamp is rendered

Infinite loop when empty table with detailStamp is rendered
-----------------------------------------------------------

                 Key: TOMAHAWK-1200
                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1200
             Project: MyFaces Tomahawk
          Issue Type: Bug
          Components: Extended Datatable
    Affects Versions: 1.1.6
         Environment: tested on Mac OS X
            Reporter: Stephen Cooper


I've found that the detailStamp facit will go into an infinite loop, setting row indexes higher and higher - way past the table size - until an OutOfMemory exception occurs (oddly enough, it occurs before the stack overflows).

I've isolated the code involved, and will attach a patch.  All I had to do was swap the order of two checks, so that we'd check if we've gotten to the end of the table before we check if the detailStamp for the current row is expanded.




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TOMAHAWK-1200) Infinite loop when empty table with detailStamp is rendered

Posted by "Stephen Cooper (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOMAHAWK-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephen Cooper updated TOMAHAWK-1200:
-------------------------------------

    Status: Patch Available  (was: Open)

> Infinite loop when empty table with detailStamp is rendered
> -----------------------------------------------------------
>
>                 Key: TOMAHAWK-1200
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1200
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.6
>         Environment: tested on Mac OS X
>            Reporter: Stephen Cooper
>
> I've found that the detailStamp facit will go into an infinite loop, setting row indexes higher and higher - way past the table size - until an OutOfMemory exception occurs (oddly enough, it occurs before the stack overflows).
> I've isolated the code involved, and will attach a patch.  All I had to do was swap the order of two checks, so that we'd check if we've gotten to the end of the table before we check if the detailStamp for the current row is expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TOMAHAWK-1200) Infinite loop when empty table with detailStamp is rendered

Posted by "Grant Smith (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOMAHAWK-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Smith updated TOMAHAWK-1200:
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.7-SNAPSHOT
           Status: Resolved  (was: Patch Available)

Patch applied. Thanks Stephen !

> Infinite loop when empty table with detailStamp is rendered
> -----------------------------------------------------------
>
>                 Key: TOMAHAWK-1200
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1200
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.6
>         Environment: tested on Mac OS X
>            Reporter: Stephen Cooper
>            Assignee: Grant Smith
>             Fix For: 1.1.7-SNAPSHOT
>
>         Attachments: HtmlDataTable.java.patch
>
>
> I've found that the detailStamp facit will go into an infinite loop, setting row indexes higher and higher - way past the table size - until an OutOfMemory exception occurs (oddly enough, it occurs before the stack overflows).
> I've isolated the code involved, and will attach a patch.  All I had to do was swap the order of two checks, so that we'd check if we've gotten to the end of the table before we check if the detailStamp for the current row is expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.