[GitHub] [flink] syhily commented on a diff in pull request #21075: [FLINK-28085][Connector/Pulsar] Close the pending Pulsar transactions before closing pipeline

[GitBox <gi...@apache.org>]

syhily commented on code in PR #21075:
URL: https://github.com/apache/flink/pull/21075#discussion_r997745089


##########
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/utils/PulsarTransactionUtils.java:
##########
@@ -60,6 +60,8 @@ public static Transaction createTransaction(PulsarClient pulsarClient, long time
     /**
      * This is a bug in original {@link TransactionCoordinatorClientException#unwrap(Throwable)}
      * method. Pulsar wraps the {@link ExecutionException} which hides the real execution exception.
+     *
+     * <p>This bug should be fixed after the 2.10.1 release. We just keep this for safety.

Review Comment:
   It was fixed in https://github.com/apache/pulsar/pull/14214. Pulsar will reclusively call the `unwrap` method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org